[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-read-all-stream-0.1. |nodejs-read-all-stream-0.1. |2-2.fc21|2-2.el6 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- nodejs-read-all-stream-0.1.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-read-all-stream-0.1. |nodejs-read-all-stream-0.1. |2-2.el6 |2-2.el7 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- nodejs-read-all-stream-0.1.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||nodejs-read-all-stream-0.1. ||2-2.fc20 Resolution|NEXTRELEASE |ERRATA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nodejs-read-all-stream-0.1.2-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-read-all-stream-0.1. |nodejs-read-all-stream-0.1. |2-2.fc20|2-2.fc19 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- nodejs-read-all-stream-0.1.2-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-read-all-stream-0.1. |nodejs-read-all-stream-0.1. |2-2.fc19|2-2.fc21 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- nodejs-read-all-stream-0.1.2-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 Parag pnem...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-12-10 04:05:03 --- Comment #10 from Parag pnem...@redhat.com --- Closing this review as package is built now, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 Parag pnem...@redhat.com changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- nodejs-read-all-stream-0.1.2-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-read-all-stream-0.1.2-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- nodejs-read-all-stream-0.1.2-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-read-all-stream-0.1.2-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- nodejs-read-all-stream-0.1.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-read-all-stream-0.1.2-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- nodejs-read-all-stream-0.1.2-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-read-all-stream-0.1.2-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- nodejs-read-all-stream-0.1.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-read-all-stream-0.1.2-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 --- Comment #1 from Parag pnem...@redhat.com --- upstream test.js is failing so disabled tests Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-read-all-stream.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-read-all-stream-0.1.2-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235
Piotr Popieluch piotr1...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||piotr1...@gmail.com
Flags||fedora-review+
--- Comment #2 from Piotr Popieluch piotr1...@gmail.com ---
License in srpm differs from upstream, please download license from upstream
and rebuild srpm before pushing to SCM
APPROVED
cat nodejs-read-all-stream/diff.txt
diff -U2 -r
/home/piotr/rpmbuild/nodejs-read-all-stream/upstream-unpacked/Source1/license
/home/piotr/rpmbuild/nodejs-read-all-stream/srpm-unpacked/license-extract/license
---
/home/piotr/rpmbuild/nodejs-read-all-stream/upstream-unpacked/Source1/license
2014-12-07 19:17:01.262835277 +0100
+++
/home/piotr/rpmbuild/nodejs-read-all-stream/srpm-unpacked/license-extract/license
2014-12-07 19:17:01.281835488 +0100
@@ -1,5 +1,5 @@
The MIT License (MIT)
-Copyright (c) Vsevolod Strukchinsky floatd...@gmail.com
+Copyright (c) Sindre Sorhus sindresor...@gmail.com (sindresorhus.com)
Permission is hereby granted, free of charge, to any person obtaining a copy
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Sources used to build the package match the upstream source, as provided in
the spec URL.
Note: Upstream MD5sum check error, diff is in /home/piotr/rpmbuild/nodejs-
read-all-stream/diff.txt
See: http://fedoraproject.org/wiki/Packaging/SourceURL
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 2 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/nodejs-read-all-
stream/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream,
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|piotr1...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 --- Comment #3 from Parag pnem...@redhat.com --- sorry for this confusion. I have fixed this in below update. no release bump. Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-read-all-stream.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-read-all-stream-0.1.2-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 Parag pnem...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Parag pnem...@redhat.com --- Thank you for this review. New Package SCM Request === Package Name: nodejs-read-all-stream Short Description: Read all stream content and pass it to callback Upstream URL: https://github.com/floatdrop/read-all-stream Owners: pnemade Branches: f19 f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171235] Review Request: nodejs-read-all-stream - Read all stream content and pass it to callback
https://bugzilla.redhat.com/show_bug.cgi?id=1171235 Parag pnem...@redhat.com changed: What|Removed |Added Blocks||1171236 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1171236 [Bug 1171236] Review Request: nodejs-got - Simplified HTTP/HTTPS requests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
