[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Fedora Update System changed: What|Removed |Added Fixed In Version|resolv_wrapper-1.1.0-2.fc20 |resolv_wrapper-1.1.0-2.fc21 --- Comment #18 from Fedora Update System --- resolv_wrapper-1.1.0-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||resolv_wrapper-1.1.0-2.fc20 Resolution|--- |ERRATA Last Closed||2015-01-03 14:07:53 --- Comment #17 from Fedora Update System --- resolv_wrapper-1.1.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System --- resolv_wrapper-1.1.0-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 --- Comment #15 from Fedora Update System --- resolv_wrapper-1.1.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/resolv_wrapper-1.1.0-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 --- Comment #14 from Fedora Update System --- resolv_wrapper-1.1.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/resolv_wrapper-1.1.0-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Andreas Schneider changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Andreas Schneider --- New Package SCM Request === Package Name: resolv_wrapper Short Description: A wrapper for dns name resolving or dns faking Upstream URL: http://cwrap.org/resolv_wrapper.html Owners: asn jhrozek obnox Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Michael Adam changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Michael Adam --- Thanks. The updates addresses all my concenrs. The licensing is OK, since the shipped files are all BSD, as the package, only parts of the test cases contain GPL code. ==> Good to go. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 --- Comment #10 from Andreas Schneider --- Package updated: Spec URL: http://xor.cryptomilk.org/rpm/resolv_wrapper/resolv_wrapper.spec SRPM URL: http://xor.cryptomilk.org/rpm/resolv_wrapper/resolv_wrapper-1.1.0-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 --- Comment #9 from Michael Adam --- Summary: - upstream licensing not uniform. fix? - problems with owning libdir/pkgconfig|cmake: fixes proposed. - changelog format error and language error: fixes provided Andreas: OK? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 --- Comment #8 from Michael Adam --- Created attachment 969298 --> https://bugzilla.redhat.com/attachment.cgi?id=969298&action=edit patch for spec file Diff of proposed patch to specfile. Corresponding changes to socket|uid|nss_wrapper are in preparation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Michael Adam changed: What|Removed |Added Attachment #969297|ldk |proposed modified SPEC-file description|| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 --- Comment #7 from Michael Adam --- Created attachment 969297 --> https://bugzilla.redhat.com/attachment.cgi?id=969297&action=edit ldk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 --- Comment #6 from Michael Adam --- Created attachment 969296 --> https://bugzilla.redhat.com/attachment.cgi?id=969296&action=edit rpmlint.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Michael Adam changed: What|Removed |Added Attachment #969295|,jk |licensecheck.txt description|| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 --- Comment #5 from Michael Adam --- Created attachment 969295 --> https://bugzilla.redhat.com/attachment.cgi?id=969295&action=edit ,jk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534
--- Comment #4 from Michael Adam ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files directly in %_libdir.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
---> OK: this whole package is for development, hence no separate devel
package
- License of files not uniform: most BSD, one GPLv3+, one without license
---> TODO: fix upstream?
- Problem with owning {_libdir}/cmake,pkgconfig directories:
---> Proposal for added Requires and changed files.
- Changelog has format error.
---> Fix provided.
- Language error in %description:
---> "lookup the address ... via" ---> "look the address ... up via"
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
---> manual check
[x]: Package contains no static executables.
---> manual check (no executables at all)
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
---> ok: BSD
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"BSD (3 clause)", "GPL (v3 or later)", "Unknown or generated". 1 files
have unknown license. Detailed output of licensecheck in
/home/obnox/1172534-resolv_wrapper/licensecheck.txt
---> TODO: fix upstream?
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/cmake
---> "Require: cmake"
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/lib64/pkgconfig(socket_wrapper, nss_wrapper, pkgconfig, uid_wrapper)
---> don't own pgkconfig dir and +"Require: pkgconfig"
[x]: %build honors applicable compiler flags or justifies otherwise.
---> the %cmake expands...
[?]: Package contains no bundled libraries without FPC exception.
---> what precisely is this?
[!]: Changelog in prescribed format.
---> no dash between date and author
[x]: Sources contain only permissible code or content.
---> ok
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
---> the whole package is for development
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
---> adaptions proposed due to issue with directories
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 4 files.
[!]: Package complies to the Packaging Guidelines
---> except for the issues listed
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provi
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Jakub Hrozek changed: What|Removed |Added CC||jhro...@redhat.com --- Comment #3 from Jakub Hrozek --- Thank you very much, we have quite a few sssd bugs these days so I appreciate it :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Michael Adam changed: What|Removed |Added CC||ma...@redhat.com Assignee|jhro...@redhat.com |ma...@redhat.com --- Comment #2 from Michael Adam --- I started to do the review. Will post an update shorty. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Andreas Schneider changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|jhro...@redhat.com --- Comment #1 from Andreas Schneider --- Jakub, could you please do the review for resolv_wrapper? :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172534] Review Request: resolv_wrapper - A wrapper for dns name resolving or dns faking
https://bugzilla.redhat.com/show_bug.cgi?id=1172534 Andreas Schneider changed: What|Removed |Added CC||a...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
