[Bug 1173656] Review Request: jags - Just Another Gibbs Sampler
https://bugzilla.redhat.com/show_bug.cgi?id=1173656 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|fedora-review+ | Last Closed||2020-09-12 07:10:59 --- Comment #9 from Mattia Verga --- The original reporter account has been disabled, marking this as DEADREVIEW. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1173656] Review Request: jags - Just Another Gibbs Sampler
https://bugzilla.redhat.com/show_bug.cgi?id=1173656 Mattia Verga changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Mattia Verga --- Fine then, I ran some manual checks since fedora-review is unable to perform them and everything seems ok, just beware about using a glob when listing shared libraries: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files package APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1173656] Review Request: jags - Just Another Gibbs Sampler
https://bugzilla.redhat.com/show_bug.cgi?id=1173656 --- Comment #7 from Tom "spot" Callaway --- Very strange. Looks like there is a timing issue in texlive somewhere. I can disable doc generation if you think it is necessary to complete the review, but I suspect it may just take a few build attempts to get a success on all arches. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1173656] Review Request: jags - Just Another Gibbs Sampler
https://bugzilla.redhat.com/show_bug.cgi?id=1173656 --- Comment #6 from Mattia Verga --- The above error is also returned in Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=47631095 I suspect this is triggered randomly, since in your previous Koji scratch build that didn't happen (also, this last time is jags_user_manual.pdf which triggers the error). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1173656] Review Request: jags - Just Another Gibbs Sampler
https://bugzilla.redhat.com/show_bug.cgi?id=1173656 --- Comment #5 from Tom "spot" Callaway --- Well, that's weird. Not sure why mock would fail when koji succeeds. I can reproduce it though, but only in mock with --isolation=nspawn: pdflatex: fatal: Could not undump 233630 8-byte item(s) from /builddir/.texlive2020/texmf-var/web2c/pdftex/pdflatex.fmt. mktexfmt [INFO]: /builddir/.texlive2020/texmf-var/web2c/pdftex/pdflatex.fmt installed. make[2]: *** [Makefile:674: jags_developer_manual.pdf] Error 1 When I run mock with --isolation=simple, it works as expected. Perhaps that's what koji uses? License tag fixed in -2. New Spec URL: https://spot.fedorapeople.org/jags.spec New SRPM URL: https://spot.fedorapeople.org/jags-4.3.0-2.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1173656] Review Request: jags - Just Another Gibbs Sampler
https://bugzilla.redhat.com/show_bug.cgi?id=1173656 --- Comment #4 from Mattia Verga --- The mock build made by fedora-review fails: + cp -pr doc/manual/jags_developer_manual.pdf /builddir/build/BUILDROOT/jags-4.3.0-1.fc33.x86_64/usr/share/doc/jags-devel cp: cannot stat 'doc/manual/jags_developer_manual.pdf': No such file or directory + : + RPM_EC=0 ++ jobs -p + exit 0 error: File not found: /builddir/build/BUILDROOT/jags-4.3.0-1.fc33.x86_64/usr/share/doc/jags-devel/jags_developer_manual.pdf RPM build errors: File not found: /builddir/build/BUILDROOT/jags-4.3.0-1.fc33.x86_64/usr/share/doc/jags-devel/jags_developer_manual.pdf Child return code was: 1 Also, the License tag value (GPL+) doesn't seem to be correct, the project homepage says it's GPLv2. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1173656] Review Request: jags - Just Another Gibbs Sampler
https://bugzilla.redhat.com/show_bug.cgi?id=1173656 Mattia Verga changed: What|Removed |Added Status|NEW |ASSIGNED CC||mattia.ve...@protonmail.com Assignee|nob...@fedoraproject.org|mattia.ve...@protonmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1173656] Review Request: jags - Just Another Gibbs Sampler
https://bugzilla.redhat.com/show_bug.cgi?id=1173656 Tom "spot" Callaway changed: What|Removed |Added CC||spo...@gmail.com Flags|needinfo?(tcallawa@redhat.c | |om) | --- Comment #3 from Tom "spot" Callaway --- 6-year-old unreviewed package submission? LET'S DO THIS. New Spec URL: https://spot.fedorapeople.org/jags.spec New SRPM URL: https://spot.fedorapeople.org/jags-4.3.0-1.fc33.src.rpm Koji (Rawhide) Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=46961181 Fedora Account Name: spot Who wants to be a necromancer and revive this from the dead? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
needinfo canceled: [Bug 1173656] Review Request: jags - Just Another Gibbs Sampler
Product: Fedora Version: rawhide Component: Package Review Tom "spot" Callaway has canceled Package Review 's request for Tom "spot" Callaway 's needinfo: Bug 1173656: Review Request: jags - Just Another Gibbs Sampler https://bugzilla.redhat.com/show_bug.cgi?id=1173656 --- Comment #3 from Tom "spot" Callaway --- 6-year-old unreviewed package submission? LET'S DO THIS. New Spec URL: https://spot.fedorapeople.org/jags.spec New SRPM URL: https://spot.fedorapeople.org/jags-4.3.0-1.fc33.src.rpm Koji (Rawhide) Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=46961181 Fedora Account Name: spot Who wants to be a necromancer and revive this from the dead? ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1173656] Review Request: jags - Just Another Gibbs Sampler
https://bugzilla.redhat.com/show_bug.cgi?id=1173656 --- Comment #1 from Michael Schwendt (Fedora Packager Sponsors Group) --- > %{_libdir}/libjrmath.so.* is a bundled lib from R with a small modification. See README in src/jrmath. A typical question with regard to bundling is: has anything been done to get this change included in the current API of R's math lib? > libltdl/* is a bundled libtool dlopen lib. It is compiled but not linked with. Getting upstream configure script to disable this bundled lib, so it could be deleted and would not be compiled/linked with accidentally, would be a good thing. > Patch0: JAGS-3.4.0-fix-fsf-address.patch It patches file COPYING. Please clarify the following: https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address | The license file, usually COPYING, must not be patched for legal reasons. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review