[Bug 1175312] Review Request: plasma-milou - A dedicated KDE search application built on top of Baloo
https://bugzilla.redhat.com/show_bug.cgi?id=1175312 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2015-01-20 08:42:15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175312] Review Request: plasma-milou - A dedicated KDE search application built on top of Baloo
https://bugzilla.redhat.com/show_bug.cgi?id=1175312 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Jan Grulich jgrul...@redhat.com --- New Package SCM Request === Package Name: plasma-milou Short Description: A dedicated KDE search application built on top of Baloo Upstream URL: https://projects.kde.org/projects/kde/workspace/milou Owners: group::kde-sig rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175312] Review Request: plasma-milou - A dedicated KDE search application built on top of Baloo
https://bugzilla.redhat.com/show_bug.cgi?id=1175312 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175312] Review Request: plasma-milou - A dedicated KDE search application built on top of Baloo
https://bugzilla.redhat.com/show_bug.cgi?id=1175312 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175312] Review Request: plasma-milou - A dedicated KDE search application built on top of Baloo
https://bugzilla.redhat.com/show_bug.cgi?id=1175312 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags||needinfo?(rdie...@math.unl. ||edu) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175312] Review Request: plasma-milou - A dedicated KDE search application built on top of Baloo
https://bugzilla.redhat.com/show_bug.cgi?id=1175312
Rex Dieter rdie...@math.unl.edu changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
|needinfo?(rdie...@math.unl. |
|edu)|
--- Comment #3 from Rex Dieter rdie...@math.unl.edu ---
Looks good, thanks... APPROVED.
then we can retire kde-plasma-milou for f22+, I suppose for added safety you
could also consider adding:
Provides: kde-plasma-milou = %{version}=%{release}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175312] Review Request: plasma-milou - A dedicated KDE search application built on top of Baloo
https://bugzilla.redhat.com/show_bug.cgi?id=1175312 --- Comment #2 from Jan Grulich jgrul...@redhat.com --- Naming: We are using kde-plasma- prefix for applets so I'm not sure right now what to use for milou. I also just realized that we already have kde-plasma-milou package so if you want to keep it we can discard this review and just update the current package. 1. Fixed 2. Fixed 3. Fixed Spec URL: https://jgrulich.fedorapeople.org/plasma5/plasma-milou.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/plasma-milou-5.1.1-1.fc21.src.rpm Description: A dedicated KDE search application built on top of Baloo Fedora Account System Username: jgrulich -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175312] Review Request: plasma-milou - A dedicated KDE search application built on top of Baloo
https://bugzilla.redhat.com/show_bug.cgi?id=1175312 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175312] Review Request: plasma-milou - A dedicated KDE search application built on top of Baloo
https://bugzilla.redhat.com/show_bug.cgi?id=1175312
--- Comment #1 from Rex Dieter rdie...@math.unl.edu ---
Naming: OK (mostly)
(I think I'd prefer to simply call this milou, without the artificial plasma-
prefix, but we're already using that in other plasma applets, so maybe it's too
late to reverse course now)
1. URL Not OK
Please use,
URL: https://projects.kde.org/projects/kde/workspace/milou
2. SHOULD not use %make_install macro (not recommended by packaging
guidelines... yet)
I'd prefer:
make install/fast DESTDIR=%{buildroot} -C %{_target_platform}
over
%make_install -C %{_target_platform}
macros: NOT OK
3. SHOULD use %_kf5_qmldir macro
replace
%{_qt5_prefix}/qml/org/kde/milou
with
%{_kf5_qmldir}/org/kde/milou/
sources: OK
b99660be2145dae3144e8e004c649ec6 milou-5.1.1.tar.xz
licensing: OK
scriptlets: OK
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175312] Review Request: plasma-milou - A dedicated KDE search application built on top of Baloo
https://bugzilla.redhat.com/show_bug.cgi?id=1175312 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Blocks||1135103 (plasma5) Alias||plasma-milou Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1135103 [Bug 1135103] Plasma 5 Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
