[Bug 1175471] Review Request: fleet - A distributed init system

2015-02-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471

Peter Lemenkov  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||fleet-0.9.0-4.fc22
 Resolution|--- |RAWHIDE
Last Closed||2015-02-10 08:46:41



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-02-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #20 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-02-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-02-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471

Peter Lemenkov  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #19 from Peter Lemenkov  ---
(In reply to Jan Chaloupka from comment #17)
> I forget to add Requires to devel packages for all its BuildRequires. So
> when you install fleet devel subpackage, you must install all its deps if
> fleet devel happens to be a buildtime dependency of another package:
> 
> Requires: golang(google.golang.org/api/googleapi)
> Requires: golang(github.com/coreos/go-semver/semver)
> Requires: golang(github.com/coreos/go-systemd/activation)
> Requires: golang(github.com/coreos/go-systemd/dbus)
> Requires: golang(github.com/coreos/go-systemd/unit)
> Requires: golang(github.com/docker/libcontainer/netlink)
> Requires: golang(github.com/godbus/dbus)
> Requires: golang(github.com/jonboulle/clockwork)
> Requires: golang(github.com/rakyll/globalconf)
> Requires: golang(github.com/rakyll/goini)
> Requires: golang(golang.org/x/crypto/ssh)
> 
> Please add those below BuildRequires of devel subpackage.

Done (didn't raise the %release number though).

* https://peter.fedorapeople.org/fleet.spec
* https://peter.fedorapeople.org/fleet-0.9.0-4.fc21.src.rpm

(In reply to Jan Chaloupka from comment #18)
> Otherwise spec file complies with Go packaging draft [1]
> 
> [1] https://fedoraproject.org/wiki/PackagingDrafts/Go

Thanks!

New Package SCM Request
===
Package Name: fleet
Short Description: A distributed init system
Upstream URL: https://github.com/coreos/fleet/
Owners: peter lsm5 jchaloup vbatts
Branches: f21 epel7
InitialCC: golang-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-02-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471

Jan Chaloupka  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-02-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471

Jan Chaloupka  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #18 from Jan Chaloupka  ---
Otherwise spec file complies with Go packaging draft [1]

[1] https://fedoraproject.org/wiki/PackagingDrafts/Go

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-02-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #17 from Jan Chaloupka  ---
I forget to add Requires to devel packages for all its BuildRequires. So when
you install fleet devel subpackage, you must install all its deps if fleet
devel happens to be a buildtime dependency of another package:

Requires:golang(google.golang.org/api/googleapi)
Requires:golang(github.com/coreos/go-semver/semver)
Requires:golang(github.com/coreos/go-systemd/activation)
Requires:golang(github.com/coreos/go-systemd/dbus)
Requires:golang(github.com/coreos/go-systemd/unit)
Requires:golang(github.com/docker/libcontainer/netlink)
Requires:golang(github.com/godbus/dbus)
Requires:golang(github.com/jonboulle/clockwork)
Requires:golang(github.com/rakyll/globalconf)
Requires:golang(github.com/rakyll/goini)
Requires:golang(golang.org/x/crypto/ssh)

Please add those below BuildRequires of devel subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-02-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #16 from Peter Lemenkov  ---
(In reply to Jan Chaloupka from comment #15)
> Added:
> -devel subpackage
> -%repo, %provider, ... global variables
> 
> Otherwise it looks good.

Updated the package according to your comments (and added one additional
patch):

* https://peter.fedorapeople.org/fleet.spec
* https://peter.fedorapeople.org/fleet-0.9.0-4.fc21.src.rpm

Here is a scratchbuild for Rawhide:

* http://koji.fedoraproject.org/koji/taskinfo?taskID=8883895

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-01-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471
Bug 1175471 depends on bug 1177486, which changed state.

Bug 1177486 Summary: Review Request: golang-github-glacjay-goini - INI file 
parser in go
https://bugzilla.redhat.com/show_bug.cgi?id=1177486

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-01-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471
Bug 1175471 depends on bug 1177487, which changed state.

Bug 1177487 Summary: Review Request: golang-github-rakyll-globalconf - 
Effortlessly persist and read flag values from an ini config file
https://bugzilla.redhat.com/show_bug.cgi?id=1177487

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-01-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #15 from Jan Chaloupka  ---
Added:
-devel subpackage
-%repo, %provider, ... global variables

Otherwise it looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-01-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #14 from Jan Chaloupka  ---
Created attachment 982295
  --> https://bugzilla.redhat.com/attachment.cgi?id=982295&action=edit
spec file modification

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-01-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471

Jan Chaloupka  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jchal...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-01-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #13 from Peter Lemenkov  ---
Ok, here it is:

* https://peter.fedorapeople.org/fleet.spec
* https://peter.fedorapeople.org/fleet-0.9.0-3.fc21.src.rpm

Koji scratchbuild for Rawhide:

* http://koji.fedoraproject.org/koji/taskinfo?taskID=8676520

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-01-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #12 from Peter Lemenkov  ---
Ah got that:

*
http://pkgs.fedoraproject.org/cgit/golang-github-coreos-go-systemd.git/commit/?id=204f61c

Wait a bit more - I'll update dependencies again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-01-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #11 from Peter Lemenkov  ---
Oops! Did I miss something?

http://koji.fedoraproject.org/koji/taskinfo?taskID=8676363
...
DEBUG util.py:366:  Error: No Package found for
golang(github.com/coreos/go-systemd)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-01-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #10 from Peter Lemenkov  ---
(In reply to Jan Chaloupka from comment #9)
> Peter,
> 
> github.com/rakyll/globalconf and github.com/rakyll/goini are packaged. Is
> fleet ready for Fedora? Sorry for being late with the packaging.
> 
> Regards
> Jan

Jan, wait a second - I'll provide a new package (dependent on these two ones
you've just submitted).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-01-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #9 from Jan Chaloupka  ---
Peter,

github.com/rakyll/globalconf and github.com/rakyll/goini are packaged. Is fleet
ready for Fedora? Sorry for being late with the packaging.

Regards
Jan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2015-01-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471
Bug 1175471 depends on bug 1175771, which changed state.

Bug 1175771 Summary: Review Request: golang-github-jonboulle-clockwork - A fake 
clock for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1175771

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2014-12-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #8 from Jan Chaloupka  ---
Lokesh, I have assigned those two bugs on you.

Peter, don't hesitate to make a review of them if you have some spare time.

Happy New Year :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2014-12-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471

Jan Chaloupka  changed:

   What|Removed |Added

 Depends On||1177487, 1177486



--- Comment #7 from Jan Chaloupka  ---
Done. Must update the test for deps in Godeps folder. Thanks.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1177486
[Bug 1177486] Review Request: golang-github-rakyll-goini - INI file parser
in go
https://bugzilla.redhat.com/show_bug.cgi?id=1177487
[Bug 1177487] Review Request: golang-github-rakyll-globalconf -
Effortlessly persist and read flag values from an ini config file
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2014-12-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #6 from Lokesh Mandvekar  ---
s/do/to

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2014-12-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #5 from Lokesh Mandvekar  ---
Hi Peter, we don't need do redefine %{gopath} anymore (since golang-1.2.1-3)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2014-12-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #4 from Peter Lemenkov  ---
(In reply to Jan Chaloupka from comment #1)
> Just for info:
...
>   github.com/jonboulle/clockwork
>   github.com/rakyll/globalconf
>   github.com/rakyll/goini
...
> So far github.com/jonboulle/clockwork is not in Fedora, the rest is. I can
> prepare a review request of github.com/jonboulle/clockwork, what do you
> think?

Jan, thanks for the "github.com/jonboulle/clockwork" but unfortunately that's
not enough. We need "github.com/rakyll/globalconf" and
"github.com/rakyll/goini" as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2014-12-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471

Jan Chaloupka  changed:

   What|Removed |Added

 Depends On||1175771




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1175771
[Bug 1175771] Review Request: golang-github-jonboulle-clockwork - A fake
clock for golang
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2014-12-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #3 from Peter Lemenkov  ---
Ok, this is something:

* https://peter.fedorapeople.org/fleet.spec
* https://peter.fedorapeople.org/fleet-0.9.0-3.fc21.src.rpm

Not all packages are debundled and some patches are required in order to build
against ones available in Fedora/EPEL though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2014-12-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #2 from Peter Lemenkov  ---
(In reply to Jan Chaloupka from comment #1)
> Just for info:
> 
> So far github.com/jonboulle/clockwork is not in Fedora, the rest is. I can
> prepare a review request of github.com/jonboulle/clockwork, what do you
> think?

Yes, that would be great! I'll review it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2014-12-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471



--- Comment #1 from Jan Chaloupka  ---
Just for info:

fleet-0.9.0]$ go2fed ggi | grep Godeps | sed
's/github\.com\/coreos\/fleet\/Godeps\/_workspace\/src\///'
code.google.com/p/google-api-go-client/googleapi
github.com/coreos/go-semver/semver
github.com/coreos/go-systemd/activation
github.com/coreos/go-systemd/dbus
github.com/coreos/go-systemd/unit
github.com/docker/libcontainer/netlink
github.com/godbus/dbus
github.com/godbus/dbus/introspect
github.com/jonboulle/clockwork
github.com/rakyll/globalconf
github.com/rakyll/goini
golang.org/x/crypto/ssh
golang.org/x/crypto/ssh/agent
golang.org/x/crypto/ssh/terminal
golang.org/x/crypto/ssh/testdata

So far github.com/jonboulle/clockwork is not in Fedora, the rest is. I can
prepare a review request of github.com/jonboulle/clockwork, what do you think?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1175471] Review Request: fleet - A distributed init system

2014-12-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1175471

Peter Lemenkov  changed:

   What|Removed |Added

 CC||golang@lists.fedoraproject.
   ||org, l...@redhat.com,
   ||mat...@redhat.com
 Whiteboard||NotReady



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review