[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-through2-0.6.3-1.el7 |nodejs-through2-0.6.3-1.el6 --- Comment #18 from Fedora Update System --- nodejs-through2-0.6.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-through2-0.6.3-1.fc2 |nodejs-through2-0.6.3-1.el7 |0 | --- Comment #17 from Fedora Update System --- nodejs-through2-0.6.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-through2-0.6.3-1.fc2 |nodejs-through2-0.6.3-1.fc2 |1 |0 --- Comment #16 from Fedora Update System --- nodejs-through2-0.6.3-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-through2-0.6.3-1.fc2 ||1 Resolution|NEXTRELEASE |ERRATA --- Comment #15 from Fedora Update System --- nodejs-through2-0.6.3-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Bug 1176808 depends on bug 1176881, which changed state. Bug 1176881 Summary: Review Request: nodejs-bl - A Node.js Buffer list collector, reader and streamer https://bugzilla.redhat.com/show_bug.cgi?id=1176881 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Bug 1176808 depends on bug 1177463, which changed state. Bug 1177463 Summary: Review Request: nodejs-stream-spigot - Testing or converting simple functions into Readable streams https://bugzilla.redhat.com/show_bug.cgi?id=1177463 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Parag changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-12-30 23:53:44 --- Comment #14 from Parag --- Built in rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 --- Comment #13 from Fedora Update System --- nodejs-through2-0.6.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-through2-0.6.3-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 --- Comment #12 from Fedora Update System --- nodejs-through2-0.6.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-through2-0.6.3-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 --- Comment #11 from Fedora Update System --- nodejs-through2-0.6.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-through2-0.6.3-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 --- Comment #10 from Fedora Update System --- nodejs-through2-0.6.3-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-through2-0.6.3-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 --- Comment #9 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Parag changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #8 from Parag --- Hey Piotr, Nice catch for license tag. Fixed in same srpm. Thank you for this review. New Package SCM Request === Package Name: nodejs-through2 Short Description: Node streams2 Transform wrapper to avoid explicit subclassing noise Upstream URL: https://github.com/rvagg/through2 Owners: pnemade Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808
Piotr Popieluch changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #7 from Piotr Popieluch ---
Everything except the license looks good.
Will APPROVE this but please correct the license before pushing to scm.
ISSUE:
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 5 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1176808-nodejs-
through2/licensecheck.txt
License should be MITNFA:
https://fedoraproject.org/wiki/Licensing/MITNFA
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 5 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1176808-nodejs-
through2/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Rev
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 --- Comment #6 from Piotr Popieluch --- It seems that the license is MITNFA not MIT. Could you please correct that? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 --- Comment #5 from Parag --- I have already submitted nodejs-streaam-spigot for package review. See https://bugzilla.redhat.com/show_bug.cgi?id=1177463 BR: npm(tape) added please check again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 --- Comment #4 from Piotr Popieluch --- Mock build fails. Tests need BR: npm(tape), could you please add this? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 --- Comment #3 from Piotr Popieluch --- Build fails due to missing deps for tests, could you disable the tests? DEBUG util.py:366: Getting requirements for nodejs-through2-0.6.3-1.fc22.src DEBUG util.py:366: --> nodejs-packaging-7-2.fc21.noarch DEBUG util.py:366: --> nodejs-bl-0.9.3-1.fc22.noarch DEBUG util.py:366: --> nodejs-tap-0.4.4-3.fc22.noarch DEBUG util.py:366: --> nodejs-xtend-4.0.0-2.fc22.noarch DEBUG util.py:366: Error: No Package found for npm(stream-spigot) DEBUG util.py:476: Child return code was: 1 DEBUG util.py:161: kill orphans DEBUG util.py:495: child environment: None -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Parag changed: What|Removed |Added Depends On||1176881, 1177463 --- Comment #2 from Parag --- Updated please check again. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1176881 [Bug 1176881] Review Request: nodejs-bl - A Node.js Buffer list collector, reader and streamer https://bugzilla.redhat.com/show_bug.cgi?id=1177463 [Bug 1177463] Review Request: nodejs-stream-spigot - Testing or converting simple functions into Readable streams -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Piotr Popieluch changed: What|Removed |Added CC||piotr1...@gmail.com Assignee|nob...@fedoraproject.org|piotr1...@gmail.com --- Comment #1 from Piotr Popieluch --- - Summary/Description is too long, please make it shorter. - Source0 is different in spec and srpm, please update spec or rebuild srpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Parag changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Parag changed: What|Removed |Added Blocks||1176811 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1176811 [Bug 1176811] Review Request: nodejs-duplexify - Turn a writeable and readable stream into a single streams2 duplex stream -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Parag changed: What|Removed |Added Summary|Review Request: - A tiny |nodejs-through2 - A tiny |wrapper around Node |wrapper around Node |streams2 Transform to avoid |streams2 Transform to avoid |explicit subclassing noise |explicit subclassing noise -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
