[Bug 1177406] Review Request: csvcat - Efficiently concatenate CSVs or other tabular text files
https://bugzilla.redhat.com/show_bug.cgi?id=1177406 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||csvcat-0.1-20141205git858ed ||fe.fc21 Resolution|--- |ERRATA Last Closed||2015-02-20 23:23:16 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- csvcat-0.1-20141205git858edfe.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177406] Review Request: csvcat - Efficiently concatenate CSVs or other tabular text files
https://bugzilla.redhat.com/show_bug.cgi?id=1177406 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- csvcat-0.1-20141205git858edfe.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177406] Review Request: csvcat - Efficiently concatenate CSVs or other tabular text files
https://bugzilla.redhat.com/show_bug.cgi?id=1177406 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177406] Review Request: csvcat - Efficiently concatenate CSVs or other tabular text files
https://bugzilla.redhat.com/show_bug.cgi?id=1177406 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- csvcat-0.1-20141205git858edfe.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/csvcat-0.1-20141205git858edfe.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177406] Review Request: csvcat - Efficiently concatenate CSVs or other tabular text files
https://bugzilla.redhat.com/show_bug.cgi?id=1177406 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177406] Review Request: csvcat - Efficiently concatenate CSVs or other tabular text files
https://bugzilla.redhat.com/show_bug.cgi?id=1177406 --- Comment #2 from William Moreno williamjmore...@gmail.com --- New Package SCM Request === Package Name: csvcat Short Description: Efficiently concatenate CSVs or other tabular text files Upstream URL: https://github.com/jsvine/csvcat Owners: williamjmorenor Branches: f20 f21 master InitialCC: williamjmorenor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177406] Review Request: csvcat - Efficiently concatenate CSVs or other tabular text files
https://bugzilla.redhat.com/show_bug.cgi?id=1177406 William Moreno williamjmore...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177406] Review Request: csvcat - Efficiently concatenate CSVs or other tabular text files
https://bugzilla.redhat.com/show_bug.cgi?id=1177406 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177406] Review Request: csvcat - Efficiently concatenate CSVs or other tabular text files
https://bugzilla.redhat.com/show_bug.cgi?id=1177406
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags|fedora-review? |fedora-review+
--- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build for f21:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8593232
$ rpmlint -i -v *
csvcat.noarch: I: checking
csvcat.noarch: I: checking-url https://github.com/jsvine/csvcat (timeout 10
seconds)
csvcat.noarch: W: no-manual-page-for-binary csvcat
Each executable in standard binary directories should have a man page.
csvcat.src: I: checking
csvcat.src: I: checking-url https://github.com/jsvine/csvcat (timeout 10
seconds)
csvcat.src: I: checking-url
https://github.com/jsvine/csvcat/archive/858edfe15637f95d77ace9d375235235115f1bc2/csvcat-858edfe15637f95d77ace9d375235235115f1bc2.tar.gz
(timeout 10 seconds)
csvcat.spec: I: checking
csvcat.spec: I: checking-url
https://github.com/jsvine/csvcat/archive/858edfe15637f95d77ace9d375235235115f1bc2/csvcat-858edfe15637f95d77ace9d375235235115f1bc2.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
MIT
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
4f11f2913673ac4482864d49d45fbfa3f5b83425cec48b8fabfeb2f4465898bd
csvcat-858edfe15637f95d77ace9d375235235115f1bc2.tar.gz
4f11f2913673ac4482864d49d45fbfa3f5b83425cec48b8fabfeb2f4465898bd
csvcat-858edfe15637f95d77ace9d375235235115f1bc2.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc
