[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 Hans de Goede changed: What|Removed |Added CC||hdego...@redhat.com --- Comment #16 from Hans de Goede --- *** Bug 1295138 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 Fedora Update System changed: What|Removed |Added Fixed In Version|marsshooter-0.7.5-5.2014050 |marsshooter-0.7.5-5.2014050 |7gitc855d04.fc20|7gitc855d04.fc21 --- Comment #15 from Fedora Update System --- marsshooter-0.7.5-5.20140507gitc855d04.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 Fedora Update System changed: What|Removed |Added Fixed In Version||marsshooter-0.7.5-5.2014050 ||7gitc855d04.fc20 Resolution|NEXTRELEASE |ERRATA --- Comment #14 from Fedora Update System --- marsshooter-0.7.5-5.20140507gitc855d04.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 --- Comment #13 from Fedora Update System --- marsshooter-0.7.5-5.20140507gitc855d04.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/marsshooter-0.7.5-5.20140507gitc855d04.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 MartinKG changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-01-05 11:52:16 --- Comment #12 from MartinKG --- marsshooter has been built successfully on f20, f21 and rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 --- Comment #11 from Fedora Update System --- marsshooter-0.7.5-5.20140507gitc855d04.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/marsshooter-0.7.5-5.20140507gitc855d04.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 MartinKG changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from MartinKG --- @Antonio many thanks for the review. New Package SCM Request === Package Name: marsshooter Short Description: M.A.R.S. - A Ridiculous Shooter Owners: martinkg Branches: f20 f21 rawhide InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 Antonio Trande changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Antonio Trande --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 --- Comment #7 from MartinKG --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/marsshooter.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/marsshooter-0.7.5-4.20140507gitc855d04.fc21.src.rpm %changelog * Fri Jan 02 2015 Martin Gansser - 0.7.5-4.20140507gitc855d04 - added Group tag - package game files and data files separately - fixed desktop file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 --- Comment #6 from Antonio Trande --- This game runs fine but it's difficult if user plays with a keyboard. Probably a joypad is better. Some other fixes. Please, follow as possible Fedora Games Packaging guidelines (https://fedoraproject.org/wiki/SIGs/Games/Packaging). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942
--- Comment #5 from MartinKG ---
new upload:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/marsshooter.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/marsshooter-0.7.5-3.20140507gitc855d04.fc21.src.rpm
%changelog
* Fri Jan 02 2015 Martin Gansser -
0.7.5-3.20140507gitc855d04
- added %%{_datadir}/%{name}/
- removed %%{_datadir}/icons/hicolor owned by hicolor-icon-theme
- added license.txt to %%license
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942
--- Comment #4 from Antonio Trande ---
- %{_datadir}/marsshooter directory is not owned
Just need to change in %{_datadir}/%{name}/
- %{_datadir}/icons/hicolor/512x512/
%{_datadir}/icons/hicolor/512x512/apps/
These directories are owned by hicolor-icon-theme package that
should be included in the RPM chain of system.
- Please, use %license to list license.txt.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"*No copyright* GPL (v3 or later)", "GPL (v3 or later)". Detailed output
of licensecheck in /home/sagitter/marsshooter/licensecheck.txt
[-]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/marsshooter
[x]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor,
/usr/share/marsshooter, /usr/share/icons/hicolor/scalable
[?]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/icons/hicolor/512x512/apps(hicolor-icon-theme),
/usr/share/icons/hicolor/512x512(hicolor-icon-theme)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in marsshooter
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
= SHOULD items =
Generic:
[x]: Avoid bundling fonts in non-fonts packages.
Note: Package
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 --- Comment #3 from MartinKG --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/marsshooter.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/marsshooter-0.7.5-2.20140507gitc855d04.fc21.src.rpm %changelog * Thu Jan 01 2015 Martin Gansser - 0.7.5-2.20140507gitc855d04 - added BR desktop-file-utils -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 Antonio Trande changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 --- Comment #2 from Antonio Trande --- desktop-file-utils is missing among BR packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177942] Review Request: marsshooter - M.A.R.S. - A Ridiculous Shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1177942 Antonio Trande changed: What|Removed |Added CC||anto.tra...@gmail.com --- Comment #1 from Antonio Trande --- Hi Martin. Review swap? https://bugzilla.redhat.com/show_bug.cgi?id=1177926 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
