[Bug 1179342] Review Request: ua-parser-java - Java implementation of user agent parser
https://bugzilla.redhat.com/show_bug.cgi?id=1179342 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ua-parser-java-1.3.0-1.fc21 Resolution|--- |ERRATA Last Closed||2015-01-29 23:38:00 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- ua-parser-java-1.3.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179342] Review Request: ua-parser-java - Java implementation of user agent parser
https://bugzilla.redhat.com/show_bug.cgi?id=1179342 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- ua-parser-java-1.3.0-1.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179342] Review Request: ua-parser-java - Java implementation of user agent parser
https://bugzilla.redhat.com/show_bug.cgi?id=1179342 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- ua-parser-java-1.3.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/ua-parser-java-1.3.0-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179342] Review Request: ua-parser-java - Java implementation of user agent parser
https://bugzilla.redhat.com/show_bug.cgi?id=1179342 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179342] Review Request: ua-parser-java - Java implementation of user agent parser
https://bugzilla.redhat.com/show_bug.cgi?id=1179342 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from gil cattaneo punto...@libero.it --- Thanks for the review! i will solve the rpmlint issue on import New Package SCM Request === Package Name: ua-parser-java Short Description: Java implementation of user agent parser Upstream URL: https://github.com/tobie/ua-parser/ Owners: gil Branches: f21 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179342] Review Request: ua-parser-java - Java implementation of user agent parser
https://bugzilla.redhat.com/show_bug.cgi?id=1179342 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mgold...@redhat.com Assignee|nob...@fedoraproject.org|mgold...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179342] Review Request: ua-parser-java - Java implementation of user agent parser
https://bugzilla.redhat.com/show_bug.cgi?id=1179342
Marek Goldmann mgold...@redhat.com changed:
What|Removed |Added
Blocks|652183 (FE-JAVASIG) |
Flags|fedora-review? |fedora-review+
--- Comment #1 from Marek Goldmann mgold...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), BSD (2 clause), MIT/X11 (BSD like), *No copyright*
MIT/X11 (BSD like), Unknown or generated. 81 files have unknown
license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
Java:
[x]: Bundled jar/class files should be removed before build
Note: Test run failed
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from
[Bug 1179342] Review Request: ua-parser-java - Java implementation of user agent parser
https://bugzilla.redhat.com/show_bug.cgi?id=1179342 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179342] Review Request: ua-parser-java - Java implementation of user agent parser
https://bugzilla.redhat.com/show_bug.cgi?id=1179342 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179342] Review Request: ua-parser-java - Java implementation of user agent parser
https://bugzilla.redhat.com/show_bug.cgi?id=1179342 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179342] Review Request: ua-parser-java - Java implementation of user agent parser
https://bugzilla.redhat.com/show_bug.cgi?id=1179342 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1010003 (bigdata-review) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1010003 [Bug 1010003] bigdata-sig review-tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179342] Review Request: ua-parser-java - Java implementation of user agent parser
https://bugzilla.redhat.com/show_bug.cgi?id=1179342 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1179355 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1179355 [Bug 1179355] Review Request: kite - Kite SDK to simplify the development of data-related systems -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
