[Bug 1185018] Review Request: gap-pkg-sonata - GAP package for systems of nearrings
https://bugzilla.redhat.com/show_bug.cgi?id=1185018 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||gap-pkg-sonata-2.6-4.fc21 Resolution|--- |ERRATA Last Closed||2015-02-09 00:29:01 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- gap-pkg-sonata-2.6-4.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1185018] Review Request: gap-pkg-sonata - GAP package for systems of nearrings
https://bugzilla.redhat.com/show_bug.cgi?id=1185018 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- gap-pkg-sonata-2.6-4.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1185018] Review Request: gap-pkg-sonata - GAP package for systems of nearrings
https://bugzilla.redhat.com/show_bug.cgi?id=1185018 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1185018] Review Request: gap-pkg-sonata - GAP package for systems of nearrings
https://bugzilla.redhat.com/show_bug.cgi?id=1185018 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- gap-pkg-sonata-2.6-4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/gap-pkg-sonata-2.6-4.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1185018] Review Request: gap-pkg-sonata - GAP package for systems of nearrings
https://bugzilla.redhat.com/show_bug.cgi?id=1185018 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1185018] Review Request: gap-pkg-sonata - GAP package for systems of nearrings
https://bugzilla.redhat.com/show_bug.cgi?id=1185018 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1185018] Review Request: gap-pkg-sonata - GAP package for systems of nearrings
https://bugzilla.redhat.com/show_bug.cgi?id=1185018 Jerry James loganje...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Jerry James loganje...@gmail.com --- New Package SCM Request === Package Name: gap-pkg-sonata Short Description: GAP package for systems of nearrings Upstream URL: http://www.algebra.uni-linz.ac.at/Sonata/ Owners: jjames Branches: f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1185018] Review Request: gap-pkg-sonata - GAP package for systems of nearrings
https://bugzilla.redhat.com/show_bug.cgi?id=1185018 --- Comment #2 from Jerry James loganje...@gmail.com --- Thank you very much for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1185018] Review Request: gap-pkg-sonata - GAP package for systems of nearrings
https://bugzilla.redhat.com/show_bug.cgi?id=1185018 Mattias Ellert mattias.ell...@fysast.uu.se changed: What|Removed |Added Status|NEW |ASSIGNED CC||mattias.ell...@fysast.uu.se Assignee|nob...@fedoraproject.org|mattias.ell...@fysast.uu.se Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1185018] Review Request: gap-pkg-sonata - GAP package for systems of nearrings
https://bugzilla.redhat.com/show_bug.cgi?id=1185018
Mattias Ellert mattias.ell...@fysast.uu.se changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Mattias Ellert mattias.ell...@fysast.uu.se ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
No issues - package approved.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later), Unknown or generated. 31 files have unknown
license.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/gap/pkg/sonata/htm/ref
(gap-sonata), /usr/lib/gap/pkg/sonata/htm(gap-sonata),
/usr/lib/gap/pkg/sonata/doc/ref(gap-sonata),
/usr/lib/gap/pkg/sonata/htm/tut(gap-sonata), /usr/lib/gap/pkg/sonata/doc
(gap-sonata), /usr/lib/gap/pkg/sonata(gap-sonata),
/usr/lib/gap/pkg/sonata/doc/tut(gap-sonata), /usr/lib/gap/pkg/sonata/lib
(gap-sonata), /usr/lib/gap/pkg/sonata/nr(gap-sonata),
/usr/lib/gap/pkg/sonata/grp(gap-sonata), /usr/lib/gap/pkg/sonata/tst(gap-
sonata), /usr/lib/gap/pkg/sonata/nri(gap-sonata)
The gap-sonata package is obsoleted by this package - no duplicates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in
