[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libticonv-1.1.4-5.fc21 |libticonv-1.1.4-5.fc20 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- libticonv-1.1.4-5.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libticonv-1.1.4-5.fc21 Resolution|--- |ERRATA Last Closed||2015-04-27 04:38:11 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- libticonv-1.1.4-5.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- libticonv-1.1.4-4.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- libticonv-1.1.4-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/libticonv-1.1.4-4.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- libticonv-1.1.4-4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/libticonv-1.1.4-4.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Bug 1186494 depends on bug 1186499, which changed state. Bug 1186499 Summary: Review Request: tfdocgen - TiLP framework documentation generator https://bugzilla.redhat.com/show_bug.cgi?id=1186499 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 --- Comment #13 from Ben Rosser rosser@gmail.com --- Pushed and built for f22 and rawhide; the f21/f20 builds are waiting on tfdocgen to get pushed out of updates-testing, I think. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Ben Rosser rosser@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Ben Rosser rosser@gmail.com --- New Package SCM Request === Package Name: libticonv Short Description: Texas Instruments calculators charsets library Upstream URL: https://sourceforge.net/projects/tilp/ Owners: tc01 Branches: f20 f21 f22 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 --- Comment #10 from Ben Rosser rosser@gmail.com --- The -doc sub package is a good idea; I remember considering it and I'm not sure why I never did so. I will add one. Thanks for the review(s). :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
CC||mario.blaetterm...@gmail.co
||m
Assignee|anto.tra...@gmail.com |mario.blaetterm...@gmail.co
||m
Flags|fedora-review? |fedora-review+
--- Comment #6 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8938928
$ rpmlint -i -v *
libticonv.src: I: checking
libticonv.src: W: spelling-error Summary(en_US) charsets - char sets,
char-sets, charters
The value of this tag appears to be misspelled. Please double-check.
libticonv.src: W: spelling-error %description -l en_US ticonv - convict
The value of this tag appears to be misspelled. Please double-check.
libticonv.src: I: checking-url https://sourceforge.net/projects/tilp/ (timeout
10 seconds)
libticonv.src: I: checking-url
http://sourceforge.net/projects/tilp/files/tilp2-linux/tilp2-1.17/libticonv-1.1.4.tar.bz2
(timeout 10 seconds)
libticonv.i686: I: checking
libticonv.i686: W: spelling-error %description -l en_US ticonv - convict
The value of this tag appears to be misspelled. Please double-check.
libticonv.i686: I: checking-url https://sourceforge.net/projects/tilp/ (timeout
10 seconds)
libticonv.x86_64: I: checking
libticonv.x86_64: W: spelling-error %description -l en_US ticonv - convict
The value of this tag appears to be misspelled. Please double-check.
libticonv.x86_64: I: checking-url https://sourceforge.net/projects/tilp/
(timeout 10 seconds)
libticonv-debuginfo.i686: I: checking
libticonv-debuginfo.i686: I: checking-url
https://sourceforge.net/projects/tilp/ (timeout 10 seconds)
libticonv-debuginfo.x86_64: I: checking
libticonv-debuginfo.x86_64: I: checking-url
https://sourceforge.net/projects/tilp/ (timeout 10 seconds)
libticonv-devel.i686: I: checking
libticonv-devel.i686: I: checking-url https://sourceforge.net/projects/tilp/
(timeout 10 seconds)
libticonv-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
libticonv-devel.x86_64: I: checking
libticonv-devel.x86_64: I: checking-url https://sourceforge.net/projects/tilp/
(timeout 10 seconds)
libticonv-devel.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
libticonv-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
libticonv.spec: I: checking
libticonv.spec: I: checking-url
http://sourceforge.net/projects/tilp/files/tilp2-linux/tilp2-1.17/libticonv-1.1.4.tar.bz2
(timeout 10 seconds)
7 packages and 1 specfiles checked; 0 errors, 7 warnings.
Nothing worth to discuss.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %license.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
1faecc71311bd95c94792cc72dd0844e7881a65156b006f045bb417eddd45183
libticonv-1.1.4.tar.bz2
1faecc71311bd95c94792cc72dd0844e7881a65156b006f045bb417eddd45183
libticonv-1.1.4.tar.bz2.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 --- Comment #7 from Antonio Trande anto.tra...@gmail.com --- (In reply to Ben Rosser from comment #5) tfdocgen has been approved and built for F20, F21, and Rawhide. I've updated the spec file with the %license tag for this package: Spec File: https://tc01.fedorapeople.org/tilp2/libticonv.spec SRPM URL: https://tc01.fedorapeople.org/tilp2/libticonv-1.1.4-2.fc21.src.rpm I was waiting given that tfdocgen was still not packaged in rawhide. I see that i have been excluded from this review within few hours without a rational reason... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Antonio Trande anto.tra...@gmail.com --- (In reply to Mario Blättermann from comment #8) Sorry for skipping you, I set the latest changes back. I confirm your review; maybe it could be more useful putting all HTML documentation in a -doc sub package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Assignee|mario.blaetterm...@gmail.co |anto.tra...@gmail.com |m | Flags|fedora-review+ |fedora-review? --- Comment #8 from Mario Blättermann mario.blaetterm...@gmail.com --- Sorry for skipping you, I set the latest changes back. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 --- Comment #5 from Ben Rosser rosser@gmail.com --- tfdocgen has been approved and built for F20, F21, and Rawhide. I've updated the spec file with the %license tag for this package: Spec File: https://tc01.fedorapeople.org/tilp2/libticonv.spec SRPM URL: https://tc01.fedorapeople.org/tilp2/libticonv-1.1.4-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Blocks||1186497 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1186497 [Bug 1186497] Review Request: libtifiles2 - Texas Instruments calculator files library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Blocks||1186557 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1186557 [Bug 1186557] Review Request: libticalcs2 - Texas Instruments calculator communication library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Blocks|1186557 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1186557 [Bug 1186557] Review Request: libticalcs2 - Texas Instruments calculator communication library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Depends On||1186499 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1186499 [Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 --- Comment #2 from Ben Rosser rosser@gmail.com --- Fixed, thanks! See here for latest now: Spec URL: https://tc01.fedorapeople.org/tilp2/libticonv.spec SRPM URL: https://tc01.fedorapeople.org/tilp2/libticonv-1.1.4-1.fc21.src.rpm I will fix the same issues in the other libti*/tilp packages later this evening. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 --- Comment #3 from Antonio Trande anto.tra...@gmail.com --- BuildRequires: glib2-devel, pkgconfig, tfdocgen tfdocgen is a missing package in Fedora. Where does it come from? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494 --- Comment #4 from Ben Rosser rosser@gmail.com --- Sorry, I probably should have linked that one here... tfdocgen is a tool for generating the documentation in tilp2 and its libraries. I have another review request opened here: https://bugzilla.redhat.com/show_bug.cgi?id=1186499 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library
https://bugzilla.redhat.com/show_bug.cgi?id=1186494
--- Comment #1 from Antonio Trande anto.tra...@gmail.com ---
Hi Ben.
- Release: 0%{?dist}
First release number is 1, not 0.
- About wrong-file-end-of-line-encoding warnings, see
https://fedoraproject.org/wiki/Common_Rpmlint_issues?rd=PackageMaintainers/Common_Rpmlint_Issues#wrong-file-end-of-line-encoding
- Update latest Changelog change to today.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
