[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|tfdocgen-20150202git-2.fc20 |tfdocgen-20150202git-2.fc21 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- tfdocgen-20150202git-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||tfdocgen-20150202git-2.fc20 Resolution|--- |ERRATA Last Closed||2015-02-25 08:26:29 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- tfdocgen-20150202git-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 Kevin Kofler ke...@tigcc.ticalc.org changed: What|Removed |Added CC||ke...@tigcc.ticalc.org --- Comment #15 from Kevin Kofler ke...@tigcc.ticalc.org --- Sigh, so there we are, somebody's packaging Lionel Debroux's forks and stepping on the work done in the CalcForge repository. No thanks for that! I'm bumping the Epoch of tfdocgen in the CalcForge repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 --- Comment #16 from Kevin Kofler ke...@tigcc.ticalc.org --- TiLP software seem stalled since 03/2013. Are you sure that their development is still active? The projects basically got killed by the former lead maintainer, Romain Liévin, on his leaving, arbitrarily appointing Lionel Debroux as his successor, ignoring his existing codevelopers (Tyler Cassidy and me), and Lionel Debroux subsequently appropriating the project names and demanding that the existing developers rename their code. My renames got stuck halfway because it is very time-consuming and unrewarding to spend your time fixing hundreds of references to the old names (also because Romain named everything with tilp_*, put TiLP and LPG references all over user-visible strings, etc.). That also stalled getting the REAL projects into Fedora, as opposed to the forks that are now being packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- tfdocgen-20150202git-2.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- tfdocgen-20150202git-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/tfdocgen-20150202git-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- tfdocgen-20150202git-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/tfdocgen-20150202git-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). FYI, there is no 'c' in any of the branch names, and rawhide is automatic. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 --- Comment #8 from Ben Rosser rosser@gmail.com --- New Package SCM Request === Package Name: tfdocgen Short Description: TiLP framework documentation generator Upstream URL: https://sourceforge.net/projects/tilp/ Owners: tc01 Branches: fc20 fc21 fc22 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 Ben Rosser rosser@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 --- Comment #6 from Ben Rosser rosser@gmail.com --- Fixed these; here are updated spec / srpm. Spec URL: https://tc01.fedorapeople.org/tilp2/tfdocgen.spec SRPM URL: https://tc01.fedorapeople.org/tilp2/tfdocgen-20150202git-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #7 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8876026
$ rpmlint -i -v *
tfdocgen.src: I: checking
tfdocgen.src: W: spelling-error %description -l en_US libti - lib ti, lib-ti,
libation
The value of this tag appears to be misspelled. Please double-check.
tfdocgen.src: I: checking-url https://sourceforge.net/projects/tilp/ (timeout
10 seconds)
tfdocgen.src: W: invalid-url Source0: tfdocgen-20150202git.tar.bz2
The value should be a valid, public HTTP, HTTPS, or FTP URL.
tfdocgen.x86_64: I: checking
tfdocgen.x86_64: W: spelling-error %description -l en_US libti - lib ti,
lib-ti, libation
The value of this tag appears to be misspelled. Please double-check.
tfdocgen.x86_64: I: checking-url https://sourceforge.net/projects/tilp/
(timeout 10 seconds)
tfdocgen-debuginfo.x86_64: I: checking
tfdocgen-debuginfo.x86_64: I: checking-url
https://sourceforge.net/projects/tilp/ (timeout 10 seconds)
tfdocgen.spec: I: checking
tfdocgen.spec: W: invalid-url Source0: tfdocgen-20150202git.tar.bz2
The value should be a valid, public HTTP, HTTPS, or FTP URL.
3 packages and 1 specfiles checked; 0 errors, 4 warnings.
Nothing worth to discuss.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %license.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
Checksums differ, this is due to the nature of locally created tarballs.
Doesn't matter, I trust you to don't have changed the sources.
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Alias||tfdocgen
Flags||fedora-review?
--- Comment #4 from Mario Blättermann mario.blaetterm...@gmail.com ---
%{_mandir}/man1/tfdocgen.1.gz
Please use no certain ending for the compression algorithm. Use a wildcard
instead, then it is future-proof (default compression can change in the
future):
%{_mandir}/man1/tfdocgen.1.*
License files go into %license according to the latest guidelines:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 --- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com --- BTW, ChangeLog is still missing from %doc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Blocks||1186494 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1186494 [Bug 1186494] Review Request: libticonv - Texas Instruments calculators charsets library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added CC||anto.tra...@gmail.com --- Comment #2 from Antonio Trande anto.tra...@gmail.com --- TiLP software seem stalled since 03/2013. Are you sure that their development is still active? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 --- Comment #3 from Ben Rosser rosser@gmail.com --- There is still some development going on, yes, see here: http://www.cemetech.net/forum/viewtopic.php?t=4139postdays=0postorder=ascstart=100 This tool hasn't been modified in a long time, though, I do know that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186499] Review Request: tfdocgen - TiLP framework documentation generator
https://bugzilla.redhat.com/show_bug.cgi?id=1186499 --- Comment #1 from Ben Rosser rosser@gmail.com --- Updated to change release from 0 to 1 and to change snapshot date to today: Spec URL: https://tc01.fedorapeople.org/tilp2/tfdocgen.spec SRPM URL: https://tc01.fedorapeople.org/tilp2/tfdocgen-20150202git-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
