[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #34 from Jonny Heggheim --- It would be great if someone could test https://bodhi.fedoraproject.org/updates/FEDORA-2018-4978426286 This is a urgent security update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Jonny Heggheim changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2016-11-20 15:00:44 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #33 from Jonny Heggheim --- (In reply to Samuel Gyger from comment #32) > Thank you for taking over and making this happen so fast. Appreciate this. You're welcome! It would be great if more users could test the build on Fedora 25: > sudo dnf install electrum --enablerepo=updates-testing And provided feedback on bodhi: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e5dbc775ab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #32 from Samuel Gyger --- @Jonny Heggheim: Thank you for taking over and making this happen so fast. Appreciate this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #31 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/electrum -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #30 from Jonny Heggheim --- Have not heard anything from upstream, I updated the license to MIT and BSD. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #29 from Jonny Heggheim --- (In reply to gil cattaneo from comment #28) > Approved, maybe we could wait the upstream reply @ Thanks, I will wait for reply from upstream -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 gil cattaneo changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #28 from gil cattaneo --- (In reply to Jonny Heggheim from comment #27) > (In reply to gil cattaneo from comment #26) > > Please, ask to upstream to confirm the licensing of code and/or content/s, > > and to add license headers Approved, maybe we could wait the upstream reply @ > https://github.com/spesmilo/electrum/issues/2041 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #27 from Jonny Heggheim --- (In reply to gil cattaneo from comment #26) > Please, ask to upstream to confirm the licensing of code and/or content/s, > and to add license headers https://github.com/spesmilo/electrum/issues/2041 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Bug 1187084 depends on bug 1279104, which changed state. Bug 1279104 Summary: Review Request: python-pbkdf2 - password-based key derivation in pure Python https://bugzilla.redhat.com/show_bug.cgi?id=1279104 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Bug 1187084 depends on bug 1187082, which changed state. Bug 1187082 Summary: Review Request: python-slowaes - An Implementation of AES in python https://bugzilla.redhat.com/show_bug.cgi?id=1187082 What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #26 from gil cattaneo --- Issues: [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (2 clause)", "*No copyright* MIT/X11 (BSD like)", "Unknown or generated". 107 files have unknown license. Detailed output of licensecheck in /home/gil/1187084-electrum/licensecheck.txt BSD (2 clause) -- Electrum-2.7.12/lib/socks.py The following source files are without license headers. Unknown or generated Electrum-2.7.12/gui/kivy/i18n.py Electrum-2.7.12/gui/kivy/main_window.py Electrum-2.7.12/gui/kivy/nfc_scanner/scanner_android.py Electrum-2.7.12/gui/kivy/nfc_scanner/scanner_dummy.py Electrum-2.7.12/gui/kivy/uix/combobox.py Electrum-2.7.12/gui/kivy/uix/context_menu.py Electrum-2.7.12/gui/kivy/uix/dialogs/amount_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/bump_fee_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/checkbox_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/choice_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/fee_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/fx_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/installwizard.py Electrum-2.7.12/gui/kivy/uix/dialogs/label_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/nfc_transaction.py Electrum-2.7.12/gui/kivy/uix/dialogs/password_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/qr_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/qr_scanner.py Electrum-2.7.12/gui/kivy/uix/dialogs/question.py Electrum-2.7.12/gui/kivy/uix/dialogs/seed_options.py Electrum-2.7.12/gui/kivy/uix/dialogs/settings.py Electrum-2.7.12/gui/kivy/uix/dialogs/tx_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/wallets.py Electrum-2.7.12/gui/kivy/uix/drawer.py Electrum-2.7.12/gui/kivy/uix/gridview.py Electrum-2.7.12/gui/kivy/uix/menus.py Electrum-2.7.12/gui/kivy/uix/qrcodewidget.py Electrum-2.7.12/gui/kivy/uix/screens.py Electrum-2.7.12/gui/qt/amountedit.py Electrum-2.7.12/gui/qt/console.py Electrum-2.7.12/gui/qt/icons_rc.py Electrum-2.7.12/gui/qt/installwizard.py Electrum-2.7.12/gui/qt/qrcodewidget.py Electrum-2.7.12/gui/qt/qrtextedit.py Electrum-2.7.12/gui/qt/util.py Electrum-2.7.12/gui/stdio.py Electrum-2.7.12/gui/text.py Electrum-2.7.12/lib/msqr.py Electrum-2.7.12/lib/paymentrequest_pb2.py Electrum-2.7.12/lib/simple_config.py Electrum-2.7.12/lib/tests/test_account.py Electrum-2.7.12/lib/tests/test_bitcoin.py Electrum-2.7.12/lib/tests/test_interface.py Electrum-2.7.12/lib/tests/test_mnemonic.py Electrum-2.7.12/lib/tests/test_simple_config.py Electrum-2.7.12/lib/tests/test_transaction.py Electrum-2.7.12/lib/tests/test_util.py Electrum-2.7.12/lib/tests/test_wallet.py Electrum-2.7.12/lib/version.py Electrum-2.7.12/plugins/audio_modem/qt.py Electrum-2.7.12/plugins/exchange_rate/exchange_rate.py Electrum-2.7.12/plugins/exchange_rate/kivy.py Electrum-2.7.12/plugins/exchange_rate/qt.py Electrum-2.7.12/plugins/keepkey/client.py Electrum-2.7.12/plugins/keepkey/cmdline.py Electrum-2.7.12/plugins/keepkey/keepkey.py Electrum-2.7.12/plugins/keepkey/qt.py Electrum-2.7.12/plugins/labels/kivy.py Electrum-2.7.12/plugins/labels/labels.py Electrum-2.7.12/plugins/labels/qt.py Electrum-2.7.12/plugins/ledger/cmdline.py Electrum-2.7.12/plugins/ledger/ledger.py Electrum-2.7.12/plugins/ledger/qt.py Electrum-2.7.12/plugins/plot/qt.py Electrum-2.7.12/plugins/trezor/client.py Electrum-2.7.12/plugins/trezor/clientbase.py Electrum-2.7.12/plugins/trezor/cmdline.py Electrum-2.7.12/plugins/trezor/plugin.py Electrum-2.7.12/plugins/trezor/qt.py Electrum-2.7.12/plugins/trezor/qt_generic.py Electrum-2.7.12/plugins/trezor/trezor.py Electrum-2.7.12/plugins/trustedcoin/cmdline.py Electrum-2.7.12/plugins/virtualkeyboard/qt.py Electrum-2.7.12/scripts/bip70 Electrum-2.7.12/scripts/block_headers Electrum-2.7.12/scripts/estimate_fee Electrum-2.7.12/scripts/get_chunk Electrum-2.7.12/scripts/get_donation_address Electrum-2.7.12/scripts/get_history Electrum-2.7.12/scripts/peers Electrum-2.7.12/scripts/servers Electrum-2.7.12/scripts/txradar Electrum-2.7.12/scripts/util.py Electrum-2.7.12/scripts/watch_address Electrum-2.7.12/setup-release.py Please, ask to upstream to confirm the licensing of code and/or content/s, and to add license headers https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification Non blocking issues: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #25 from gil cattaneo --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (2 clause)", "*No copyright* MIT/X11 (BSD like)", "Unknown or generated". 107 files have unknown license. Detailed output of licensecheck in /home/gil/1187084-electrum/licensecheck.txt BSD (2 clause) -- Electrum-2.7.12/lib/socks.py Unknown or generated Electrum-2.7.12/gui/kivy/i18n.py Electrum-2.7.12/gui/kivy/main_window.py Electrum-2.7.12/gui/kivy/nfc_scanner/scanner_android.py Electrum-2.7.12/gui/kivy/nfc_scanner/scanner_dummy.py Electrum-2.7.12/gui/kivy/uix/combobox.py Electrum-2.7.12/gui/kivy/uix/context_menu.py Electrum-2.7.12/gui/kivy/uix/dialogs/amount_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/bump_fee_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/checkbox_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/choice_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/fee_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/fx_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/installwizard.py Electrum-2.7.12/gui/kivy/uix/dialogs/label_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/nfc_transaction.py Electrum-2.7.12/gui/kivy/uix/dialogs/password_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/qr_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/qr_scanner.py Electrum-2.7.12/gui/kivy/uix/dialogs/question.py Electrum-2.7.12/gui/kivy/uix/dialogs/seed_options.py Electrum-2.7.12/gui/kivy/uix/dialogs/settings.py Electrum-2.7.12/gui/kivy/uix/dialogs/tx_dialog.py Electrum-2.7.12/gui/kivy/uix/dialogs/wallets.py Electrum-2.7.12/gui/kivy/uix/drawer.py Electrum-2.7.12/gui/kivy/uix/gridview.py Electrum-2.7.12/gui/kivy/uix/menus.py Electrum-2.7.12/gui/kivy/uix/qrcodewidget.py Electrum-2.7.12/gui/kivy/uix/screens.py Electrum-2.7.12/gui/qt/amountedit.py Electrum-2.7.12/gui/qt/console.py Electrum-2.7.12/gui/qt/icons_rc.py Electrum-2.7.12/gui/qt/installwizard.py Electrum-2.7.12/gui/qt/qrcodewidget.py Electrum-2.7.12/gui/qt/qrtextedit.py Electrum-2.7.12/gui/qt/util.py Electrum-2.7.12/gui/stdio.py Electrum-2.7.12/gui/text.py Electrum-2.7.12/lib/msqr.py Electrum-2.7.12/lib/paymentrequest_pb2.py Electrum-2.7.12/lib/simple_config.py Electrum-2.7.12/lib/tests/test_account.py Electrum-2.7.12/lib/tests/test_bitcoin.py Electrum-2.7.12/lib/tests/test_interface.py Electrum-2.7.12/lib/tests/test_mnemonic.py Electrum-2.7.12/lib/tests/test_simple_config.py Electrum-2.7.12/lib/tests/test_transaction.py Electrum-2.7.12/lib/tests/test_util.py Electrum-2.7.12/lib/tests/test_wallet.py Electrum-2.7.12/lib/version.py Electrum-2.7.12/plugins/audio_modem/qt.py Electrum-2.7.12/plugins/exchange_rate/exchange_rate.py Electrum-2.7.12/plugins/exchange_rate/kivy.py Electrum-2.7.12/plugins/exchange_rate/qt.py Electrum-2.7.12/plugins/keepkey/client.py Electrum-2.7.12/plugins/keepkey/cmdline.py Electrum-2.7.12/plugins/keepkey/keepkey.py Electrum-2.7.12/plugins/keepkey/qt.py Electrum-2.7.12/plugins/labels/kivy.py Electrum-2.7.12/plugins/labels/labels.py Electrum-2.7.12/plugins/labels/qt.py Electrum-2.7.12/plugins/ledger/cmdline.py Electrum-2.7.12/plugins/ledger/ledger.py Electrum-2.7.12/plugins/ledger/qt.py Electrum-2.7.12/plugins/plot/qt.py Electrum-2.7.12/plugins/trezor/client.py Electrum-2.7.12/plugins/trezor/clientbase.py Electrum-2.7.12/plugins/trezor/cmdline.py Electrum-2.7.12/plugins/trezor/plugin.py Electrum-2.7.12/plugins/trezor/qt.py Electrum-2.7.12/plugins/trezor/qt_generic.py Electrum-2.7.12/plugins/trezor/trezor.py Electrum-2.7.12/plugins/trustedcoin/cmdline.py Electrum-2.7.12/plugins/virtualkeyboard/qt.py Electrum-2.7.12/scripts/bip70 Electrum-2.7.12/scripts/block_headers Electrum-2.7.12/scripts/estimate_fee Electrum-2.7.12/scripts/get_chunk Electrum-2.7.12/scripts/get_donation_address Electrum-2.7.12/scripts/get_history Electrum-2.7.12/scripts/peers Electrum-2.7.12/scripts/servers Electrum-2.7.12/scripts/txradar Electrum-2.7.12/scripts/util.py Electrum-2.7.12/scripts/watch_address Electrum-2.7.12/setup-release.py [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/hy_AM, /usr/share/locale/eo_UY, /usr/share/locale/ky_KG/LC_MESSAGES, /usr/share/locale/ar_SA/LC_MESSAGES, /usr/share/locale/eo_UY/LC_MESSAGES, /usr/share/locale/ar_SA, /usr/share/locale/ky_KG, /usr/share/locale/hy_AM/LC_MESSAGES [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/locale/eo_UY/LC_MESSAGES, /
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 gil cattaneo changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #24 from Jonny Heggheim --- Updated SPEC file. Spec URL: https://jonny.fedorapeople.org/electrum/electrum.spec SRPM URL: https://jonny.fedorapeople.org/electrum/electrum-2.7.12-2.fc25.src.rpm Description: A lightweight bitcoin client that uses external servers to do the heavy lifting of the bitcoin protocol. Fedora Account System Username: jonny Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16440972 Changelog * Sun Nov 13 2016 Jonny Heggheim - 2.7.12-2 - Added weak dependency on zbar-pygtk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #23 from Jonny Heggheim --- (In reply to gil cattaneo from comment #22) > (In reply to gil cattaneo from comment #21) > > I will review when python-pbkdf2 will be available in rawhide > Seem unavailable also python-slowaes Great, both have been requested in the package database, I will let you know when they are in rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #22 from gil cattaneo --- (In reply to gil cattaneo from comment #21) > I will review when python-pbkdf2 will be available in rawhide Seem unavailable also python-slowaes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 gil cattaneo changed: What|Removed |Added Flags||fedora-review? --- Comment #21 from gil cattaneo --- I will review when python-pbkdf2 will be available in rawhide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Jonny Heggheim changed: What|Removed |Added Assignee|nob...@fedoraproject.org|punto...@libero.it -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #20 from Jonny Heggheim --- (In reply to Samuel Gyger from comment #19) > If this is how it should be, than I think working with upstream is the way > to go. The author is very responsive, at least in my experience. I just sent him an email and asked if we could find a solution. Btw, Debian stores the locales in /usr/lib/python2.7/dist-packages/electrum/locale for their Electrum package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #19 from Samuel Gyger --- If this is how it should be, than I think working with upstream is the way to go. The author is very responsive, at least in my experience. I don't know how locales for python packages are handled. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084
--- Comment #18 from Jonny Heggheim ---
Not sure how to package the locale files, now their are in:
/usr/lib/python2.7/site-packages/electrum/locale, but I assume the best place
would be /usr/share/locale/.
This would require changes to Electrum:
Electrum-2.7.12/lib/i18n.py:
> import gettext, os
>
> LOCALE_DIR = os.path.join(os.path.dirname(__file__), 'locale')
> language = gettext.translation('electrum', LOCALE_DIR, fallback = True)
Do you think it is worth the effort to patch this file and install the
translations in /usr/share/locale/? Or should we work with upstream to have a
better solution?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Jonny Heggheim changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #17 from Jonny Heggheim --- New version based on the work of Samuel Gyger: Spec URL: https://jonny.fedorapeople.org/electrum/electrum.spec SRPM URL: https://jonny.fedorapeople.org/electrum/electrum-2.7.12-1.fc25.src.rpm Description: A lightweight bitcoin client that uses external servers to do the heavy lifting of the bitcoin protocol. Fedora Account System Username: jonny Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16378467 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #16 from Jonny Heggheim --- (In reply to Samuel Gyger from comment #15) > Feel free, you can take my work, Public Domain, no limits from me. Thanks > for stepping up to the task. > > Cheers Great! Thanks for your work, my SPEC files are based on your contributions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #15 from Samuel Gyger --- Feel free, you can take my work, Public Domain, no limits from me. Thanks for stepping up to the task. Cheers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Jonny Heggheim changed: What|Removed |Added CC||jonnyheggh...@sigaint.org --- Comment #14 from Jonny Heggheim --- What is the status of this package? Do you mind I take over and become the maintainer? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #13 from Samuel Gyger --- And the last package for this new effort to get electrum into fedora. Sorry for the delay as I was stuck on fedora 21 for quite a while, but a new computer, enough power for virtualization got me running on packaging this stuff again. Here the updated files with your inputs included. Spec URL: http://people.ee.ethz.ch/~gygers/rpms/electrum.spec SRPM URL: http://people.ee.ethz.ch/~gygers/rpms/electrum-2.6.4-2.fc23.src.rpm Description: A lightweight bitcoin client that uses external servers to do the heavy lifting of the bitcoin protocol. Fedora Account System Username:gyger I need a sponsor too. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=13815905 (F23) And also my copr repository runs the newest files now. https://copr.fedorainfracloud.org/coprs/gyger/electrum -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Bug 1187084 depends on bug 1279104, which changed state. Bug 1279104 Summary: Review Request: python-pbkdf2 - password-based key derivation in pure Python https://bugzilla.redhat.com/show_bug.cgi?id=1279104 What|Removed |Added Status|CLOSED |NEW Resolution|NOTABUG |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Bug 1187084 depends on bug 1279104, which changed state. Bug 1279104 Summary: Review Request: python-pbkdf2 - password-based key derivation in pure Python https://bugzilla.redhat.com/show_bug.cgi?id=1279104 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Samuel Gyger changed: What|Removed |Added Depends On||1279104 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1279104 [Bug 1279104] Review Request: python-pbkdf2 - password-based key derivation in pure Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #12 from Samuel Gyger --- I need a sponsor. So I updated the SPEC file and also create a SRPM file, hosted under the following links. SPEC: http://people.ee.ethz.ch/~gygers/rpms/electrum.spec SRPMS: http://people.ee.ethz.ch/~gygers/rpms/electrum-2.5.2-1.fc21.src.rpm Koji Builds are here: http://koji.fedoraproject.org/koji/taskinfo?taskID=11745928 (F21) http://koji.fedoraproject.org/koji/taskinfo?taskID=11745974 (F22) The copr repository is also updated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #11 from Upstream Release Monitoring --- gyger's scratch build of electrum-2.5.2-1.fc21.src.rpm for f21 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11745928 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #10 from Piotr Popieluch --- Nice, Do you still need a sponsor? I can review this package but cant's sponsor you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Samuel Gyger changed: What|Removed |Added Flags|needinfo?(gy...@fsfe.org) | --- Comment #9 from Samuel Gyger --- Yes, definitely, but there was no response for a long time, so I didn't invest more time. If there is a chance to get it into Fedora now, I'll package the new versions and update the SPEC files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Piotr Popieluch changed: What|Removed |Added CC||gy...@fsfe.org, ||piotr1...@gmail.com Flags||needinfo?(gy...@fsfe.org) --- Comment #8 from Piotr Popieluch --- Any progress on this? Samuel are you still interested in packaging/maintaining this? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Carl van Tonder changed: What|Removed |Added CC||c...@supervacuo.com --- Comment #7 from Carl van Tonder --- Uploaded electrum-2.5.1-1.fc23.src.rpm to COPR if that's of help to anyone: https://copr.fedoraproject.org/coprs/seeitcoming/electrum/ i.e. Samuel's .spec file seems to work fine for later versions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Tom "spot" Callaway changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235 (FE-Legal) | --- Comment #6 from Tom "spot" Callaway --- There should no longer be any legal issue with FOSS bitcoin implementations. Lifting FE-Legal. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #5 from Samuel Gyger --- Any update on that? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Christopher Meng changed: What|Removed |Added CC||i...@cicku.me Blocks||182235 (FE-Legal) --- Comment #4 from Christopher Meng --- I'm afraid Fedora doesn't accept it, asking legal. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 --- Comment #3 from Samuel Gyger --- Sorry, forgot one RPM_BUILDROOT variable, here an updated build, everything else same as before. Spec URL: http://people.ee.ethz.ch/~gygers/rpms/electrum.spec SRPM URL: http://people.ee.ethz.ch/~gygers/rpms/electrum-1.9.8-3.fc21.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8860814 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084
--- Comment #2 from Samuel Gyger ---
New Files are uploaded:
Spec URL: http://people.ee.ethz.ch/~gygers/rpms/electrum.spec
SRPM URL: http://people.ee.ethz.ch/~gygers/rpms/electrum-1.9.8-2.fc21.src.rpm
Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8860395
Copr Repository: https://copr.fedoraproject.org/coprs/gyger/electrum/
Fixed Bugs: all but the following.
- Package owns all the folders from the languages. Not sure what to do there.
Added gettext as a builddependency, but it's not realy used as .mo files are
released in the package and not build. What is the solution there?
- License: I remove the distributed third party libraries from the source
folder in the %prep section. A lot of files have no license header, but they
are all set to be GPLv3 by the author of the files.
- Egg-info not specifically listed as it says here
(https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Egg_Metadata_Using_Setuptools),
that the %{python2_sitelib}/* captures also .egg-info
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084
Pranav Kant changed:
What|Removed |Added
CC||pranav...@gmail.com
--- Comment #1 from Pranav Kant ---
This is an unofficial review only.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package contains BR: python2-devel or python3-devel
Your package contains only python-devel. If you need both python2, python3,
you need to add both of these as separate BRs, otherwise only add one of
these.
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Please don't use a mixture of macro style and variable style. Keep it
consistent throughout the spec file.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
Your package includes electrum.desktop file but doesn't use
desktop-file-install to install this desktop file. Also add a BR:
desktop-file-utils for this.
See:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
- update-desktop-database is invoked in %post and %postun if package contains
desktop file(s) with a MimeType: entry.
Since, this package involves a desktop file, you probably need to add these
sections.
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
database
- Use %license and move LICENSE file from %doc to %license.
See :
http://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image
- You need to change %{__python} macro to specifically %{__python2} or 3 in
your
spec file. Unversioned python macros are deprecated.
- Use versioned python_sitelib in %files instead of unversioned
%{__python_sitelib}
- Your package doesn't include the *.egg-info in %files.
- Binary eggs must be removed in %prep probably.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Licenses found:
"Apache (v2.0)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11
(BSD like)", "BSD (2 clause)", "*No copyright* MIT/X11 (BSD like)". 44
files have unknown license.
Please make sure that you mention all of these licenses in License field
in
spec file or put an *effective* license in that field.
[?]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/locale/ar_SA/LC_MESSAGES,
/usr/share/locale/eo_UY/LC_MESSAGES, /usr/share/locale/ky_KG,
/usr/share/locale/eo_UY, /usr/share/locale/ky_KG/LC_MESSAGES,
/usr/share/locale/ar_SA
[?]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/locale/eo_UY/LC_MESSAGES, /usr/share/locale/eo_UY,
/usr/share/locale/ar_SA, /usr/share/locale/ky_KG,
/usr/share/locale/ky_KG/LC_MESSAGES, /usr/share/locale/ar_SA/LC_MESSAGES
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[!]: Package consistently uses macros (instead of hard-coded directory names).
You use macros at most of the places but there is still some scope. You
can
use %{name} when installing binaries and other files in %{datadir}.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
This doesn't have large documentation.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or direct
[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client
https://bugzilla.redhat.com/show_bug.cgi?id=1187084 Samuel Gyger changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Depends On||1187082 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=1187082 [Bug 1187082] Review Request: python-slowaes - An Implementation of AES in python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
