[Bug 1187944] Review Request: nodejs-tern-cordovajs - A Tern plugin adding support for CordovaJS
https://bugzilla.redhat.com/show_bug.cgi?id=1187944 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187944] Review Request: nodejs-tern-cordovajs - A Tern plugin adding support for CordovaJS
https://bugzilla.redhat.com/show_bug.cgi?id=1187944 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2015-02-28 12:29:43 --- Comment #8 from Gerard Ryan ger...@ryan.lt --- Built for Rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=616181 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187944] Review Request: nodejs-tern-cordovajs - A Tern plugin adding support for CordovaJS
https://bugzilla.redhat.com/show_bug.cgi?id=1187944 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187944] Review Request: nodejs-tern-cordovajs - A Tern plugin adding support for CordovaJS
https://bugzilla.redhat.com/show_bug.cgi?id=1187944
Piotr Popieluch piotr1...@gmail.com changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #5 from Piotr Popieluch piotr1...@gmail.com ---
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1187944-nodejs-tern-
cordovajs/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on
[Bug 1187944] Review Request: nodejs-tern-cordovajs - A Tern plugin adding support for CordovaJS
https://bugzilla.redhat.com/show_bug.cgi?id=1187944 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Status|NEW |MODIFIED Flags||fedora-cvs? --- Comment #6 from Gerard Ryan ger...@ryan.lt --- New Package SCM Request === Package Name: nodejs-tern-cordovajs Short Description: A Tern plugin adding support for CordovaJS Owners: galileo Branches: f22, f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187944] Review Request: nodejs-tern-cordovajs - A Tern plugin adding support for CordovaJS
https://bugzilla.redhat.com/show_bug.cgi?id=1187944 --- Comment #4 from Gerard Ryan ger...@ryan.lt --- Spec URL: https://galileo.fedorapeople.org/nodejs-tern-cordovajs-0.1.0/nodejs-tern-cordovajs.spec SRPM URL: https://galileo.fedorapeople.org/nodejs-tern-cordovajs-0.1.0/nodejs-tern-cordovajs-0.1.0-2.fc23.src.rpm (In reply to Piotr Popieluch from comment #3) I've got some review-requests open, see: http://tinyurl.com/jvlsyvj Thanks, I'll do one now, and should have time to do some more at the weekend! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187944] Review Request: nodejs-tern-cordovajs - A Tern plugin adding support for CordovaJS
https://bugzilla.redhat.com/show_bug.cgi?id=1187944 --- Comment #3 from Piotr Popieluch piotr1...@gmail.com --- No problems, happy to do some more reviews soon. I've got some review-requests open, see: http://tinyurl.com/jvlsyvj I'm most interested to get carbon-c-relay approved, but that one might have some more work to do than one of the nodejs-modules. Pick a request you like ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187944] Review Request: nodejs-tern-cordovajs - A Tern plugin adding support for CordovaJS
https://bugzilla.redhat.com/show_bug.cgi?id=1187944 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added CC||piotr1...@gmail.com --- Comment #1 from Piotr Popieluch piotr1...@gmail.com --- Installing this fails on Rawhide: Error: nothing provides npm(acorn) 0.6 needed by nodejs-tern-cordovajs-0.1.0-1.fc23.noarch nodejs-acorn 0.9.0 is in Rawhide, you might try a %nodejs_fixdep if acorn 0.9.0 is backwards compatible with 0.6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187944] Review Request: nodejs-tern-cordovajs - A Tern plugin adding support for CordovaJS
https://bugzilla.redhat.com/show_bug.cgi?id=1187944 --- Comment #2 from Gerard Ryan ger...@ryan.lt --- Hi Piotr, Thanks for the reviews this evening! Do you have any open reviews on which I could return the favor? I'll have a look at this one tomorrow and hopefully push a working version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1187944] Review Request: nodejs-tern-cordovajs - A Tern plugin adding support for CordovaJS
https://bugzilla.redhat.com/show_bug.cgi?id=1187944 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
