[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-requests-toolbelt-0. |python-requests-toolbelt-0. |3.1-2.fc20 |3.1-2.el7 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-requests-toolbelt-0.3.1-2.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-requests-toolbelt-0. |python-requests-toolbelt-0. |3.1-2.fc21 |3.1-2.fc20 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-requests-toolbelt-0.3.1-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||python-requests-toolbelt-0. ||3.1-2.fc21 Resolution|NEXTRELEASE |ERRATA --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-requests-toolbelt-0.3.1-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178
Florian der-flo Lehner d...@der-flo.net changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Florian der-flo Lehner d...@der-flo.net ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 22 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3
-requests-toolbelt
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
--- http://koji.fedoraproject.org/koji/taskinfo?taskID=8921004
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 Parag pnem...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Parag pnem...@redhat.com --- Thanks for this review. New Package SCM Request === Package Name: python-requests-toolbelt Short Description: A utility belt for advanced users of python-requests Upstream URL: https://toolbelt.readthedocs.org/ Owners: pnemade Branches: f20 f21 f22 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- python-requests-toolbelt-0.3.1-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-requests-toolbelt-0.3.1-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-requests-toolbelt-0.3.1-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-requests-toolbelt-0.3.1-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- python-requests-toolbelt-0.3.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-requests-toolbelt-0.3.1-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 Parag pnem...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-02-14 01:58:11 --- Comment #9 from Parag pnem...@redhat.com --- Built in rawhide. Closing this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 Florian der-flo Lehner d...@der-flo.net changed: What|Removed |Added Status|NEW |ASSIGNED CC||d...@der-flo.net Assignee|nob...@fedoraproject.org|d...@der-flo.net Flags||fedora-review? --- Comment #1 from Florian der-flo Lehner d...@der-flo.net --- hi Parag! Please include the license text file in your spec file. For example by adding to your files section: %license LICENSE Cheers, Florian -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1188178] Review Request: python-requests-toolbelt - A utility belt for advanced users of python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=1188178 --- Comment #2 from Parag pnem...@redhat.com --- Added license file Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/python-requests-toolbelt.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/python-requests-toolbelt-0.3.1-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
