[Bug 1188564] Review Request: nodejs-keygrip - Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564

Jared Smith  changed:

   What|Removed |Added

 Resolution|NOTABUG |DUPLICATE



--- Comment #15 from Jared Smith  ---


*** This bug has been marked as a duplicate of bug 1495299 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1188564] Review Request: nodejs-keygrip - Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564



--- Comment #13 from Zuzana Svetlikova  ---
I think this is safe to close. If you still want to continue with the review,
open a new bug and close this as a duplicate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip - Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564

Jared Smith  changed:

   What|Removed |Added

 CC||jsmith.fed...@gmail.com
  Flags|needinfo?(apa...@redhat.com |
   |)   |



--- Comment #11 from Jared Smith  ---
In the interest of moving things along here, and keeping the package review
from stalling, I've created my own Spec and SRPMs that I think address all of
the concerns raised in this review.

Piotr, would you mind continuing the review with my spec/SRPM?

Anish, I hope you don't mind me doing this to continue to get this package into
Fedora.

Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-keygrip/nodejs-keygrip.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-keygrip/nodejs-keygrip-1.0.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip - Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564



--- Comment #12 from Piotr Popieluch  ---
Hi Jared,

The official process would be that you open a new review request bug and than
close this one as duplicate [1]. I will review your new request. Unless Anish
still want's to continue?


[1]
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_not_responding

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip - Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564



--- Comment #10 from Piotr Popieluch  ---
This seems stalled, closing bug in one week.
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip - Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 CC||apa...@redhat.com
  Flags||needinfo?(apa...@redhat.com
   ||)



--- Comment #9 from Piotr Popieluch piotr1...@gmail.com ---
anish, any updates on this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip - Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564

Zuzana Svetlikova zsvet...@redhat.com changed:

   What|Removed |Added

 CC||zsvet...@redhat.com
 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip - Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |nodejs-keygrip- Key signing |nodejs-keygrip - Key
   |and verification for|signing and verification
   |rotated credentials |for rotated credentials



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip - Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|piotr1...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip- Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564



--- Comment #7 from Piotr Popieluch piotr1...@gmail.com ---

- update Source0 to comply with github source guidelines:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github

- set correct test as specified in package.json and enable test or explain why
they are disabled

- please remove trailing space at end of line on line 8

- move LICENSE.txt from %doc to %license
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines
https://fedorahosted.org/fpc/ticket/411

- please use BuildRequires npm(scmp) instead of nodejs-scmp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip- Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564



--- Comment #6 from anish apa...@redhat.com ---
Hi Piotr,

Thank you for your review comments, please find new rpms and sprms on 


Spec URL: https://anishpatil.fedorapeople.org/nodejs-keygrip.spec
SRPM URL:
https://anishpatil.fedorapeople.org/nodejs-keygrip-1.0.1-3.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip- Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564



--- Comment #5 from Piotr Popieluch piotr1...@gmail.com ---
Hi Anish,

nodejs packages should symlink the dependencies in the %install section, please
see:

https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Symlinking_Dependencies

Could you update all your nodejs packages to include the %nodejs_symlink macro?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip- Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564



--- Comment #4 from anish apa...@redhat.com ---
HI Piotr,

Thank you for your review comments 

Please find new Spec and SRPM on 

Spec URL: https://anishpatil.fedorapeople.org/nodejs-keygrip.spec
SRPM URL: https://anishpatil.fedorapeople.org/nodejs-keygrip-1.0.1-3.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip- Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564



--- Comment #3 from Piotr Popieluch piotr1...@gmail.com ---
Hi Anish,

Could you enable the tests?

package.json says tests should be executed by: 'node test.js' while the
specfile uses mocha

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip- Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 CC||piotr1...@gmail.com



--- Comment #1 from Piotr Popieluch piotr1...@gmail.com ---
please add BR: nodejs-packaging and rewrap the description to 80 chars.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188564] Review Request: nodejs-keygrip- Key signing and verification for rotated credentials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188564



--- Comment #2 from anish apa...@redhat.com ---
Hi Piotr,

Thank you for package review, please find updated Spec and SRPM on 


Spec URL: https://anishpatil.fedorapeople.org/nodejs-keygrip.spec
SRPM URL:
https://anishpatil.fedorapeople.org/nodejs-keygrip-1.0.1-2.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review