[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576

Piotr Popieluch  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
  Flags|fedora-review-  |
   |needinfo?(apa...@redhat.com |
   |)   |
Last Closed||2015-11-14 08:36:50



--- Comment #12 from Piotr Popieluch  ---
closing.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576



--- Comment #11 from Piotr Popieluch  ---
This seems stalled, closing bug in one week.
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 CC||apa...@redhat.com
  Flags||fedora-review-
   ||needinfo?(apa...@redhat.com
   ||)



--- Comment #10 from Piotr Popieluch piotr1...@gmail.com ---
Hi Anish, any updates?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|piotr1...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576



--- Comment #8 from Piotr Popieluch piotr1...@gmail.com ---
please update to comply with github source guidelines:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github

move license to %license
https://fedorahosted.org/fpc/ticket/411

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576



--- Comment #7 from anish apa...@redhat.com ---
Hi Piotr,

Thank you for your review comments, please find uodated files on 

Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec
SRPM URL:
https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-4.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576



--- Comment #6 from Piotr Popieluch piotr1...@gmail.com ---
Please add exclusivearch:

https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#ExclusiveArch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576



--- Comment #5 from Piotr Popieluch piotr1...@gmail.com ---
fedora-review didn't pick up release 3 because of incorrect srpm url, fixed:

Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec
SRPM URL:
https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-3.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576



--- Comment #4 from anish apa...@redhat.com ---
Hi Piotr,

Thank you for your comments, please find new spec and srpm on 

Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec
SRPM URL: https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-3.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576



--- Comment #3 from Piotr Popieluch piotr1...@gmail.com ---
Hi Anish, 

Do you know why tests fail? is this a missing %nodejs_symlink_deps ?
it fails that it can't find npm(inherits)

ps. you should write
BuildRequires: nodejs-inherits
as
BuildRequires: npm(inherits)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 CC||piotr1...@gmail.com



--- Comment #1 from Piotr Popieluch piotr1...@gmail.com ---
please add BuildRequires: nodejs-packaging and rewrap the the description to 80
chars.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1188576] Review Request: nodejs-create-class - A simple approach to create classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1188576



--- Comment #2 from anish apa...@redhat.com ---
Hi Piotr,

Thank you for your comments, please find updated spec and SRPM

Spec URL: https://anishpatil.fedorapeople.org/nodejs-create-class.spec
SRPM URL:
https://anishpatil.fedorapeople.org/nodejs-create-class-1.0.1-2.fc21.src.rpm
username:anishpatil

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review