[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373
Thomas Spura toms...@fedoraproject.org changed:
What|Removed |Added
Flags|fedora-cvs? |
--- Comment #18 from Thomas Spura toms...@fedoraproject.org ---
As you are only providing the python3-livestreamer, you should also name the
package like that.
I think in order to stay close to upstream it would also be good, if you add a
Provides: livestreamer = %{version}-%{release}, so it can be installed with
yum install livestreamer. See [1] how they recomment to install it on other
platforms.
Are other packages depending on this one?
If not, you could also possibly name it just as livestreamer.
Lifting fedora-cvs because of the above...
[1] http://livestreamer.tanuki.se/install.html
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373
--- Comment #19 from Mario Blättermann mario.blaetterm...@gmail.com ---
(In reply to Thomas Spura from comment #18)
As you are only providing the python3-livestreamer, you should also name the
package like that.
I think in order to stay close to upstream it would also be good, if you add
a Provides: livestreamer = %{version}-%{release}, so it can be installed
with yum install livestreamer. See [1] how they recomment to install it on
other platforms.
Are other packages depending on this one?
If not, you could also possibly name it just as livestreamer.
Lifting fedora-cvs because of the above...
[1] http://livestreamer.tanuki.se/install.html
I haven't found anything in the naming guidelines which would cover such cases
naming a py3-only package. I'm maintaining some packages which are py3-only and
don't mention python in the package name. The packages are pure userland
software which include Python modules, but I don't split the modules into
separate packages. However, if I would do so, other packagers could use the
module packages, although currently I don't know about real use cases.
Well, it is in fact a python3 module with a binary on top. Indeed, it would
be less confusing to name it just livestreamer, as long as no other package
needs the module part.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 MartinKG mgans...@alice.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #20 from MartinKG mgans...@alice.de --- I agree with you on both. upload new rpm files. Spec URL: https://www.dropbox.com/s/uj8b9z8pgt05r1n/livestreamer.spec?dl=0 SRPM URL: https://www.dropbox.com/s/ac508bhfbqpnleu/livestreamer-1.11.1-7.fc21.src.rpm?dl=0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #21 from Thomas Spura toms...@fedoraproject.org --- I think you have two possibilities in these cases: 1. Name it python3-livestreamer as it contains a module for python3 only. Provide livestreamer, so that one can install it with the application name. If you have multiple pythonX-livestremer, only one can provide the application name, but you have the module for several python implementations. 2. Name it livestreamer and either assume that the python3 module is not used anywhere or package it in a python3-livestreamer subpackage. I'd decide this based upon the possible usage by other packages. If nothing else uses this module, I'd probably go with route 2. If other packages (might) depend on it, route 1 should be prefered. (That's why I asked about what packages depend on this in comment #18.) As an example for an application, that right now uses python2 (without the python2-whaawmp subpackage) you could take whaawmp. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373
--- Comment #9 from Mario Blättermann mario.blaetterm...@gmail.com ---
BuildRequires: python-devel
BuildRequires: python-setuptools
BuildRequires: python-futures
BuildRequires: python-requests
BuildRequires: python-singledispatch
BuildRequires: python-sphinx
Requires: fontawesome-fonts
%if 0%{?with_python3}
BuildRequires: python3-devel
BuildRequires: python3-setuptools
BuildRequires: python3-requests
Requires: python3-requests
%endif # with_python3
I would assume that even the py2 package needs python-requests at runtime.
The python3 package doesn't contain the created man page. Note, it must have a
name different from that one in the python2 package, so that both packages can
be installed independent from each other (and don't cause a file conflict).
As already mentioned, Python v3 will become the default in F23, and upstream
Python 2 support ends in a few months. Do you need the Python 2 version of
Livestreamer? If the Python 3 version match your needs, then just drop the Py2
package. It makes it easier to handle possible file conflicts. And our
guidelines only speak about the need to have a Python 3 package if technically
possible, but I don't see anything that it is desired (or even strictly forced)
to have a Python2 one in any case.
$ rpm -qpR python3-livestreamer-1.11.1-4.fc21.noarch.rpm
/usr/bin/env
/usr/bin/python3
python(abi) = 3.4
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PartialHardlinkSets) = 4.0.4-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(PayloadIsXz) = 5.2-1
$ rpm -qpR python-livestreamer-1.11.1-4.fc21.noarch.rpm
/usr/bin/env
/usr/bin/python2
fontawesome-fonts
python(abi) = 2.7
python3-requests
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PartialHardlinkSets) = 4.0.4-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(PayloadIsXz) = 5.2-1
The py3 package also still lacks of the runtime requirement for
fontawesome-fonts. But it is strange that python3-requests has landed in the
python3 package instead of the python3 one...?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373
--- Comment #11 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8938850
The issues from rpmlint:
python3-livestreamer.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python3-livestreamer/html/_static/jquery.js
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.
Install the html docs directly instead of adding them to %doc, then run
dos2unix
%{buildroot}/usr/share/doc/python3-livestreamer/html/_static/jquery.js at the
end of %install to get a proper line ending.
Moreover, the install command should be always called with -p to preserve
timestamps.
python3-livestreamer.noarch: W: hidden-file-or-dir
/usr/share/doc/python3-livestreamer/html/.buildinfo
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.
I assume such .buildinfo files are no longer needed once the package has been
installed.
python3-livestreamer.noarch: W: no-manual-page-for-binary python3-livestreamer
Each executable in standard binary directories should have a man page.
rpmlint doesn't recognize the man page correctly. Either rename the man page
file or the script in /usr/bin. This is not only to make rpmlint happy, it's
also less confusing for users.
python3-livestreamer.src: I: checking
python3-livestreamer.src: I: checking-url http://livestreamer.tanuki.se/
(timeout 10 seconds)
python3-livestreamer.src: E: invalid-spec-name
Your spec filename must end with '.spec'. If it's not the case, rename your
file and rebuild your package.
Of course your spec file has the correct ending, but the name doesn't match the
package name anymore since you have changed the package name.
python3-livestreamer.src: I: checking-url
https://projects.archlinux.org/svntogit/community.git/plain/trunk/plugins-hitbox-Refactor-to-use-the-StreamMapper.patch
(timeout 10 seconds)
python3-livestreamer.src: W: invalid-url Patch0:
https://projects.archlinux.org/svntogit/community.git/plain/trunk/plugins-hitbox-Refactor-to-use-the-StreamMapper.patch
HTTP Error 404: Not found
The value should be a valid, public HTTP, HTTPS, or FTP URL.
Doesn't matter in this case, patches are not forced to have an URL, but this
would be the right one:
https://projects.archlinux.org/svntogit/community.git/plain/trunk/plugins-hitbox-Refactor-to-use-the-StreamMapper.patch?h=packages/livestreamer
But you are free to just use the local file name instead.
%{_mandir}/man1/%{module}.1.gz
Don't use a certain extension for compressed man pages. Well, currently we use
gzip, but this could change in the future. Better use a wildcard:
%{_mandir}/man1/%{module}.1.*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373
--- Comment #12 from Mario Blättermann mario.blaetterm...@gmail.com ---
(In reply to Mario Blättermann from comment #11)
Install the html docs directly instead of adding them to %doc, then run
dos2unix
%{buildroot}/usr/share/doc/python3-livestreamer/html/_static/jquery.js at
the end of %install to get a proper line ending.
BTW, don't forget to add then dos2unix to BuildRequires.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #10 from MartinKG mgans...@alice.de --- dropped py2 package Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-livestreamer.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python3-livestreamer-1.11.1-5.fc21.src.rpm %changelog * Sun Feb 15 2015 Martin Gansser marti...@fedoraproject.org - 1.11.1-5 - dropped Py2 package, because Py2 support ends in a few months - cleanup spec file - renamed package to python3-livestreamer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #15 from MartinKG mgans...@alice.de --- sorry, install -p already done, is the package ready for the final review ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #13 from MartinKG mgans...@alice.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-livestreamer.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-livestreamer-1.11.1-6.fc21.src.rpm %changelog * Sun Feb 15 2015 Martin Gansser marti...@fedoraproject.org - 1.11.1-6 - Install html docs directly instead of adding them to %%doc - Convert files with dos2uni in unix format - Convert files in utf8 format - Deleted Sphinx hash file - Reverted package name - Dropped url address for patch0 - Renamed man page - Used wildcard for manpage - Added BR dos2unix don't know how to pass INSTALL=install -p and on which position that it works. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373
--- Comment #14 from Mario Blättermann mario.blaetterm...@gmail.com ---
(In reply to MartinKG from comment #13)
don't know how to pass INSTALL=install -p and on which position that it
works.
Here, for example:
install -m644 build/sphinx/man/livestreamer.1
%buildroot%{_mandir}/man1/python3-livestreamer.1
Just add the -p switch:
install -p -m644 build/sphinx/man/livestreamer.1
%buildroot%{_mandir}/man1/python3-livestreamer.1
The Python setup script uses the -p switch automatically when calling
%{__python3} setup.py install.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 MartinKG mgans...@alice.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #17 from MartinKG mgans...@alice.de --- @Mario Thanks for the review. - added python3-requests to the spec file New Package SCM Request === Package Name: python-livestreamer Short Description: Extracts streams and pipes them into a video player of choice Owners: martinkg Branches: f20 f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #16 from Mario Blättermann mario.blaetterm...@gmail.com ---
Sorry, I hadn't checked your new spec file carefully.
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8940363
$ rpmlint -i -v *
python-livestreamer.noarch: I: checking
python-livestreamer.noarch: I: checking-url http://livestreamer.tanuki.se/
(timeout 10 seconds)
python-livestreamer.src: I: checking
python-livestreamer.src: I: checking-url http://livestreamer.tanuki.se/
(timeout 10 seconds)
python-livestreamer.src: I: checking-url
https://pypi.python.org/packages/source/l/livestreamer/livestreamer-1.11.1.tar.gz
(timeout 10 seconds)
python-livestreamer.spec: I: checking
python-livestreamer.spec: I: checking-url
https://pypi.python.org/packages/source/l/livestreamer/livestreamer-1.11.1.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
BSD and MIT
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %license.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
84dd83d301518ffcf96f30cbffc0e0598e0756e7ab8e7498d11285d42fe17f9c
livestreamer-1.11.1.tar.gz
84dd83d301518ffcf96f30cbffc0e0598e0756e7ab8e7498d11285d42fe17f9c
livestreamer-1.11.1.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373
--- Comment #6 from Mario Blättermann mario.blaetterm...@gmail.com ---
You are using conditional BuildRequires, which is OK so far:
%if 0%{?with_python3}
BuildRequires: python3-devel
BuildRequires: python3-setuptools
Requires: python3-requests
%endif # with_python3
But in the appropriate %package section, you repeat them, which is confusing
and redundant:
%package -n python3-%{module}
Summary:CLI for piping video streams to video players
Group: Applications/Internet
BuildArch: noarch
BuildRequires: python3-setuptools
BuildRequires: python3-requests
Requires: fontawesome-fonts
To make sure that the egg always gets build from source, remove the bundled
version in src/.
CFLAGS=$RPM_OPT_FLAGS is superfluous for noarch packages.
I'm missing CHANGELOG.rst and CONTRIBUTING.rst from %doc.
The file requirements-docs.txt says that sphinx is needed to build the docs.
Can't find this anywhere in the spec, and the folder docs/ in %doc is only a
copy of the sources (including a Makefile!). This needs to be processed with
python*-sphinx before it gets installed. The current content is unusable, for
example we need index.html instead of index.rst to read the docs in a web
browser, as intended.
OK, let's run rpmlint on your packages anyway:
$ rpmlint -i -v *
python3-livestreamer.noarch: I: checking
python3-livestreamer.noarch: I: checking-url http://livestreamer.tanuki.se/
(timeout 10 seconds)
python3-livestreamer.noarch: W: no-manual-page-for-binary python3-livestreamer
Each executable in standard binary directories should have a man page.
python-livestreamer.noarch: I: checking
python-livestreamer.noarch: I: checking-url http://livestreamer.tanuki.se/
(timeout 10 seconds)
python-livestreamer.noarch: W: no-manual-page-for-binary livestreamer
Each executable in standard binary directories should have a man page.
python-livestreamer.src: I: checking
python-livestreamer.src: I: checking-url http://livestreamer.tanuki.se/
(timeout 10 seconds)
python-livestreamer.src: I: checking-url
https://pypi.python.org/packages/source/l/livestreamer/livestreamer-1.11.1.tar.gz
(timeout 10 seconds)
python-livestreamer.spec: I: checking
python-livestreamer.spec: I: checking-url
https://pypi.python.org/packages/source/l/livestreamer/livestreamer-1.11.1.tar.gz
(timeout 10 seconds)
3 packages and 1 specfiles checked; 0 errors, 2 warnings.
OK so far, rpmlint is quite silent. The missing man page is not up to you to
fix.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #7 from Mario Blättermann mario.blaetterm...@gmail.com --- Just tested the python3 package. »BuildRequires: python3-requests« is also needed as a runtime requirement, please add it to »Requires:«. I was able to create a man page with the following command: $ help2man python3-livestreamer -n extracts streams and pipes them into a video player of choice -s 1 -N --no-discard-stderr -o python-livestreamer.1 Well, I haven't tested it in the buildroot directory, it works with the locally installed package in any case. In doubt, pre-create the man page(s) on your local system and add them to the package manually. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #8 from MartinKG mgans...@alice.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-livestreamer.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-livestreamer-1.11.1-4.fc21.src.rpm %changelog * Fri Feb 13 2015 Martin Gansser marti...@fedoraproject.org - 1.11.1-4 - Added manually created man page - Dropped CFLAGS for noarch package - Dropped BR in subpackage python3-livestreamer due redundancy - Removed bundled livestreamer.egg-info - Added R python3-requests - Generate man page and html documentation - Added BR python-sphinx - Added plugins-hitbox-Refactor-to-use-the-StreamMapper.patch Build Target: f21 - http://koji.fedoraproject.org/koji/taskinfo?taskID=8923607 Build Target: f22 - http://koji.fedoraproject.org/koji/taskinfo?taskID=8923597 Build Target: rawhide - http://koji.fedoraproject.org/koji/taskinfo?taskID=8923616 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #5 from MartinKG mgans...@alice.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-livestreamer.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-livestreamer-1.11.1-3.fc21.src.rpm %changelog * Thu Feb 12 2015 Martin Gansser marti...@fedoraproject.org - 1.11.1-3 - Added BR python-futures - Added BR python-requests - Added BR python-singledispatch - Added BR python3-requests to subpackage python3-livestreamer - Added R fontawesome-fonts to subpackage python3-livestreamer koji build.log: http://koji.fedoraproject.org/koji/taskinfo?taskID=8911780 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #4 from MartinKG mgans...@alice.de --- Created attachment 990767 -- https://bugzilla.redhat.com/attachment.cgi?id=990767action=edit mock build.log mock -r fedora-rawhide-x86_64-rpmfusion_free --resultdir=/tmp/mock --rebuild ~/rpmbuild/SRPMS/python-livestreamer-1.11.1-2.fc21.src.rpm test fails with python2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #2 from MartinKG mgans...@alice.de --- have found that the package contains bundled fonts files = SHOULD items = Generic: [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files In the doc path contains the fontawesome font /usr/share/doc/python-livestreamer/docs/_themes/sphinx_rtd_theme_violet/static/fonts /usr/share/doc/python-livestreamer/docs/_themes/sphinx_rtd_theme_violet/static/fonts/FontAwesome.otf /usr/share/doc/python-livestreamer/docs/_themes/sphinx_rtd_theme_violet/static/fonts/fontawesome-webfont.eot /usr/share/doc/python-livestreamer/docs/_themes/sphinx_rtd_theme_violet/static/fonts/fontawesome-webfont.svg /usr/share/doc/python-livestreamer/docs/_themes/sphinx_rtd_theme_violet/static/fonts/fontawesome-webfont.ttf /usr/share/doc/python-livestreamer/docs/_themes/sphinx_rtd_theme_violet/static/fonts/fontawesome-webfont.woff Fedora itself brings already a fontawesome font package with this contents: rpm -ql fontawesome-fonts /etc/fonts/conf.d/60-fontawesome.conf /usr/share/doc/fontawesome-fonts /usr/share/doc/fontawesome-fonts/README-Trademarks.txt /usr/share/fontconfig/conf.avail/60-fontawesome.conf /usr/share/fonts/fontawesome /usr/share/fonts/fontawesome/FontAwesome.otf /usr/share/fonts/fontawesome/fontawesome-webfont.ttf how can I put links to the font package ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #3 from MartinKG mgans...@alice.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-livestreamer.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-livestreamer-1.11.1-2.fc21.src.rpm %changelog * Tue Feb 10 2015 Martin Gansser marti...@fedoraproject.org - 1.11.1-2 - Removd bundled fonts - Add fontawesome-fonts requires. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190373] Review Request: python-livestreamer - Extracts streams and pipes them into a video player of choice
https://bugzilla.redhat.com/show_bug.cgi?id=1190373 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com --- Taking this for a full review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
