[Bug 1190733] Review Request: mycila-licenses - Licenses used in Mycila projects
https://bugzilla.redhat.com/show_bug.cgi?id=1190733 zzamb...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-02-20 07:09:56 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190733] Review Request: mycila-licenses - Licenses used in Mycila projects
https://bugzilla.redhat.com/show_bug.cgi?id=1190733 zzamb...@redhat.com changed: What|Removed |Added Resolution|NEXTRELEASE |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190733] Review Request: mycila-licenses - Licenses used in Mycila projects
https://bugzilla.redhat.com/show_bug.cgi?id=1190733 zzamb...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from zzamb...@redhat.com --- New Package SCM Request === Package Name: mycila-licenses Short Description: Licenses used in Mycila projects. Upstream URL: https://github.com/mycila/licenses Owners: zzambers jvanek Branches: f22 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190733] Review Request: mycila-licenses - Licenses used in Mycila projects
https://bugzilla.redhat.com/show_bug.cgi?id=1190733 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190733] Review Request: mycila-licenses - Licenses used in Mycila projects
https://bugzilla.redhat.com/show_bug.cgi?id=1190733 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190733] Review Request: mycila-licenses - Licenses used in Mycila projects
https://bugzilla.redhat.com/show_bug.cgi?id=1190733 --- Comment #4 from zzamb...@redhat.com --- I am sorry, I thought, they are same Spec URL: http://www.zkusebnidomena.czweb.org/rpms/mycila-licenses/v3/mycila-licenses.spec SRPM URL: http://www.zkusebnidomena.czweb.org/rpms/mycila-licenses/v3/mycila-licenses-1-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190733] Review Request: mycila-licenses - Licenses used in Mycila projects
https://bugzilla.redhat.com/show_bug.cgi?id=1190733
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8970826
$ rpmlint -i -v *mycila-licenses.noarch: I: checking
mycila-licenses.noarch: I: checking-url https://github.com/mycila/licenses
(timeout 10 seconds)
mycila-licenses.src: I: checking
mycila-licenses.src: I: checking-url https://github.com/mycila/licenses
(timeout 10 seconds)
mycila-licenses.src: I: checking-url
https://github.com/mycila/licenses/archive/licenses-1.tar.gz (timeout 10
seconds)
mycila-licenses.spec: I: checking
mycila-licenses.spec: I: checking-url
https://github.com/mycila/licenses/archive/licenses-1.tar.gz (timeout 10
seconds)
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
ASL 2.0
[.] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %license.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
62d75025b4c4cb72c7a9f27288c7d16ddbad3d3a08117ce1258effcbbae5d0e8
licenses-1.tar.gz
62d75025b4c4cb72c7a9f27288c7d16ddbad3d3a08117ce1258effcbbae5d0e8
licenses-1.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
It is often not that useful to generate %files from a automatically created
list. This makes it more difficult to figure out whether directory ownerships
are OK. A static file list which matches the packaging guidelines would be:
%files
%doc README.md
%{_docdir}/mycila-licenses
%{_datadir}/java/mycila-licenses/licenses.jar
%{_datadir}/maven-metadata/mycila-licenses.xml
%{_datadir}/maven-poms/mycila-licenses/licenses.pom
However, the ownerships are OK due to jpackages-utils as runtime requirement.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[Bug 1190733] Review Request: mycila-licenses - Licenses used in Mycila projects
https://bugzilla.redhat.com/show_bug.cgi?id=1190733 --- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8965448 $ rpmlint -i -v * mycila-licenses.noarch: I: checking mycila-licenses.noarch: I: checking-url https://github.com/mycila/licenses (timeout 10 seconds) mycila-licenses.src: I: checking mycila-licenses.src: I: checking-url https://github.com/mycila/licenses (timeout 10 seconds) mycila-licenses.src: I: checking-url https://github.com/mycila/licenses/archive/licenses-1.tar.gz (timeout 10 seconds) mycila-licenses.spec: I: checking mycila-licenses.spec: I: checking-url https://github.com/mycila/licenses/archive/licenses-1.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 0 warnings. No issues. Checksums differ: $ sha256sum * 62d75025b4c4cb72c7a9f27288c7d16ddbad3d3a08117ce1258effcbbae5d0e8 licenses-1-orig.tar.gz 5dca22d33cafe3bdc9e739e7a6aab80f6889fe6cddc4928cf4c3bc1005c8157b licenses-1.tar.gz If you use an URL for the tarball, you must also use it to fetch the sources. This is the content of your tarball: $ tar xvzf licenses-1.tar.gzlicenses-1/ licenses-1/.gitignore licenses-1/README.md licenses-1/pom.xml licenses-1/src/ licenses-1/src/main/ licenses-1/src/main/resources/ licenses-1/src/main/resources/com/ licenses-1/src/main/resources/com/mycila/ licenses-1/src/main/resources/com/mycila/licenses/ licenses-1/src/main/resources/com/mycila/licenses/APACHE-2 licenses-1/src/main/resources/com/mycila/licenses/MIT The original tarball contains an extra directory licenses-licenses-1: $ tar xvzf licenses-1-orig.tar.gz licenses-licenses-1/ licenses-licenses-1/.gitignore licenses-licenses-1/README.md licenses-licenses-1/pom.xml licenses-licenses-1/src/ licenses-licenses-1/src/main/ licenses-licenses-1/src/main/resources/ licenses-licenses-1/src/main/resources/com/ licenses-licenses-1/src/main/resources/com/mycila/ licenses-licenses-1/src/main/resources/com/mycila/licenses/ licenses-licenses-1/src/main/resources/com/mycila/licenses/APACHE-2 licenses-licenses-1/src/main/resources/com/mycila/licenses/MIT You are not allowed to change the structure. Use the tarball as is. To solve the problem, you can add an extra command cd licenses-licenses-1 in %prep after unpacking the tarball. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190733] Review Request: mycila-licenses - Licenses used in Mycila projects
https://bugzilla.redhat.com/show_bug.cgi?id=1190733 --- Comment #2 from zzamb...@redhat.com --- Spec URL: http://www.zkusebnidomena.czweb.org/rpms/mycila-licenses/v2/mycila-licenses.spec SRPM URL: http://www.zkusebnidomena.czweb.org/rpms/mycila-licenses/v2/mycila-licenses-1-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190733] Review Request: mycila-licenses - Licenses used in Mycila projects
https://bugzilla.redhat.com/show_bug.cgi?id=1190733 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8939074 $ rpmlint -i -v * mycila-licenses.src: I: checking mycila-licenses.src: E: description-line-too-long C DO NOT USE THIS PROJECT OUT OF MYCILA PARENT POM: This is an internal Mycila JAR ! Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. mycila-licenses.src: I: checking-url https://github.com/mycila/licenses (timeout 10 seconds) mycila-licenses.src:2: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. mycila-licenses.src: I: checking-url https://github.com/mycila/licenses/archive/licenses-1.tar.gz (timeout 10 seconds) mycila-licenses.noarch: I: checking mycila-licenses.noarch: E: description-line-too-long C DO NOT USE THIS PROJECT OUT OF MYCILA PARENT POM: This is an internal Mycila JAR ! Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. mycila-licenses.noarch: I: checking-url https://github.com/mycila/licenses (timeout 10 seconds) mycila-licenses.noarch: W: spurious-executable-perm /usr/share/doc/mycila-licenses/README.md The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. mycila-licenses.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/mycila-licenses/README.md This script has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It will prevent its execution. mycila-licenses.spec: I: checking mycila-licenses.spec:2: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. mycila-licenses.spec: I: checking-url https://github.com/mycila/licenses/archive/licenses-1.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 3 errors, 3 warnings. Please replace the tabs with spaces in your spec. The file README.md needs also to be fixed with dos2unix and removed the executable bit from. The description line needs to be wrapped at 80 characters. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
