[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #32 from Fedora Update System upda...@fedoraproject.org --- gtk-sharp3-2.99.3-10.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #34 from Fedora Update System upda...@fedoraproject.org --- gtk-sharp3-2.99.3-10.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #33 from Fedora Update System upda...@fedoraproject.org --- gtk-sharp3-2.99.3-10.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #24 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- (In reply to Claudio Rodrigo Pereyra DIaz from comment #23) Can I mark now the fedora_cvs flag? Yes! See https://fedoraproject.org/wiki/New_package_process_for_existing_contributors for more details. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar changed: What|Removed |Added Flags||fedora-cvs? --- Comment #25 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- New Package SCM Request === Package Name: gtk-sharp3 Short Description: GTK+ 3 and GNOME 3 bindings for Mono Upstream URL: http://www.mono-project.com/GtkSharp Owners: elsupergomez mono-sig Branches: f21 f22 epel7 InitialCC: elsupergomez -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #27 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- New Package SCM Request === Package Name: gtk-sharp3 Short Description: GTK+ 3 and GNOME 3 bindings for Mono Upstream URL: http://www.mono-project.com/docs/gui/gtksharp/ Owners: elsupergomez mono-sig Branches: f21 f22 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #26 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- (In reply to Claudio Rodrigo Pereyra DIaz from comment #25) New Package SCM Request === Package Name: gtk-sharp3 Short Description: GTK+ 3 and GNOME 3 bindings for Mono Upstream URL: http://www.mono-project.com/GtkSharp Upstream URL: http://www.mono-project.com/docs/gui/gtksharp/ Owners: elsupergomez mono-sig Branches: f21 f22 epel7 InitialCC: elsupergomez -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #23 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- Improve with suggestions. Spec URL: https://elsupergomez.fedorapeople.org/SPECS/gtk-sharp3.spec SRPM URL: https://elsupergomez.fedorapeople.org/SRPMS/gtk-sharp3-2.99.3-10.fc21.src.rpm Can I mark now the fedora_cvs flag? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #28 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #30 from Fedora Update System upda...@fedoraproject.org --- gtk-sharp3-2.99.3-10.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/gtk-sharp3-2.99.3-10.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #29 from Fedora Update System upda...@fedoraproject.org --- gtk-sharp3-2.99.3-10.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/gtk-sharp3-2.99.3-10.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #31 from Fedora Update System upda...@fedoraproject.org --- gtk-sharp3-2.99.3-10.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/gtk-sharp3-2.99.3-10.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-05-15 14:47:36 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #19 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- Please restore the SRPM then :) Can't review what I can't download. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #20 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- Spec URL: https://elsupergomez.fedorapeople.org/SPECS/gtk-sharp3.spec SRPM URL: https://elsupergomez.fedorapeople.org/SRPMS/gtk-sharp3-2.99.3-9.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #22 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- OK, I looked at the perl guidelines again, and they really apply only to modules. Since there's only a perl script in the package, automatically generated dependency on perl(XML::LibXML) should be enough. So please disregard that comment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #21 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Upstream URL changed to http://www.mono-project.com/docs/gui/gtksharp/.
Some minor issues are marked below with ? or !. Please fix them up (or comment
why they are ok as is). Package is APPROVED.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: MIT/X11 (BSD like), GPL (v2 or later), GPL (v2) (with
incorrect FSF address), Unknown or generated. 355 files have
unknown license. Detailed output of licensecheck in /var/tmp/1192059
-gtk-sharp3/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/mono/gac/pango-sharp
(gtk-sharp2), /usr/lib/mono/gac/gtk-dotnet(gtk-sharp2),
/usr/lib/mono/gac/atk-sharp(gtk-sharp2), /usr/lib/mono/gac/glib-sharp
(gtk-sharp2), /usr/lib/mono/gac/gtk-sharp(gtk-sharp2),
/usr/lib/mono/gac/gdk-sharp(gtk-sharp2)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[?]: Package contains the mandatory BuildRequires and Requires:.
Note: Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`;
echo $version)) missing?
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]:
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #18 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #17) The review was not completed. You had the NEEDSPONSOR flag set, and I didn't see that you are already in the packager group. If you wish, I'll take the review. I was sponsored yesterday by laxton. Yes, please take the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- WARNING: fedora-review flag not set -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #17 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- The review was not completed. You had the NEEDSPONSOR flag set, and I didn't see that you are already in the packager group. If you wish, I'll take the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #15 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- New Package SCM Request === Package Name: gtk-sharp3 Short Description: GTK+ 3 and GNOME 3 bindings for Mono Upstream URL: http://www.mono-project.com/GtkSharp Owners: elsupergomez Branches: f21 f22 epel7 InitialCC: elsupergomez -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #14 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- Fix(In reply to Zbigniew Jędrzejewski-Szmek from comment #13) Right, package looks OK. One question: how is the virtual Provides:libmono-profiler-gui-thread-check supposed to be used? Can't sponsor you, sorry. I'd suggest heading over to http://fedoraproject.org/PackageReviewStatus/ and doing some reviews in trivial or new categories. Removed, this was for problem with rpm that not detected the provides lib requiered by monodevelop, but this was fixed and now I removed form spec. Thank -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #13 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- Right, package looks OK. One question: how is the virtual Provides:libmono-profiler-gui-thread-check supposed to be used? Can't sponsor you, sorry. I'd suggest heading over to http://fedoraproject.org/PackageReviewStatus/ and doing some reviews in trivial or new categories. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #9 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- Thanks for feedback. I add define for mono macros to proper build in epel7 to. For that I leave the Group tag. Other suggestion was applied Spec URL: https://elsupergomez.fedorapeople.org/SPECS/gtk-sharp3.spec SRPM URL: https://elsupergomez.fedorapeople.org/SRPMS/gtk-sharp3-2.99.3-7.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #10 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- Koji task: https://koji.fedoraproject.org/koji/taskinfo?taskID=9658746 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059
--- Comment #11 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Sorry, I made a typo: it's %{?_smp_mflags} not %{?_smp_flags} .
- ldconfig called in %post and %postun if required.
Note: /sbin/ldconfig not called in gtk-sharp3
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
Perl:
[ ]: Package contains the mandatory BuildRequires and Requires:.
Note: Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`;
echo $version)) missing?
You have some explicit dependencies on perl packages, but they should be
generated automatically. If automatic generation does not work, add a comment
in the spec file.
gtk-sharp3.x86_64: W: file-not-utf8 /usr/share/doc/gtk-sharp3/AUTHORS
Directory /usr/lib/gapi-3.0 should be owned by gtk-sharp3-gapi
Consider adding %global _docdir_fmt %{name} somewhere at the top. This will
make all subpackages use the same license and doc directories, reducing
duplication of files.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #12 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- I think that now all suggestion was applied. Spec URL: https://elsupergomez.fedorapeople.org/SPECS/gtk-sharp3.spec SRPM URL: https://elsupergomez.fedorapeople.org/SRPMS/gtk-sharp3-2.99.3-8.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:
What|Removed |Added
CC||zbys...@in.waw.pl
--- Comment #6 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Summary should be improved to not simply repeat the package name in different
order. Is a library? Is it bindings?
%description should be explanded to be a useful paragraph.
Can Source be downloaded from the web? Try to use a real URL.
Group tags can be removed.
No need to repeat License in subpackages if it is the same as the main package.
Add %{?_isa} to Requires: %{name} = %{version}.
Can parallel build be used? If so, add %{?_smp_flags} to make.
Most likely .la files should be removed.
Add 'find %{buildroot} -name \*.la -delete' or similar.
Use -delete instead of -exec rm {} \; with find.
Are both static libraries (*.a) and .so files needed?
Use %make_install (see
https://fedoraproject.org/wiki/Make_install_packaging_draft).
Your package should not own %{_datadir}.
What about the license: is there a license file?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059
--- Comment #7 from Claudio Rodrigo Pereyra DIaz
claudiorodr...@pereyradiaz.com.ar ---
Update with feedback
Spec URL: https://elsupergomez.fedorapeople.org/SPECS/gtk-sharp3.spec
SRPM URL:
https://elsupergomez.fedorapeople.org/SRPMS/gtk-sharp3-2.99.3-6.fc21.src.rpm
Copr Mono 3 URL: https://copr.fedoraproject.org/coprs/elsupergomez/mono
Copr Mono 4 URL: https://copr.fedoraproject.org/coprs/tpokorra/mono/monitor/
Description: Mono bindings for Gtk3
Fedora Account System Username: elsupergomez
I don't understand how use %{?_isa} in requires
Why and where Group tags should be removed?
Other suggestion was applied.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059
--- Comment #8 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
(In reply to Claudio Rodrigo Pereyra DIaz from comment #7)
You forgot to update the .spec file. The one in srpm is correct, so I'm using
that.
Why and where Group tags should be removed?
Everywhere :) They are harmeless, but not really used for anything.
I don't understand how use %{?_isa} in requires
This only makes sense when an arch-full package depends on another arch-full
package built from the same srpm. For example, %{name}-devel depends %{name}.
The dependency without %{_isa} can be satisfied by a package from different
architecture:
%{name}-%{version}.i686 + %{name}-devel-%{version}.x86_64
But this is actually broken, since -devel needs the main package from the same
architecture.
To forbid that, you can use:
Requires: %{name}%{?_isa} = %{version}-%{release}
Some more issues:
- Summary is better, but it should be less than 70 chars :)
- part of %build (everything except %configure and make) should be moved to
%prep.
- %make_install already has DESTDIR, so no need to set it
- find %{buildroot} -name \*.*a -delete looks wrong. This will delete any file
which has a dot and ends in an 'a'.
- %defattr is not needed (see
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions)
- Should -doc be an archful package? Probably not, consider adding
BuildArch: noarch (in the part for -doc).
- Why doc -doc require the main package? I don't think there's a dependency.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #5 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- Update. Add support to build with Mono 4 to Spec URL: https://elsupergomez.fedorapeople.org/SPECS/gtk-sharp3.spec SRPM URL: https://elsupergomez.fedorapeople.org/SRPMS/gtk-sharp3-2.99.3-5.fc21.src.rpm Copr Mono 3 URL: https://copr.fedoraproject.org/coprs/elsupergomez/mono Copr Mono 4 URL: https://copr.fedoraproject.org/coprs/tpokorra/mono/monitor/ Description: Mono bindings for Gtk3 Fedora Account System Username: elsupergomez -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #4 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- Update. Now build with mono 2.10 too. Spec URL: https://elsupergomez.fedorapeople.org/SPECS/gtk-sharp3.spec SRPM URL: https://elsupergomez.fedorapeople.org/SRPMS/gtk-sharp3-2.99.3-2.fc20.src.rpm Copr URL: https://copr.fedoraproject.org/coprs/elsupergomez/mono Koji Task: http://koji.fedoraproject.org/koji/taskinfo?taskID=9141930 Description: Mono bindings for Gtk3 Fedora Account System Username: elsupergomez -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 Carlos Morel-Riquelme empateinfin...@gmail.com changed: What|Removed |Added CC||empateinfin...@gmail.com --- Comment #2 from Carlos Morel-Riquelme empateinfin...@gmail.com --- Hello Claudio, this is a INFORMAL REVIEW , i'm not a package sponsor, but i can help you to solved some warnings or issues. Well i can't build your package because in your spec to have this lines: Requires: mono-core = 3.0 BuildRequires: mono-core = 3.0 basically you are say that you need mono-core-3.0 for build this package, here is the issue because the actual version of mono-core in f21,f22,f23 is 2.10.8-8 So you need change this two lines and put a correct version of mono-core. Regards Claudio :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar changed: What|Removed |Added Depends On||1089278 --- Comment #3 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- Thanks. I dont try build with mono 2.10. But if work I will the version on dependency Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1089278 [Bug 1089278] Mono 3.4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar changed: What|Removed |Added Depends On|1089278 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1089278 [Bug 1089278] Mono 3.4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 --- Comment #1 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- Avaible in Copr https://copr.fedoraproject.org/coprs/elsupergomez/mono -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1192059 Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
