[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 Fedora Update System changed: What|Removed |Added Fixed In Version|skylable-sx-1.0-7.fc22 |skylable-sx-1.1-2.fc21 --- Comment #12 from Fedora Update System --- skylable-sx-1.1-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 --- Comment #11 from Fedora Update System --- skylable-sx-1.1-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/skylable-sx-1.1-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 --- Comment #10 from Fedora Update System --- skylable-sx-1.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/skylable-sx-1.1-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||skylable-sx-1.0-7.fc22 Resolution|--- |ERRATA Last Closed||2015-03-26 17:57:59 --- Comment #9 from Fedora Update System --- skylable-sx-1.0-7.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- skylable-sx-1.0-7.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 --- Comment #7 from Fedora Update System --- skylable-sx-1.0-7.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/skylable-sx-1.0-7.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 Török Edwin changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Török Edwin --- New Package SCM Request === Package Name: skylable-sx Short Description: Scalable public and private cloud storage Upstream URL: http://www.skylable.com/products/sx Owners: edwintorok Branches: f21 f22 InitialCC: edwintorok -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 Tom "spot" Callaway changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Tom "spot" Callaway --- APPROVED. Thanks for being patient on this one, it normally doesn't take me quite that long. :) I've just added you to the packager group, please continue the process from here: http://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Get_Sponsored -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175 --- Comment #3 from Török Edwin --- Created attachment 1001206 --> https://bugzilla.redhat.com/attachment.cgi?id=1001206&action=edit skylable-sx.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175
--- Comment #2 from Török Edwin ---
(In reply to Tom "spot" Callaway from comment #1)
> Check and resolve the few TODO items and I'll approve this package and
> sponsor you.
Thanks a lot for reviewing the package!
>
> == Review ==
> TODO items:
New SRPM:
http://vol-public.s3.indian.skylable.com:8008/fedorareview/skylable-sx-1.0-5.fc22.src.rpm
New koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=9212411
>
> * Please make sure the systemd scripts work properly. This isn't a blocker,
> but I just didn't have the arrangement to test them out fully.
Works, tested on F22 Workstation Alpha, see below [1].
> * The -devel package has these files in it:
> /usr/lib64/sxclient/libsxf_aes256.so
> /usr/lib64/sxclient/libsxf_attribs.so
> /usr/lib64/sxclient/libsxf_undelete.so
> /usr/lib64/sxclient/libsxf_zcomp.so
>
> I know sometimes the .so files in a subdir of %{_libdir} are not devel
> libraries, but rather, plugin libraries/modules that are needed for proper
> operation. Please confirm that these files should be in the -devel
> subpackage.
I confirm that the real plugins are in the -libs package, and they work even if
-devel is not installed, see [2]:
/usr/lib64/sxclient/libsxf_aes256-13.so
/usr/lib64/sxclient/libsxf_attribs-11.so
/usr/lib64/sxclient/libsxf_undelete-11.so
/usr/lib64/sxclient/libsxf_zcomp-10.so
>
> * Spec says license is GPLv2, COPYING says it is "GPLv2 with exceptions and
> LGPLv2+ and BSD and MIT". Please correct the spec License field.
Updated the License field to:
main package and -client:
License: GPLv2 with exceptions and LGPLv2+ and BSD and MIT
-devel: License: LGPLv2+ with exceptions
-libs: License: LGPLv2+ with exceptions and MIT
>
> Good:
> skylable-sx.x86_64: W: no-manual-page-for-binary sx.fcgi
> skylable-sx.x86_64: W: no-manual-page-for-binary sxserver
> skylable-sx.x86_64: W: no-manual-page-for-binary sxsetup
> skylable-sx.x86_64: W: no-manual-page-for-binary sxreport-server
> skylable-sx.x86_64: W: no-manual-page-for-binary sxadm
> skylable-sx-client.x86_64: W: no-manual-page-for-binary sxsim
>
> Upstream should consider writing man pages for these binaries, but it is not
> a blocker for Fedora/EPEL.
We have this on our roadmap for version 1.1:
https://bugzilla.skylable.com/show_bug.cgi?id=1136
[1] How to test systemd units
# sxsetup
[...]
Enter the cluster name (use the same across all nodes) []: testme
[... accept defaults...]
# systemctl status sxserver sx-nginx
● sxserver.service - Scalable public and private cloud storage server
Loaded: loaded (/usr/lib/systemd/system/sxserver.service; disabled; vendor
preset: disabled)
Active: active (running) since Thu 2015-03-12 22:45:14 EET; 1min 25s ago
[...]
● sx-nginx.service - The SX nginx HTTP server instance
Loaded: loaded (/usr/lib/systemd/system/sx-nginx.service; disabled; vendor
preset: disabled)
Active: active (running) since Thu 2015-03-12 22:45:15 EET; 1min 25s ago
[...]
# systemctl stop sxserver
# systemctl status sxserver sx-nginx
● sxserver.service - Scalable public and private cloud storage server
Loaded: loaded (/usr/lib/systemd/system/sxserver.service; disabled; vendor
preset: disabled)
Active: inactive (dead)
[...]
● sx-nginx.service - The SX nginx HTTP server instance
Loaded: loaded (/usr/lib/systemd/system/sx-nginx.service; disabled; vendor
preset: disabled)
Active: inactive (dead)
# systemctl start sxserver
# systemctl status sxserver sx-nginx
● sxserver.service - Scalable public and private cloud storage server
Loaded: loaded (/usr/lib/systemd/system/sxserver.service; disabled; vendor
preset: disabled)
Active: active (running) since Thu 2015-03-12 22:47:44 EET; 1s ago
[...]
● sx-nginx.service - The SX nginx HTTP server instance
Loaded: loaded (/usr/lib/systemd/system/sx-nginx.service; disabled; vendor
preset: disabled)
Active: active (running) since Thu 2015-03-12 22:47:44 EET; 951ms ago
After a reboot the service is not running, however after running
'sudo systemctl enable sxserver' and rebooting it will (this should be
consistent with how sshd behaves).
[2] Testing plugins (filters)
# sudo sxvol filter
NameVerTypeShort description
----
attribs 1.1genericPreserve file attributes
aes256 1.4cryptEncrypt data using AES-256-CBC-HMAC-512
mode.
zcomp 1.0compressCompress files using zlib
undelete1.1genericBackup removed files
# sxvol create -o admin -r 1 -f aes256 -s 10G sx://admin@testme/enc
[aes256]: Enter encryption password:
[aes256]: Re-enter encryption password:
Volume 'enc' (replica: 1, size: 10G, max-revisions: 1) created.
# sxcp /etc/redhat-release sx://admin@testme/enc/
Uploading /etc/redhat-release (size: 80B)
Transferred 4KB in <1s (@127.52KB/s)
# sxcp sx://admin@testme/enc/redhat-release .
Downloading redhat-release (size: 80B)
Transfer
[Bug 1193175] Review Request: skylable-sx - Scalable public and private cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1193175
Tom "spot" Callaway changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|tcall...@redhat.com
Flags||fedora-review?
--- Comment #1 from Tom "spot" Callaway ---
Check and resolve the few TODO items and I'll approve this package and sponsor
you.
== Review ==
TODO items:
* Please make sure the systemd scripts work properly. This isn't a blocker, but
I just didn't have the arrangement to test them out fully.
* The -devel package has these files in it:
/usr/lib64/sxclient/libsxf_aes256.so
/usr/lib64/sxclient/libsxf_attribs.so
/usr/lib64/sxclient/libsxf_undelete.so
/usr/lib64/sxclient/libsxf_zcomp.so
I know sometimes the .so files in a subdir of %{_libdir} are not devel
libraries, but rather, plugin libraries/modules that are needed for proper
operation. Please confirm that these files should be in the -devel subpackage.
* Spec says license is GPLv2, COPYING says it is "GPLv2 with exceptions and
LGPLv2+ and BSD and MIT". Please correct the spec License field.
Good:
- rpmlint checks return:
skylable-sx.src: W: spelling-error Summary(en_US) Scalable -> Salable,
Callable, Calculable
skylable-sx.src: W: spelling-error %description -l en_US deduplication ->
reduplication, duplication, quadruplication
Safe to ignore.
skylable-sx.src:4: E: hardcoded-library-path in
/usr/lib/systemd/system/sx-nginx.service
skylable-sx.src:5: E: hardcoded-library-path in
/usr/lib/systemd/system/sxserver.service
Safe to ignore.
skylable-sx.x86_64: E: explicit-lib-dependency libselinux-utils
Safe to ignore, false positive.
skylable-sx.x86_64: W: spelling-error Summary(en_US) Scalable -> Salable,
Callable, Calculable
skylable-sx.x86_64: W: spelling-error %description -l en_US deduplication ->
reduplication, duplication, quadruplication
Safe to ignore.
skylable-sx.x86_64: E: non-readable /usr/share/selinux/packages/sxserver.pp
0600L
Fine. Selinux policy does not need to be +r.
skylable-sx.x86_64: W: non-ghost-in-run /run/sxserver
This is safe to ignore, package follows Fedora /run guidelines.
skylable-sx.x86_64: W: no-manual-page-for-binary sx.fcgi
skylable-sx.x86_64: W: no-manual-page-for-binary sxserver
skylable-sx.x86_64: W: no-manual-page-for-binary sxsetup
skylable-sx.x86_64: W: no-manual-page-for-binary sxreport-server
skylable-sx.x86_64: W: no-manual-page-for-binary sxadm
skylable-sx-client.x86_64: W: no-manual-page-for-binary sxsim
Upstream should consider writing man pages for these binaries, but it is not a
blocker for Fedora/EPEL.
skylable-sx-client.x86_64: W: non-standard-group Cloud Infrastructure
Group is unused, this is safe to ignore.
skylable-sx-devel.x86_64: W: only-non-binary-in-usr-lib
Safe to ignore.
- package meets naming guidelines
- package meets packaging guidelines (except license tag, see above)
- spec file legible, in am. english
- source matches upstream
(ba96db807c1ff1265a7476d31c2d7fbb14a9a3f3bc55950e1c8da7edaa00a98a)
- package compiles on F-22 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires libs package n-v-r
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
