[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 Fedora Update System changed: What|Removed |Added Fixed In Version|libuecc-5-2.fc20|libuecc-5-2.el7 --- Comment #10 from Fedora Update System --- libuecc-5-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 Fedora Update System changed: What|Removed |Added Fixed In Version|libuecc-5-2.fc21|libuecc-5-2.fc20 --- Comment #9 from Fedora Update System --- libuecc-5-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Fixed In Version||libuecc-5-2.fc21 Resolution|--- |ERRATA Last Closed||2015-03-05 07:33:05 --- Comment #8 from Fedora Update System --- libuecc-5-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 --- Comment #6 from Fedora Update System --- libuecc-5-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/FEDORA-2015-2510/libuecc-5-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 --- Comment #7 from Fedora Update System --- libuecc-5-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-0939/libuecc-5-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 --- Comment #5 from Fedora Update System --- libuecc-5-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/FEDORA-2015-2509/libuecc-5-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 Felix Kaechele changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Felix Kaechele --- New Package SCM Request === Package Name: libuecc Short Description: Very small Elliptic Curve Cryptography library Upstream URL: http://git.universe-factory.net/libuecc Owners: heffer Branches: f20 f21 f22 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 --- Comment #2 from Felix Kaechele --- Thank your for this review. I have changed the %doc tag to %license here: SPEC: https://heffer.fedorapeople.org/review/libuecc/libuecc.spec SRPM: https://heffer.fedorapeople.org/review/libuecc/libuecc-5-2.fc21.src.rpm This is the version I will commit then. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187
Florian "der-flo" Lehner changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||d...@der-flo.net
Assignee|nob...@fedoraproject.org|d...@der-flo.net
Flags||fedora-review+
--- Comment #1 from Florian "der-flo" Lehner ---
Hi Felix!
One minor thing:
[ ] Please remove COPYING from %doc and add
%license COPYING
to the files section
This is not a blocker, so I approve this package.
Cheers,
Florian
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"BSD (2 clause)".
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sec
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 Felix Kaechele changed: What|Removed |Added Blocks||1194188 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1194188 [Bug 1194188] Review Request: fastd - Fast and secure tunneling daemon -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194187] Review Request: libuecc - Very small Elliptic Curve Cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1194187 Felix Kaechele changed: What|Removed |Added Blocks||1194189 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1194189 [Bug 1194189] Review Request: ecdsautils - Tiny collection of programs used for ECDSA (keygen, sign, verify) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
