[Bug 1194628] Review Request: perl-Module-Metadata-Changes - Manage a module's machine-readable Changes/CHANGES file
https://bugzilla.redhat.com/show_bug.cgi?id=1194628 Patrick Uiterwijk puiterw...@redhat.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194628] Review Request: perl-Module-Metadata-Changes - Manage a module's machine-readable Changes/CHANGES file
https://bugzilla.redhat.com/show_bug.cgi?id=1194628 --- Comment #5 from Patrick Uiterwijk puiterw...@redhat.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194628] Review Request: perl-Module-Metadata-Changes - Manage a module's machine-readable Changes/CHANGES file
https://bugzilla.redhat.com/show_bug.cgi?id=1194628 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Module-Metadata-Change ||s-2.05-1.fc23 Resolution|--- |RAWHIDE Last Closed||2015-02-24 07:31:13 --- Comment #6 from Petr Pisar ppi...@redhat.com --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194628] Review Request: perl-Module-Metadata-Changes - Manage a module's machine-readable Changes/CHANGES file
https://bugzilla.redhat.com/show_bug.cgi?id=1194628
--- Comment #2 from Petr Pisar ppi...@redhat.com ---
(In reply to Petr Šabata from comment #1)
Note: All the patched files are read-only. I assume the patching could
fail, even though it currently doesn't. Perhaps making them writable before
patching would be a good idea.
I added this write permissions to the spec file. Updated package is on the same
address.
Ad Patch1 -- according to Web Assets guidelines, Fedora webservers provide
%{_webassetdir} in `/_sysassets', not `/.sysassets'. Please, correct the
patch.
This was a bug in guidelines and has been already corrected
https://fedoraproject.org/w/index.php?title=Packaging%3AWeb_Assetsaction=historysubmitdiff=404471oldid=350293.
The name with the dot is correct one.
Consider bumping the minimum required version of EU::MM to 6.76 and using
NO_PACKLIST to simplify the SPEC.
The convert.t test doesn't actually convert anything. Maybe you could
enhance it a bit? However, that's beyond the scope of this review.
I'm not much interested in this.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194628] Review Request: perl-Module-Metadata-Changes - Manage a module's machine-readable Changes/CHANGES file
https://bugzilla.redhat.com/show_bug.cgi?id=1194628 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Petr Pisar ppi...@redhat.com --- New Package SCM Request === Package Name: perl-Module-Metadata-Changes Short Description: Manage a module's machine-readable Changes/CHANGES file Upstream URL: http://search.cpan.org/dist/Module-Metadata-Changes/ Owners: ppisar jplesnik psabata Branches: InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194628] Review Request: perl-Module-Metadata-Changes - Manage a module's machine-readable Changes/CHANGES file
https://bugzilla.redhat.com/show_bug.cgi?id=1194628
Petr Šabata psab...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Šabata psab...@redhat.com ---
(In reply to Petr Pisar from comment #2)
(In reply to Petr Šabata from comment #1)
Note: All the patched files are read-only. I assume the patching could
fail, even though it currently doesn't. Perhaps making them writable before
patching would be a good idea.
I added this write permissions to the spec file. Updated package is on the
same address.
Ack.
Ad Patch1 -- according to Web Assets guidelines, Fedora webservers provide
%{_webassetdir} in `/_sysassets', not `/.sysassets'. Please, correct the
patch.
This was a bug in guidelines and has been already corrected
https://fedoraproject.org/w/index.
php?title=Packaging%3AWeb_Assetsaction=historysubmitdiff=404471oldid=35029
3. The name with the dot is correct one.
Fair enough.
Consider bumping the minimum required version of EU::MM to 6.76 and using
NO_PACKLIST to simplify the SPEC.
The convert.t test doesn't actually convert anything. Maybe you could
enhance it a bit? However, that's beyond the scope of this review.
I'm not much interested in this.
Okay then.
Approving.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194628] Review Request: perl-Module-Metadata-Changes - Manage a module's machine-readable Changes/CHANGES file
https://bugzilla.redhat.com/show_bug.cgi?id=1194628 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194628] Review Request: perl-Module-Metadata-Changes - Manage a module's machine-readable Changes/CHANGES file
https://bugzilla.redhat.com/show_bug.cgi?id=1194628
--- Comment #1 from Petr Šabata psab...@redhat.com ---
Note: All the patched files are read-only. I assume the patching could fail,
even though it currently doesn't. Perhaps making them writable before patching
would be a good idea.
Ad Patch1 -- according to Web Assets guidelines, Fedora webservers provide
%{_webassetdir} in `/_sysassets', not `/.sysassets'. Please, correct the
patch.
Consider bumping the minimum required version of EU::MM to 6.76 and using
NO_PACKLIST to simplify the SPEC.
The convert.t test doesn't actually convert anything. Maybe you could enhance
it a bit? However, that's beyond the scope of this review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
