[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-onetime-1.0.0-1.fc20 |nodejs-onetime-1.0.0-1.fc21 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- nodejs-onetime-1.0.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-onetime-1.0.0-1.fc22 |nodejs-onetime-1.0.0-1.fc20 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nodejs-onetime-1.0.0-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nodejs-onetime-1.0.0-1.fc22 Resolution|--- |ERRATA Last Closed||2015-03-13 13:04:01 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-onetime-1.0.0-1.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- nodejs-onetime-1.0.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/FEDORA-2015-3272/nodejs-onetime-1.0.0-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- nodejs-onetime-1.0.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/FEDORA-2015-3320/nodejs-onetime-1.0.0-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- nodejs-onetime-1.0.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/FEDORA-2015-3313/nodejs-onetime-1.0.0-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927
Gerard Ryan ger...@ryan.lt changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #4 from Gerard Ryan ger...@ryan.lt ---
(In reply to Piotr Popieluch from comment #3)
Hi Gerard,
Thank you for pointing me to the Github source URL guidelines, it never
occurred to me that those might exist.. I probably have a dozen of packages
using this incorrectly. I will check all my packages next weekend.
Yes, it's hard to remember all of the rules all the time...it's a good thing we
force ourselves to get our packages reviewed! :) I guess this particular one is
because the tags aren't necessarily immutable, but the commit hashes are.
I've updated the spec and srpm without a version bump.
Thank you for reviewing!
Thank you for packaging! It looks good to me now, so I'll approve it.
For any innocent bystanders, here's the diff of the spec file between the two
versions:
--- srpm/nodejs-onetime.spec2015-03-01 17:56:35.28500 +
+++ nodejs-onetime.spec2015-03-04 19:55:43.0 +
@@ -3,14 +3,15 @@
%global enable_tests 1
%global srcname onetime
+%global commit a4aa1ce5291cc5f32ecb8f4b0a918b12cb47ea5e
Name: nodejs-%{srcname}
Version:1.0.0
Release:1%{?dist}
Summary:Only call a function once
License:MIT
-URL:https://github.com/sindresorhus/onetime
-Source0:
https://github.com/sindresorhus/%{srcname}/archive/v%{version}/%{srcname}-%{version}.tar.gz
+URL:https://github.com/sindresorhus/%{srcname}
+Source0:
https://github.com/sindresorhus/%{srcname}/archive/%{commit}/%{srcname}-%{commit}.tar.gz
BuildArch: noarch
ExclusiveArch: %{nodejs_arches} noarch
@@ -28,7 +29,7 @@
%prep
-%setup -q -n %{srcname}-%{version}
+%setup -q -n %{srcname}-%{commit}
rm -rf node_modules/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Piotr Popieluch piotr1...@gmail.com --- Thank you for review! New Package SCM Request === Package Name: nodejs-onetime Short Description: Only call a function once Upstream URL: https://github.com/sindresorhus/onetime Owners: piotrp Branches: f20 f21 f22 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 --- Comment #3 from Piotr Popieluch piotr1...@gmail.com --- Hi Gerard, Thank you for pointing me to the Github source URL guidelines, it never occurred to me that those might exist.. I probably have a dozen of packages using this incorrectly. I will check all my packages next weekend. I've updated the spec and srpm without a version bump. Thank you for reviewing! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927
--- Comment #1 from Gerard Ryan ger...@ryan.lt ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Source0 URL doesn't follow specific guideline regarding Github source URLs.
Please see the following page for more information on making Github source
URLs:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github
Specifically, full commit hash is to be used instead of just %{version}.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 2 files have unknown license. Detailed output of
licensecheck in /home/grdryn/rawhide/1194927-nodejs-
onetime/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927
--- Comment #2 from Gerard Ryan ger...@ryan.lt ---
Hi Piotr,
I'll approve once the issue regarding Github source URL is fixed. I've probably
missed that in the other reviews for you. If so, please consider updating them
also! :)
Additionally, I think you can use %{srcname} in the URL line, the same way as
you're using it in the Source0 line.
Thanks,
Gerard.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Status|NEW |ASSIGNED CC||ger...@ryan.lt Assignee|nob...@fedoraproject.org|ger...@ryan.lt Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added Blocks||1194931 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1194931 [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
