[Bug 1196289] Review Request: nodejs-defaults - Merge single level defaults over a config object
https://bugzilla.redhat.com/show_bug.cgi?id=1196289 --- Comment #3 from Lubomir Rintel lkund...@v3.sk --- Also, there seems to be a test included, but the package lacks a %check section. Please add it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196289] Review Request: nodejs-defaults - Merge single level defaults over a config object
https://bugzilla.redhat.com/show_bug.cgi?id=1196289 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|NEW |ASSIGNED CC||lkund...@v3.sk Assignee|nob...@fedoraproject.org|lkund...@v3.sk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196289] Review Request: nodejs-defaults - Merge single level defaults over a config object
https://bugzilla.redhat.com/show_bug.cgi?id=1196289
--- Comment #1 from Lubomir Rintel lkund...@v3.sk ---
Summary:A simple one level options merge utility
This is a pretty bad summary; there's no way a user would be able to tell if
they need this or not. It's also not an utility, its a library.
Group: Development/Languages/Other
No souch group exist. Please drop the tag altogether or pick a suitable
library from /usr/share/doc/rpm/GROUPS
BuildRoot: %{_tmppath}/%{pkg_name}-%{version}-build
Not needed anymore unless you're building for el5.
ExclusiveArch: %{ix86} x86_64 %{arm} noarch
You can use %{nodejs_arches}, unless you're building for el5.
#%{nodejs_find_provides_and_requires}
This doesn't look right, is that intentional? Note that macro expansion happens
before parsing comments.
%description
Merge single level defaults over a config object.
This needs improvement, it seems to make very little sense.
%prep
%setup -q -n package
%build
Please keep spacing consistent (add a line break before %build).
%defattr(-,root,root,-)
Not needed for post-el5.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196289] Review Request: nodejs-defaults - Merge single level defaults over a config object
https://bugzilla.redhat.com/show_bug.cgi?id=1196289 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Flags||fedora-review? --- Comment #2 from Lubomir Rintel lkund...@v3.sk --- * Package named properly * Version correct - License? How can you tell it's MIT? There's no license text included altogether and MIT license specifically requires the source to be distributed with the copy of the license. Please contact upstream and ask them to fix the issue. * Builds fine in mock * Filelist sane * Requires sane * Provides sane - rpmlint unhappy Essentially complains about what has been pointed out above -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196289] Review Request: nodejs-defaults - Merge single level defaults over a config object
https://bugzilla.redhat.com/show_bug.cgi?id=1196289 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added CC||piotr1...@gmail.com Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196289] Review Request: nodejs-defaults - Merge single level defaults over a config object
https://bugzilla.redhat.com/show_bug.cgi?id=1196289 Zuzana Svetlikova zsvet...@redhat.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
