[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-wcwidth-1.0.0-5.fc22 |nodejs-wcwidth-1.0.0-6.fc21 --- Comment #14 from Fedora Update System --- nodejs-wcwidth-1.0.0-6.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-wcwidth-1.0.0-5.fc22 Resolution|NEXTRELEASE |ERRATA --- Comment #13 from Fedora Update System --- nodejs-wcwidth-1.0.0-5.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 --- Comment #12 from Fedora Update System --- nodejs-wcwidth-1.0.0-5.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/nodejs-wcwidth-1.0.0-5.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 --- Comment #11 from Fedora Update System --- nodejs-wcwidth-1.0.0-6.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-wcwidth-1.0.0-6.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 Zuzana Svetlikova changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 --- Comment #9 from Zuzana Svetlikova --- New Package SCM Request === Package Name: nodejs-wcwidth Short Description: Port of C's wcwidth() and wcswidth() Upstream URL: https://www.npmjs.com/package/wcwidth Owners: zvetlik Branches: el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 Lubomir Rintel changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||lkund...@v3.sk Resolution|--- |NEXTRELEASE Last Closed||2015-04-20 12:07:13 --- Comment #8 from Lubomir Rintel --- Built into f23 it seems... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 Bug 1196290 depends on bug 1196289, which changed state. Bug 1196289 Summary: Review Request: nodejs-defaults - A simple one level options merge utility https://bugzilla.redhat.com/show_bug.cgi?id=1196289 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 Zuzana Svetlikova changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Zuzana Svetlikova --- URL fixed New Package SCM Request === Package Name: nodejs-wcwidth Short Description: Port of C's wcwidth() and wcswidth() Upstream URL: https://www.npmjs.com/package/wcwidth Owners: zvetlik humaton Branches: f20 f21 f22 InitialCC: humaton -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290
Piotr Popieluch changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|piotr1...@gmail.com
Flags||fedora-review+
--- Comment #5 from Piotr Popieluch ---
APPROVED,
There is one issue which you can fix before importing:
nodejs-wcwidth.noarch: W: invalid-url URL: https://github.com/isaacs/wcwidth
HTTP Error 404: Not Found
Url:https://github.com/isaacs/wcwidth
You can use:
Url:https://www.npmjs.com/package/wcwidth
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 3 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1196290-nodejs-
wcwidth/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Sour
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 Zuzana Svetlikova changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 Zuzana Svetlikova changed: What|Removed |Added Blocks|956806 (nodejs-reviews) |1203659 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1203659 [Bug 1203659] Review Request: nodejs-columnify - Render data in text columns, supports in-column text-wrap. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 --- Comment #4 from Zuzana Svetlikova --- Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-wcwidth/nodejs-wcwidth.spec SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-wcwidth/nodejs-wcwidth-1.0.0-5.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290
Piotr Popieluch changed:
What|Removed |Added
Depends On||1196289
--- Comment #3 from Piotr Popieluch ---
You should add npm(defaults) to the BR needed for tests.
%if 0%{enable_tests}
BuildRequires: npm(tape)
BuildRequires: npm(defaults)
%endif
spec file in srpm differs from spec file from url. Could you please rebuild the
srpm with the correct specfile?
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1196289
[Bug 1196289] Review Request: nodejs-defaults - A simple one level options
merge utility
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196290] Review Request: nodejs-wcwidth - Port of C's wcwidth() and wcswidth()
https://bugzilla.redhat.com/show_bug.cgi?id=1196290 Zuzana Svetlikova changed: What|Removed |Added Summary|Review Request: |Review Request: |nodejs-wcwidth - Determine |nodejs-wcwidth - Port of |columns needed for a|C's wcwidth() and |fixed-size wide-character |wcswidth() |string | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
