[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Raphael Groner  changed:

   What|Removed |Added

 Depends On|1006197 |



--- Comment #29 from Raphael Groner  ---
*** Bug 1006197 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1006197
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Raphael Groner  changed:

   What|Removed |Added

 Depends On|1197333 (polyglot)  |
   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1197333




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1197333
[Bug 1197333] Review Request: polyglot-chess - Polyglot chess opening book
program
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|stockfish-7-0.3.20150506git |stockfish-7-0.3.20150506git
   |2e86d1f.fc22|2e86d1f.fc21



--- Comment #28 from Fedora Update System upda...@fedoraproject.org ---
stockfish-7-0.3.20150506git2e86d1f.fc21 has been pushed to the Fedora 21 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|stockfish-6-4.20150228git1e |stockfish-7-0.3.20150506git
   |6d21d.fc21  |2e86d1f.fc22



--- Comment #27 from Fedora Update System upda...@fedoraproject.org ---
stockfish-7-0.3.20150506git2e86d1f.fc22 has been pushed to the Fedora 22 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #26 from Fedora Update System upda...@fedoraproject.org ---
stockfish-7-0.3.20150506git2e86d1f.fc21 has been submitted as an update for
Fedora 21.
https://admin.fedoraproject.org/updates/stockfish-7-0.3.20150506git2e86d1f.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #25 from Fedora Update System upda...@fedoraproject.org ---
stockfish-7-0.3.20150506git2e86d1f.fc22 has been submitted as an update for
Fedora 22.
https://admin.fedoraproject.org/updates/stockfish-7-0.3.20150506git2e86d1f.fc22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|stockfish-7-0.1.20150302git |stockfish-6-4.20150228git1e
   |cb2111f.fc22|6d21d.fc21



--- Comment #24 from Fedora Update System upda...@fedoraproject.org ---
stockfish-6-4.20150228git1e6d21d.fc21 has been pushed to the Fedora 21 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||stockfish-7-0.1.20150302git
   ||cb2111f.fc22
 Resolution|--- |ERRATA
Last Closed||2015-03-09 04:27:15



--- Comment #23 from Fedora Update System upda...@fedoraproject.org ---
stockfish-7-0.1.20150302gitcb2111f.fc22 has been pushed to the Fedora 22 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #22 from Fedora Update System upda...@fedoraproject.org ---
stockfish-7-0.1.20150302gitcb2111f.fc22 has been pushed to the Fedora 22
testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #20 from Raphael Groner projects...@smart.ms ---
f20 and epel7 builds could be found at Copr:
http://copr.fedoraproject.org/coprs/raphgro/playground/build/80159/

If requested, I can do also an official update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #18 from Fedora Update System upda...@fedoraproject.org ---
stockfish-6-4.20150228git1e6d21d.fc21 has been submitted as an update for
Fedora 21.
https://admin.fedoraproject.org/updates/stockfish-6-4.20150228git1e6d21d.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #19 from Fedora Update System upda...@fedoraproject.org ---
stockfish-7-0.1.20150302gitcb2111f.fc22 has been submitted as an update for
Fedora 22.
https://admin.fedoraproject.org/updates/stockfish-7-0.1.20150302gitcb2111f.fc22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #21 from Raphael Groner projects...@smart.ms ---
Newer versions for f20, f21 and epel7 could be found at Copr:
http://copr.fedoraproject.org/coprs/raphgro/playground/build/80159/

If requested, I can do official updates, too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #17 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-cvs?



--- Comment #16 from Raphael Groner projects...@smart.ms ---
New Package SCM Request
===
Package Name: stockfish
Short Description: Powerful open source chess engine
Upstream URL: http://www.stockfishchess.com
Owners: raphgro
Branches: f21 f22
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Christian Dersch lupi...@mailbox.org changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #15 from Christian Dersch lupi...@mailbox.org ---
Approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #14 from Raphael Groner projects...@smart.ms ---
SPEC: https://raphgro.fedorapeople.org/review/chess/stockfish/stockfish.spec
SRPM:
https://raphgro.fedorapeople.org/review/chess/stockfish/stockfish-6-4.20150228git1e6d21d.fc21.src.rpm

rawhide scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=9122664

* Mon Mar 02 2015 Raphael Groner projects...@smart.ms -
6-4.20150228git1e6d21d
- fix Release dist extension
- fix ownership of etc/
- add Suggests: polyglot-chess (rhbz#1197333)

Christian, thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #13 from Christian Dersch lupi...@mailbox.org ---
Review done :) Package looks quite good now, especially the fixed usage of
compilerflags and the -debuginfo is fine now thanks to your cmake approach. But
there is one thing you have to fix before I can approve: 
* Fix the ownership of dir /etc/stockfish


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find Copying.txt in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

* False positive, package uses %license macro as recommended now


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 GPL (v3 or later), Unknown or generated. 4 files have unknown
 license. Detailed output of licensecheck in
 /home/review/1196373-stockfish/licensecheck.txt
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /etc/stockfish

* Please fix this!

[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/stockfish

* Same here

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.

* Thank you for the cmake approach

[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Sources can be downloaded from URI in Source: tag
 Note: Could not download Source1: https://raw.githubusercontent.com
 /official-stockfish/Stockfish/master/AUTHORS#/stockfish-AUTHORS, Source4:
 https://raw.githubusercontent.com/mpurland/stockfish/master/polyglot.ini
 #/stockfish-polyglot.ini
 See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

External Bug ID|GNU Compiler Collection |
   |62099   |



--- Comment #12 from Raphael Groner projects...@smart.ms ---
SPEC: https://raphgro.fedorapeople.org/review/chess/stockfish/stockfish.spec
SRPM:
https://raphgro.fedorapeople.org/review/chess/stockfish/stockfish-6-3.20150228git1e6d21d.fc21.src.rpm

rawhide scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=9109620

Well, cmake was too easy to implement, maybe for upstream also but refused my
patch for unknown reason. Chapeau to cmake!

GCC5 bug is magically gone, dunno why.

* Sun Mar 01 2015 Raphael Groner projects...@smart.ms -
6-3.20150228git1e6d21d
- implement cmake
- harden gcc5
- latest commit from upstream

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Depends On|1197370 |



--- Comment #11 from Raphael Groner projects...@smart.ms ---
(In reply to Raphael Groner from comment #10)
 …  we need cmake support in leveldb …

NO! This is wrong. Confused with polyglot, sorry for that noise.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1197370
[Bug 1197370] RFE: support for cmake
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #7 from Raphael Groner projects...@smart.ms ---
Spec URL:
https://raphgro.fedorapeople.org/review/chess/stockfish/stockfish.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/chess/stockfish/stockfish-6-2.20150226git8a2c413.fc21.src.rpm

rawhide scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=9100110

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Blocks||1197333 (polyglot)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1197333
[Bug 1197333] Review Request: polyglot-chess -
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #5 from Raphael Groner projects...@smart.ms ---
Notes:
- Upstream has also a newer c++ branch. Maybe we should try that one?
- GitHub seems to be slow nowadays. Try the links more than once, otherwise you
will get warnings about 404 or the like.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

External Bug ID||GNU Compiler Collection
   ||62099
   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=62099



--- Comment #8 from Raphael Groner projects...@smart.ms ---
It seems we are hitting this bug with official-stockfish:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62099

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

URL||http://stockfishchess.org
 Blocks|1197333 (polyglot)  |
  Alias||stockfish




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1197333
[Bug 1197333] Review Request: polyglot-chess -
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Depends On||1197333 (polyglot)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1197333
[Bug 1197333] Review Request: polyglot-chess -
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #6 from Raphael Groner projects...@smart.ms ---
(In reply to Raphael Groner from comment #5)
- Upstream has also a newer c++11 branch. Maybe we should try that one?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Depends On||1197370



--- Comment #10 from Raphael Groner projects...@smart.ms ---
Okay, I'll implement cmake. For that, we need cmake support in leveldb, see bug
#1197370.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1197370
[Bug 1197370] RFE: support for cmake
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #9 from Christian Dersch lupi...@mailbox.org ---
Makefile strongly ignores Fedoras compiler flags, so imho it violates
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags 

Please fix (try to cooperate with upstream) this before we can go on with the
review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Christian Dersch lupi...@mailbox.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lupi...@mailbox.org
   Assignee|nob...@fedoraproject.org|lupi...@mailbox.org
  Flags||fedora-review?



--- Comment #2 from Christian Dersch lupi...@mailbox.org ---
Taken :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #3 from Christian Dersch lupi...@mailbox.org ---
Prior to review some questions and notes:
* Are you sure, that you're packaging the correct stockfish? You're using the
git from mcostalba. The git mentioned on stockfish homepage is
https://github.com/official-stockfish/Stockfish 

* Are there problems with the official release 6 or why are you packaging the
snapshot?

* In my first run of fedora-review I got WARNING: Cannot download url:
https://raw.githubusercontent.com/official-stockfish/Stockfish/master/AUTHORS#/stockfish-AUTHORS

* I haven't looked into detail yet, but it seems that the Makefile doesn't
honor the compiler flags. Result: -debuginfo package looks wrong, for example
no source inside.

Greetings,
Christian

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #4 from Raphael Groner projects...@smart.ms ---
(In reply to Christian Dersch from comment #3)
 Prior to review some questions and notes:
 * Are you sure, that you're packaging the correct stockfish? You're using
 the git from mcostalba. The git mentioned on stockfish homepage is
 https://github.com/official-stockfish/Stockfish 

Honestly, I do not know. There are currently 405 forks available ...
https://github.com/official-stockfish/Stockfish/network

 * Are there problems with the official release 6 or why are you packaging
 the snapshot?

See above. The mcostalba branch was in the original review (bug #1006197).

 * In my first run of fedora-review I got WARNING: Cannot download url:
 https://raw.githubusercontent.com/official-stockfish/Stockfish/master/
 AUTHORS#/stockfish-AUTHORS

This seems to be a generated file and must be accessed manually. Maybe github
blocks bots for this.

 * I haven't looked into detail yet, but it seems that the Makefile doesn't
 honor the compiler flags. Result: -debuginfo package looks wrong, for
 example no source inside.

Well, then we should implement our own build system, maybe cmake or
ninja/Shinobi?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=820796



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1196373] Review Request: stockfish - Powerful open source chess engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196373

Raphael Groner projects...@smart.ms changed:

   What|Removed |Added

 Blocks|201449 (FE-DEADREVIEW)  |



--- Comment #1 from Raphael Groner projects...@smart.ms ---
Spec URL:
https://raphgro.fedorapeople.org/review/chess/stockfish/stockfish.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/chess/stockfish/stockfish-6-1.20150131gitb331768.fc21.src.rpm
Description: Powerful open source chess engine
Fedora Account System Username: raphgro

rawhide scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=9075402


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review