[Bug 1196780] Review Request: openrpt - reporting tool for xTuple / PostBooks
https://bugzilla.redhat.com/show_bug.cgi?id=1196780 --- Comment #3 from Gil Moskowitz --- https://github.com/xtuple/openrpt/pull/49 addressing review comments has been merged -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196780] Review Request: openrpt - reporting tool for xTuple / PostBooks
https://bugzilla.redhat.com/show_bug.cgi?id=1196780
--- Comment #2 from Zbigniew Jędrzejewski-Szmek ---
fedora-review has the following to say:
- Permissions on files are set properly.
Note: See rpmlint output
See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in
/var/tmp/1196780-openrpt/diff.txt
See: http://fedoraproject.org/wiki/Packaging/SourceURL
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
- Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see
attached diff).
See: (this test has no URL)
openrpt-devel.x86_64: W: spurious-executable-perm /usr/include/openrpt/**.h
openrpt-devel.x86_64: E: wrong-script-end-of-line-encoding
/usr/include/openrpt/OpenRPT/wrtembed/tmp/ui_texteditor.h
openrpt-devel.x86_64: E: wrong-script-end-of-line-encoding
/usr/include/openrpt/OpenRPT/wrtembed/tmp/ui_crosstabeditor.h
openrpt.src:47: W: macro-in-comment %{buildroot}
openrpt.src: W: file-size-mismatch v3.3.7.tar.gz = 1218978,
https://github.com/xtuple/openrpt/archive/v3.3.7.tar.gz = 1198328
openrpt-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libopenrptcommon.so.1.0.0 /lib64/libpthread.so.0
openrpt-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libopenrptcommon.so.1.0.0 /lib64/libm.so.6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196780] Review Request: openrpt - reporting tool for xTuple / PostBooks
https://bugzilla.redhat.com/show_bug.cgi?id=1196780
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zbys...@in.waw.pl
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
Flags||fedora-review?
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
# make install doesn't do anything for this qmake project so we do
# the installs manually
#make INSTALL_ROOT=%{buildroot} install
rm -f %{buildroot}%{_libdir}/lib*.a
rm -f %{buildroot}%{_libdir}/lib*.la
^^^ this looks like an oversight, presumably there's nothing to delete yet.
Why is ldconfig in %post needed for the main package?
%clean can probably be dropped.
Use %license for COPYING
(https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text).
Suggestion: use the name of the main package for docs and license dirs:
%global _docdir_fmt %{name}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196780] Review Request: openrpt - reporting tool for xTuple / PostBooks
https://bugzilla.redhat.com/show_bug.cgi?id=1196780 Daniel Pocock changed: What|Removed |Added Blocks||1196827 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1196827 [Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196780] Review Request: openrpt - reporting tool for xTuple / PostBooks
https://bugzilla.redhat.com/show_bug.cgi?id=1196780 Daniel Pocock changed: What|Removed |Added Blocks||1196782 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1196782 [Bug 1196782] Review Request: csvimp - xTuple / PostBooks data import utility -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
