[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-grunt-contrib-requir |nodejs-grunt-contrib-requir |ejs-0.4.4-1.fc21|ejs-0.4.4-1.el7 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-contrib-requirejs-0.4.4-1.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-grunt-contrib-requir |nodejs-grunt-contrib-requir |ejs-0.4.4-1.fc20|ejs-0.4.4-1.fc21 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-contrib-requirejs-0.4.4-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-grunt-contrib-requir |nodejs-grunt-contrib-requir |ejs-0.4.4-1.fc22|ejs-0.4.4-1.fc20 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-contrib-requirejs-0.4.4-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nodejs-grunt-contrib-requir ||ejs-0.4.4-1.fc22 Resolution|--- |ERRATA Last Closed||2015-03-09 04:26:20 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-contrib-requirejs-0.4.4-1.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-contrib-requirejs-0.4.4-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-contrib-requirejs-0.4.4-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-grunt-contrib-requirejs-0.4.4-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-contrib-requirejs-0.4.4-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/nodejs-grunt-contrib-requirejs-0.4.4-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-contrib-requirejs-0.4.4-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-grunt-contrib-requirejs-0.4.4-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265
Gerard Ryan ger...@ryan.lt changed:
What|Removed |Added
Status|NEW |POST
CC||ger...@ryan.lt
Assignee|nob...@fedoraproject.org|ger...@ryan.lt
Flags||fedora-review+
--- Comment #1 from Gerard Ryan ger...@ryan.lt ---
Approved. Thanks for packaging!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- [!]: Package consistently uses macros (instead of hard-coded
directory names).
URL and Source0 could use %{srcname} - not a huge deal, just
something to consider.
- [!]: %check is present and all tests pass.
Note: tests disabled with acceptable comment - not an issue
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 6 files have unknown license. Detailed output of
licensecheck in /home/grdryn/1197265-nodejs-grunt-contrib-
requirejs/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
Note: tests disabled with acceptable comment
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Piotr Popieluch piotr1...@gmail.com --- Thank you for review! New Package SCM Request === Package Name: nodejs-grunt-contrib-requirejs Short Description: Optimize RequireJS projects using r.js Upstream URL: https://github.com/gruntjs/grunt-contrib-requirejs Owners: piotrp Branches: f20 f21 f22 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-contrib-requirejs-0.4.4-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-grunt-contrib-requirejs-0.4.4-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197265] Review Request: nodejs-grunt-contrib-requirejs - Optimize RequireJS projects using r.js
https://bugzilla.redhat.com/show_bug.cgi?id=1197265 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
