[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 Jonathan Underwood changed: What|Removed |Added Blocks||1243530 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1243530 [Bug 1243530] Review Request: winswitch - A tool which allows you to display running applications on other computers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 Fedora Update System changed: What|Removed |Added Fixed In Version|js-web-socket-js-1.0.2-3.fc |js-web-socket-js-1.0.2-3.fc |21 |20 --- Comment #41 from Fedora Update System --- js-web-socket-js-1.0.2-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 Fedora Update System changed: What|Removed |Added Fixed In Version|js-web-socket-js-1.0.2-3.fc |js-web-socket-js-1.0.2-3.fc |22 |21 --- Comment #40 from Fedora Update System --- js-web-socket-js-1.0.2-3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||js-web-socket-js-1.0.2-3.fc ||22 Resolution|--- |ERRATA Last Closed||2015-04-21 14:49:49 --- Comment #39 from Fedora Update System --- js-web-socket-js-1.0.2-3.fc22, xpra-0.14.21-3.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #38 from Fedora Update System --- xpra-0.14.21-3.fc20, js-web-socket-js-1.0.2-3.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #37 from Fedora Update System --- xpra-0.14.21-3.fc20,js-web-socket-js-1.0.2-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/xpra-0.14.21-3.fc20,js-web-socket-js-1.0.2-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #36 from Fedora Update System --- xpra-0.14.21-3.fc21,js-web-socket-js-1.0.2-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/xpra-0.14.21-3.fc21,js-web-socket-js-1.0.2-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #35 from Fedora Update System --- js-web-socket-js-1.0.2-3.fc22,xpra-0.14.21-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/js-web-socket-js-1.0.2-3.fc22,xpra-0.14.21-3.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #34 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 Jonathan Underwood changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #33 from Jonathan Underwood --- New Package SCM Request === Package Name: xpra Short Description: Remote display server for applications and desktops Upstream URL: https://www.xpra.org/ Owners: jgu Branches: f20 f21 f22 InitialCC: jgu -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #32 from Jonathan Underwood --- Many thanks @tchollingsworth - I think it's fair to say you did the hard work for this package! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 T.C. Hollingsworth changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #31 from T.C. Hollingsworth --- This package is APPROVED. Thank you for your contribution to Fedora! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312
--- Comment #30 from T.C. Hollingsworth ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
All blocking issues have been addressed!
TODO Post Review:
=
- Work with upstream to resolve the issue with resizing in GNOME Shell.
- Work on enabling OpenCL CSC support if possible.
= MUST items =
C/C++:
[X]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "LGPL
(v3 or later)", "BSD (2 clause)", "*No copyright* MIT/X11 (BSD like)".
418 files have unknown license. Detailed output of licensecheck in
/var/tmp/1198312-xpra/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in xpra
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in xpra
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 112640 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #29 from Jonathan Underwood --- SPEC: https://jgu.fedorapeople.org/xpra.spec SRPM: https://jgu.fedorapeople.org/xpra-0.14.21-3.fc20.src.rpm * Tue Mar 24 2015 Jonathan G. Underwood - 0.14.21-3 - Update license tag from GPLv2+ to GPLv2+ and BSD and LGPLv3+ and MIT Updated license tag following running fedora-review. All else seems OK as far as I can see. Hopefully we're about good to go. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - Remote display server for applications and desktops
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 Jonathan Underwood changed: What|Removed |Added Summary|Review Request: xpra - |Review Request: xpra - |screen for X|Remote display server for ||applications and desktops -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
