[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Bug 1198760 depends on bug 1236249, which changed state. Bug 1236249 Summary: Bluefish contains bundled python library jsbeautifier and others https://bugzilla.redhat.com/show_bug.cgi?id=1236249 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Fabian Affolter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |WONTFIX Flags|needinfo?(mail@fabian-affol | |ter.ch) | Last Closed||2019-05-12 16:13:13 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added CC||domi...@greysector.net --- Comment #17 from Dominik 'Rathann' Mierzejewski --- There's version 4.0.4 out and 5.0.0 is in development. I found myself in need of this package, so I'm preparing one and will open a new review bug when done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Michal Ambroz changed: What|Removed |Added Assignee|re...@seznam.cz |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 --- Comment #16 from Michal Ambroz --- Hello - I am stepping down from the review of this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 --- Comment #15 from Andrea Musuruane --- Latest version is 2.0.2. Pyamf support is optional: https://github.com/mitmproxy/mitmproxy/pull/62 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Bug 1198760 depends on bug 1249010, which changed state. Bug 1249010 Summary: the package nodejs-js-beautify doesn't pack the python library from the same source code https://bugzilla.redhat.com/show_bug.cgi?id=1249010 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |EOL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Michal Ambroz changed: What|Removed |Added Flags||needinfo?(mail@fabian-affol ||ter.ch) --- Comment #14 from Michal Ambroz --- Latest version is 0.18.2 Pyamf package still not available in Fedora -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Alex changed: What|Removed |Added CC||abco...@gmail.com --- Comment #13 from Alex --- One of the install-time dependencies for the built package is 'pyamf', but this doesn't seem to be available in any F23 repo I can find.. any clues? Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 --- Comment #12 from Fabian Affolter --- Just update for the latest release. %changelog * Sun Jan 24 2016 Fabian Affolter - 0.15-1 - Update to latest upstream release 0.15 Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/mitmproxy.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/mitmproxy-0.15-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Dusty Mabe changed: What|Removed |Added CC||dustym...@redhat.com --- Comment #11 from Dusty Mabe --- +1 Would love to have this packaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Fabian Affolter changed: What|Removed |Added Flags|needinfo?(mail@fabian-affol | |ter.ch) | --- Comment #10 from Fabian Affolter --- Still shipping the third-party stuff... %changelog * Fri Oct 30 2015 Fabian Affolter - 0.13-1 - Update macros - Update to latest upstream release 0.13 Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/mitmproxy.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/mitmproxy-0.13-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Michal Ambroz changed: What|Removed |Added Flags||needinfo?(mail@fabian-affol ||ter.ch) --- Comment #9 from Michal Ambroz --- Ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Bug 1198760 depends on bug 1249010, which changed state. Bug 1249010 Summary: the package nodejs-js-beautify doesn't pack the python library from the same source code https://bugzilla.redhat.com/show_bug.cgi?id=1249010 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|NOTABUG |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Bug 1198760 depends on bug 1249010, which changed state. Bug 1249010 Summary: the package nodejs-js-beautify doesn't pack the python library from the same source code https://bugzilla.redhat.com/show_bug.cgi?id=1249010 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 --- Comment #8 from Michal Ambroz --- js-beautify code is currently packaged in nodejs-js-beautify, but the package doesn't provide currently the python bindings. I created bug 1249010 for that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Michal Ambroz changed: What|Removed |Added Depends On||1249010 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1249010 [Bug 1249010] the package nodejs-js-beautify doesn't pack the python library from the same source code -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Fabian Affolter changed: What|Removed |Added Flags|needinfo?(mail@fabian-affol | |ter.ch) | --- Comment #7 from Fabian Affolter --- Thanks for all your work. I'm a bit busy right now but I will work on this as soon as possible. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Michal Ambroz changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@fabian-affolter.ch Flags||needinfo?(mail@fabian-affol ||ter.ch) --- Comment #6 from Michal Ambroz --- Ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Michal Ambroz changed: What|Removed |Added Depends On||1236249 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1236249 [Bug 1236249] Bluefish contains bundled python library jsbeautifier and others -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 --- Comment #5 from Michal Ambroz --- Hello, generaly most of the checks are OK. I have identified these issues: 1) Licenses/budled libraries Package contains bundled libraries. I believe that html2text is problem even from the licensing point of view. My recommendation is to: - unbundle html2text and pyparsig - which already have separate package - agree with bluefish maintainer on unbundling js-beautify/jsbeautifier - tneststring and wbxml - it would be probably best to ask mitmproxy author on what would be the effort needed to unbundle those 2) Source checksums - when checking the MD5 I have noticed that source on github and upstream website are different. Packages seems to be same, but probably repacked on different platform. - Please can you inform the upstream about this issue? 3) Man pages - this falls to the "should" not must category so it would not be blocking the package approval. - Please any chance getting the man-pages from the Debian package and try to push it upstream? Best regards Michal Ambroz Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. - MIT [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 114 files have unknown license. - BSD - for example libmproxy/web/static/vendor.js - GPLv3 - libmproxy/contrib/html2text.py [!]: Package contains no bundled libraries without FPC exception. - pyparsing /usr/lib/python2.7/site-packages/libmproxy/contrib/pyparsing.py - there is already package pyparsing - GPLv3 - libmproxy/contrib/html2text.py - https://github.com/aaronsw/html2text - there is already package python-html2text - MITM - jsbeautifier - https://github.com/beautify-web/js-beautify - part of bluefish-shared-data package (probably issue there as well) - libmproxy/tnetstring.py - https://github.com/rfk/tnetstring - wbxml - libmproxy/contrib/wbxml - https://github.com/davidpshaw/PyWBXMLDecoder [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 25 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 --- Comment #4 from Fabian Affolter --- (In reply to Michal Ambroz from comment #3) > any reason why the source is taken from 3rd party (pypi.python.org) No reason. I will go with the tarball from the upstream website. At the moment from my point of view there is no meed to run with the git source. Anyway, thanks for the input. Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/mitmproxy.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/mitmproxy-0.12.1-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 --- Comment #3 from Michal Ambroz --- Hello Fabian, any reason why the source is taken from 3rd party (pypi.python.org) and not from the release on the pages (https://mitmproxy.org/download/mitmproxy-0.12.1.tar.gz) or directly from their github (https://github.com/mitmproxy/mitmproxy/archive/946fd375fa87fb8a4d071a354fb99840b0ccfdf3/mitmproxy-0.12.1-946fd375.tar.gz) Personally I would recommend taking directly from github: https://github.com/mitmproxy/mitmproxy/releases %global gituser mitmproxy %global gitname mitmproxy %global commit 946fd375fa87fb8a4d071a354fb99840b0ccfdf3 %global shortcommit %(c=%{commit}; echo ${c:0:7}) Source0: https://github.com/%{gituser}/%{gitname}/archive/%{commit}/%{name}-%{version}-%{shortcommit}.tar.gz %setup -qn %{gitname}-%{commit} Best regards Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Michal Ambroz changed: What|Removed |Added CC||re...@seznam.cz Assignee|nob...@fedoraproject.org|re...@seznam.cz Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 --- Comment #2 from Fabian Affolter --- %changelog * Wed Jun 03 2015 Fabian Affolter - 0.12.1-1 - Update to latest upstream release 0.12.1 Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/mitmproxy.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/mitmproxy-0.12.1-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Fabian Affolter changed: What|Removed |Added Blocks||563471 (FE-SECLAB) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Fabian Affolter changed: What|Removed |Added Alias||mitmproxy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Fabian Affolter changed: What|Removed |Added CC||dh...@openwall.com --- Comment #1 from Fabian Affolter --- *** Bug 1070418 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review