[Bug 1199841] Review Request: jackson-dataformat-csv - Jackson extension for adding support for reading and writing CSV formatted data
https://bugzilla.redhat.com/show_bug.cgi?id=1199841 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jackson-dataformat-csv-2.5. ||0-1.fc22 Resolution|--- |ERRATA Last Closed||2015-04-21 14:38:51 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- jackson-dataformat-csv-2.5.0-1.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1199841] Review Request: jackson-dataformat-csv - Jackson extension for adding support for reading and writing CSV formatted data
https://bugzilla.redhat.com/show_bug.cgi?id=1199841 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- jackson-dataformat-csv-2.5.0-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1199841] Review Request: jackson-dataformat-csv - Jackson extension for adding support for reading and writing CSV formatted data
https://bugzilla.redhat.com/show_bug.cgi?id=1199841 --- Comment #6 from Patrick Uiterwijk puiterw...@redhat.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1199841] Review Request: jackson-dataformat-csv - Jackson extension for adding support for reading and writing CSV formatted data
https://bugzilla.redhat.com/show_bug.cgi?id=1199841 Patrick Uiterwijk puiterw...@redhat.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1199841] Review Request: jackson-dataformat-csv - Jackson extension for adding support for reading and writing CSV formatted data
https://bugzilla.redhat.com/show_bug.cgi?id=1199841 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- jackson-dataformat-csv-2.5.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/jackson-dataformat-csv-2.5.0-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1199841] Review Request: jackson-dataformat-csv - Jackson extension for adding support for reading and writing CSV formatted data
https://bugzilla.redhat.com/show_bug.cgi?id=1199841 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1199841] Review Request: jackson-dataformat-csv - Jackson extension for adding support for reading and writing CSV formatted data
https://bugzilla.redhat.com/show_bug.cgi?id=1199841 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from gil cattaneo punto...@libero.it --- (In reply to Piotr Popieluch from comment #4) Issues: === [!]: Latest version is packaged. Please update to 2.5.1 need uograde all jackson packages Github sources should contain commit hashes: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/ SourceURL#Github Sure,i hope not to forget Thanks! New Package SCM Request === Package Name: jackson-dataformat-csv Short Description: Jackson extension for adding support for reading and writing CSV formatted data Upstream URL: http://wiki.fasterxml.com/JacksonExtensionCSV Owners: gil Branches: f22 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1199841] Review Request: jackson-dataformat-csv - Jackson extension for adding support for reading and writing CSV formatted data
https://bugzilla.redhat.com/show_bug.cgi?id=1199841 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added CC||piotr1...@gmail.com Assignee|nob...@fedoraproject.org|piotr1...@gmail.com --- Comment #2 from Piotr Popieluch piotr1...@gmail.com --- SRPM invalid link, this should be better: Spec URL: https://gil.fedorapeople.org/jackson-dataformat-csv.spec SRPM URL: https://gil.fedorapeople.org/jackson-dataformat-csv-2.5.0-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1199841] Review Request: jackson-dataformat-csv - Jackson extension for adding support for reading and writing CSV formatted data
https://bugzilla.redhat.com/show_bug.cgi?id=1199841 --- Comment #3 from gil cattaneo punto...@libero.it --- sorry ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1199841] Review Request: jackson-dataformat-csv - Jackson extension for adding support for reading and writing CSV formatted data
https://bugzilla.redhat.com/show_bug.cgi?id=1199841
Piotr Popieluch piotr1...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags||fedora-review+
--- Comment #4 from Piotr Popieluch piotr1...@gmail.com ---
Looks good APPROVED, some minor issues which you can fix before importing.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
Note: Cannot find LICENSE in rpm(s)
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
IGNORE this one
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jackson-
dataformat-csv-javadoc
I think this can be ignored for doc packages
[!]: Latest version is packaged.
Please update to 2.5.1
[!]: Package does not include license text files separate from upstream.
License is requested, thanks for that!
Github sources should contain commit hashes:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 50 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1199841-jackson-dataformat-
csv/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed
[Bug 1199841] Review Request: jackson-dataformat-csv - Jackson extension for adding support for reading and writing CSV formatted data
https://bugzilla.redhat.com/show_bug.cgi?id=1199841 --- Comment #1 from gil cattaneo punto...@libero.it --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9341193 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1199841] Review Request: jackson-dataformat-csv - Jackson extension for adding support for reading and writing CSV formatted data
https://bugzilla.redhat.com/show_bug.cgi?id=1199841 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1199843 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1199843 [Bug 1199843] restlet-jse-2.3.1 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
