[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Bug 1200520 depends on bug 1200955, which changed state. Bug 1200955 Summary: Review Request: python-wrapt - A Python module for decorators, wrappers and monkey patching https://bugzilla.redhat.com/show_bug.cgi?id=1200955 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-debtcollector-0.3.0- ||3.fc22 Resolution|--- |ERRATA Last Closed||2015-06-05 19:39:43 --- Comment #14 from Fedora Update System --- python-debtcollector-0.3.0-3.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- python-debtcollector-0.3.0-3.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 --- Comment #12 from Fedora Update System --- python-debtcollector-0.3.0-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-debtcollector-0.3.0-3.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Chandan Kumar changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Chandan Kumar --- New Package SCM Request === Package Name: python-debtcollector Short Description: A collection of Python deprecation patterns and strategies Upstream URL: https://pypi.python.org/pypi/debtcollector Owners: chandankumar Branches: f22 InitialCC: apevec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Parag AN(पराग) changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Parag AN(पराग) --- Looks good now :) APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 --- Comment #8 from Chandan Kumar --- Hi Parag, Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-debtcollector.spec SRPM: https://chandankumar.fedorapeople.org/python-debtcollector-0.3.0-3.fc21.src.rpm Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Parag AN(पराग) changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Parag AN(पराग) changed: What|Removed |Added Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Parag AN(पराग) changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Parag AN(पराग) --- Review: + Package built successfully in rawhide mock (x86_64) + rpmlint on all generated rpms give result python-debtcollector-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-debtcollector-doc/html/_static/jquery.js 3 packages and 0 specfiles checked; 0 errors, 1 warnings. => I actually don't see any benefit fixing this but if you want you can do in %install as dos2unix doc/build/html/_static/jquery.js but this will require you to add in spec file BuildRequires: dos2unix + Source verified with upstream as (sha256sum) source rpm tarball: 64cf1ab9bacbdda8c83a569349f2a91211a890973e0119514a9b7bf34518373e upstream tarball: 64cf1ab9bacbdda8c83a569349f2a91211a890973e0119514a9b7bf34518373e + License is "ASL 2.0" which is valid and its license text is installed in LICENSE file. Suggestions: 1) I see build.log showing some tracebacks while building documentation. This mean you are missing some packages. For this package you should add in spec BuildRequires: python-six BuildRequires: python-oslo-utils submit new package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 --- Comment #6 from Chandan Kumar --- Hi, Thanks for the review: Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-debtcollector.spec SRPM: https://chandankumar.fedorapeople.org/python-debtcollector-0.3.0-2.fc21.src.rpm and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9318824 I have removed the tests from %check section in the spec file because for running tests for debtcollector package, it requires a python package `discover` as a dependency (which is not yet available on fedora koji). Once the python-discover is build, i will add the tests under %check section in spec file. Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Alan Pevec changed: What|Removed |Added Depends On||1200955 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1200955 [Bug 1200955] Review Request: python-wrapt - A Python module for decorators, wrappers and monkey patching -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com Assignee|nob...@fedoraproject.org|panem...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||chku...@redhat.com --- Comment #5 from Zbigniew Jędrzejewski-Szmek --- *** Bug 1200422 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) --- Comment #4 from Zbigniew Jędrzejewski-Szmek --- (In reply to Robin Lee from comment #3) > What's the difference with 1200422? You should keep only one request issue > per package. I assume it was a mistake. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Robin Lee changed: What|Removed |Added CC||robinlee.s...@gmail.com --- Comment #3 from Robin Lee --- What's the difference with 1200422? You should keep only one request issue per package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520
Kushal Khandelwal (kushalk124) changed:
What|Removed |Added
CC||kushal...@gmail.com
--- Comment #2 from Kushal Khandelwal (kushalk124) ---
A quick fix in the spec :
In the source0 , user %{version}
And the fixes as suggested by Zbigniew
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
CC||zbys...@in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
%description has a repetition a repetition near the end.
After reading of the description I still don't know *what* the package does. Is
it a collections of classes to help me? Is it a collection of decorators? Does
it run some checks on my code? Is it a collection of (anti-)examples?
Change %{__python} to %{__python2}.
Why delete tests? It would be best to let them be and also run them in %check
phase.
Use %license for LICENSE.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
