[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 Mattia Verga changed: What|Removed |Added CC||ayo...@redhat.com --- Comment #12 from Mattia Verga --- *** Bug 1148175 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-keystoneclient-kerbe ||ros-0.1.4-1.fc22 Resolution|--- |ERRATA Last Closed||2015-06-11 14:40:13 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-keystoneclient-kerberos-0.1.4-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-keystoneclient-kerberos-0.1.4-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-keystoneclient-kerberos-0.1.4-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-keystoneclient-kerberos-0.1.3-2.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-keystoneclient-kerberos-0.1.3-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-keystoneclient-kerberos-0.1.3-2.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672
Florian der-flo Lehner d...@der-flo.net changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Florian der-flo Lehner d...@der-flo.net ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
Note: Cannot find LICENSE in rpm(s)
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
--- NOT an issue! Package uses %license
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0).
1 files have unknown license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
--- remove the dependency on oslotest which is not currently packaged
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
---
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 Jamie Lennox jlen...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Jamie Lennox jlen...@redhat.com --- New Package SCM Request === Package Name: python-keystoneclient-kerberos Short Description: Kerberos authentication for the OpenStack clients Upstream URL: https://pypi.python.org/pypi/python-keystoneclient-kerberos Owners: jamielennox Branches: f22 InitialCC: apevec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 --- Comment #6 from Jamie Lennox jlen...@redhat.com --- Thanks Florian! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672
Florian der-flo Lehner d...@der-flo.net changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||d...@der-flo.net
Assignee|nob...@fedoraproject.org|d...@der-flo.net
Flags||fedora-review?
--- Comment #2 from Florian der-flo Lehner d...@der-flo.net ---
Hi Jamie!
There are a few things:
[ ] Please add some explaining words to the patch.
[ ] %doc is empty. Please add at least README.
[ ] For the license text file, you can use the following macro within %files:
%{!?_licensedir:%global license %%doc}
%license LICENSE
[ ] You don't use with_python3, so you don't need to define it
[ ] There is no version tag in your changelog
Cheers,
Florian
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 --- Comment #3 from Jamie Lennox jlen...@redhat.com --- Thanks Florian, These things all look obvious when someone else points them out. Spec URL: https://fedorapeople.org/~jamielennox/python-keystoneclient-kerberos.spec SRPM URL: https://fedorapeople.org/~jamielennox/python-keystoneclient-kerberos-0.1.3-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 Jamie Lennox jlen...@redhat.com changed: What|Removed |Added Blocks||1193702 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1193702 [Bug 1193702] Add package python-keystoneclient-kerberos -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200672] Review Request: python-keystoneclient-kerberos - Kerberos authentication for the OpenStack clients
https://bugzilla.redhat.com/show_bug.cgi?id=1200672 --- Comment #1 from Jamie Lennox jlen...@redhat.com --- Note that due to the python-keystoneclient version this will only build on F22+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
