[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176



--- Comment #17 from Fedora Update System  ---
python-pygatt-3.0.0-3.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-02-03 16:48:34



--- Comment #16 from Fedora Update System  ---
python-pygatt-3.0.0-3.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176



--- Comment #15 from Fedora Update System  ---
python-pygatt-3.0.0-3.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a18da77a3c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
python-pygatt-3.0.0-3.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6427f18cfd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176



--- Comment #13 from Fedora Update System  ---
python-pygatt-3.0.0-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6427f18cfd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176



--- Comment #12 from Fedora Update System  ---
python-pygatt-3.0.0-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a18da77a3c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176



--- Comment #11 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-pygatt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176



--- Comment #10 from Fabian Affolter  ---
Thanks for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
+ package name follows the guidelines
+ summary and description are legible
+ license is acceptable (ASL 2.0)
+ license is specified correctly
+ latest python packaging template is used
+ %python_provide are present
+ provides/requires/br seem correct

rpmlint: one bogus spelling error and many bogus
python-bytecode-wrong-magic-value errors

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176



--- Comment #8 from Fabian Affolter  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> No need to define %sum, just fill in the first Summary, and then use
> %summary in subsequent ones.

There are several ways to do.

> Requries: bluez should apply to both subpackages, no?

Updated

> The tarball contains some pdf files which don't look like they're
> redistributable. You'll have to provide a sanitized tarball without them.

Switched to the tarball from PyPI. That one doesn't contain the PDF files.

%changelog
* Tue Jan 17 2017 Fabian Affolter  - 3.0.0-2
- Change source URL
- Update requirements

Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-pygatt-3.0.0-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
No need to define %sum, just fill in the first Summary, and then use %summary
in subsequent ones.

Requries: bluez should apply to both subpackages, no?

The tarball contains some pdf files which don't look like they're
redistributable. You'll have to provide a sanitized tarball without them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176



--- Comment #6 from Fabian Affolter  ---
%changelog
* Thu Nov 17 2016 Fabian Affolter  - 3.0.0-2
- Update to latest Python guidelines

* Fri Sep 16 2016 Fabian Affolter  - 2.1.0-1
- Update to latest upstream release 2.1.0

* Tue Mar 22 2016 Fabian Affolter  - 2.0.1-1
- Update py3
- Update to latest upstream release 2.0.1

Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-pygatt-3.0.0-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176

Fabian Affolter  changed:

   What|Removed |Added

  Flags|needinfo?(mail@fabian-affol |
   |ter.ch) |



--- Comment #5 from Fabian Affolter  ---
Sorry, forgot about that package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176

William Moreno  changed:

   What|Removed |Added

   Assignee|williamjmore...@gmail.com   |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176

William Moreno williamjmore...@gmail.com changed:

   What|Removed |Added

 CC||m...@fabian-affolter.ch
  Flags||needinfo?(mail@fabian-affol
   ||ter.ch)



--- Comment #4 from William Moreno williamjmore...@gmail.com ---
Hi, do want to continue with this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176

William Moreno williamjmore...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #3 from William Moreno williamjmore...@gmail.com ---
Good job in the spec

But there is some updates here:
https://fedoraproject.org/wiki/Packaging:Python

Now you must add a Provide: python2-foo and and build a subpackage for python 2
and 3

Please update the spec and I will run the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176

William Moreno williamjmore...@gmail.com changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176

Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
So, the packaging is OK, but it looks like it can be simplified a lot. Have you
tried running %build and %install without creating  a separate py3k directory?
This package doesn't use 2to3 so this should work just as well.

You can use %global _docdir_fmt %{name} to use a common license and
documentation directories.

%if 0%{?fedora}  12 → %if 0%{?fedora}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201176



--- Comment #1 from Fabian Affolter m...@fabian-affolter.ch ---
%changelog
* Wed Jun 03 2015 Fabian Affolter m...@fabian-affolter.ch - 1.0.1-1
- Update to latest upstream release 1.0.1

Update files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-pygatt-1.0.1-1.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review