[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||python-grabserial-1.8.1-1.f ||c21 Resolution|NEXTRELEASE |ERRATA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-grabserial-1.8.1-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-grabserial-1.8.1-1.f |python-grabserial-1.8.1-1.f |c21 |c22 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-grabserial-1.8.1-1.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-grabserial-1.8.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-grabserial-1.8.1-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-grabserial-1.8.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-grabserial-1.8.1-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 Sinny Kumari ksi...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-04-25 11:58:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 --- Comment #6 from Sinny Kumari ksi...@gmail.com --- Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 --- Comment #7 from Sinny Kumari ksi...@gmail.com --- New Package SCM Request === Package Name: python-grabserial Short Description: Reads a serial port and writes data to standard output Upstream URL: http://elinux.org/Grabserial Owners: sinnykumari Branches: f21 f22 InitialCC: sinnykumari -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 Sinny Kumari ksi...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 --- Comment #4 from Sinny Kumari ksi...@gmail.com --- After talking to Grabserial source maintainer, came to know that source is distributed under GPLv2 license only. He made needed changes in LICENSE file and released new version 1.8.1. Support for Python 3 package will be done later on. Updated srpm and spec file - SPEC - https://github.com/sinnykumari/grabserial-rpm-package/raw/master/python-grabserial.spec SRPM - https://github.com/sinnykumari/grabserial-rpm-package/raw/master/SRPM/python-grabserial-1.8.1-1.fc21.src.rpm Koji build link - http://koji.fedoraproject.org/koji/taskinfo?taskID=9552888 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Parag AN(पराग) panem...@gmail.com --- As the required license text is added, spec looks good now. APPROVED this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265 --- Comment #3 from Sinny Kumari ksi...@gmail.com --- Thank you for reviewing this package. Have one concern- 1.According to LICENSE file, License should be GPLv2+ but inside source tar ball, garbserial file says This program is provided under the Gnu General Public License (GPL) version 2 ONLY. So, I am confused what License I should use whether GPLv2 or GPLv2+. I asked same to Grabserial maintainer and waiting for response. I have made needed changes as per your suggestion. Also, emailed maintainer to make modification needed for running it with python 3. Will send new SPEC and SRPM once License issue is resolved. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202265] Review Request: python-grabserial - Reads a serial port and writes data to standard output
https://bugzilla.redhat.com/show_bug.cgi?id=1202265
--- Comment #1 from Sinny Kumari skum...@redhat.com ---
I ran fedora-review on this package and results are pasted below. Please
provide your feedback if I missed out something.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
---
Checking: python-grabserial-1.7.1-1.fc21.noarch.rpm
python-grabserial-1.7.1-1.fc21.src.rpm
python-grabserial.noarch: W: no-manual-page-for-binary grabserial
python-grabserial.src: W: invalid-url Source0:
https://github.com/tbird20d/grabserial/releases/download/v1.7.1/grabserial-1.7.1.tar.gz
HTTP Error 403: Forbidden
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (installed packages)
Cannot parse rpmlint output:
Requires
python-grabserial (rpmlib, GLIBC filtered):
/usr/bin/python2
pyserial
Provides
python-grabserial:
python-grabserial
Source checksums
https://github.com/tbird20d/grabserial/releases/download/v1.7.1/grabserial-1.7.1.tar.gz
:
CHECKSUM(SHA256) this package :
7354449842439cb1d119bff99857ad23e955facff9915260433eb5385a6366af
CHECKSUM(SHA256) upstream package :
7354449842439cb1d119bff99857ad23e955facff9915260433eb5385a6366af
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/bin/fedora-review -n python-grabserial
Buildroot used: fedora-21-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
