[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-cligj-0.1.0-1.fc22 Resolution|--- |ERRATA Last Closed||2015-05-25 23:18:44 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- python-cligj-0.1.0-1.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-cligj-0.1.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-cligj-0.1.0-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-cligj-0.1.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-cligj-0.1.0-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-cligj-0.1.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-cligj-0.1.0-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 Julien Enselme juj...@jujens.eu changed: What|Removed |Added Status|NEW |ASSIGNED CC||juj...@jujens.eu Assignee|nob...@fedoraproject.org|juj...@jujens.eu --- Comment #1 from Julien Enselme juj...@jujens.eu --- Hi, some preliminary remarks : - build fails in mock due to: ImportError: No module named setuptools. Please add setuptools as BR - upstream provides the license text (sadly not in the tarballs), please add it to your source: https://raw.githubusercontent.com/mapbox/cligj/master/LICENSE - Please add a / where needed in the %files section. See https://fedoraproject.org/wiki/Packaging:Python#Files_to_include -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 --- Comment #2 from Miro Hrončok mhron...@redhat.com --- Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/python-cligj.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-cligj-0.1.0-1.fc21.src.rpm (In reply to Julien Enselme from comment #1) Hi, some preliminary remarks : - build fails in mock due to: ImportError: No module named setuptools. Please add setuptools as BR Done. - upstream provides the license text (sadly not in the tarballs), please add it to your source: https://raw.githubusercontent.com/mapbox/cligj/master/LICENSE Done, with url containing version/tag - Please add a / where needed in the %files section. See https://fedoraproject.org/wiki/Packaging:Python#Files_to_include I've read that and I don't understand why would I need to add /, could you please explain it to me or qute the exact sentence form the guidelines you are referring to? Thanks for the hints. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700
Julien Enselme juj...@jujens.eu changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #3 from Julien Enselme juj...@jujens.eu ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: Unknown or generated. 4 files have unknown license. Detailed
output of licensecheck in /tmp/1203700-python-cligj/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[X]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[-]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[X]: Python eggs must not download any dependencies during the build
process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[X]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[X]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-cligj
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[X]: Packages should try to preserve
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700
--- Comment #4 from Miro Hrončok mhron...@redhat.com ---
(In reply to Julien Enselme from comment #3)
According to
https://fedoraproject.org/wiki/Packaging:Python#Files_to_include you can use:
%files
%{python2_sitelib}/foo/
or
%files
%dir %{python2_sitelib}/foo (to add the directory but not the files it
contains)
%{python2_sitelib}/foo/*
Could you please point me to an exact location where this is written? I cannot
see such rule. The link you've provided is too generic, please quote the
sentence that says this is a thing.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #5 from Orion Poplawski or...@cora.nwra.com --- I'm pretty sure the trailing slash is just a convention (one that I use as well) and not strictly a requirement. It does allow rpm to complain if the item is no longer a directory for whatever reason, and I do think it helps with clarity. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700
--- Comment #6 from Julien Enselme juj...@jujens.eu ---
My example comes from the next section:
https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling (sorry).
I did some digging and it appears that I was wrong. In your spec, for instance,
you use %{python2_sitelib}/%{pypi_name} to add the
/usr/lib/python2.7/site-packages/cligj directory. I always thought reading that
document
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_basics and
more specifically :
To include a single directory:
%{_datadir}/%{name}/
that the trailing / was compulsory when adding a directory. If it was omitted I
guessed something bad would happend. But according to
http://www.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html (see the
'The %dir Directive' section) that the directory and its content gets correctly
added. I was also not able to find anything that would indicate that
%{python2_sitelib}/%{pypi_name} is wrong.
I still thinks that the trailing / makes the SPEC clearer (but that just me).
Sorry to have bothered you with something wrong (at least I have learned
something). Approved!
@Orion: indeed. I was typing my reply when you submitted yours.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 Julien Enselme juj...@jujens.eu changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 --- Comment #7 from Miro Hrončok mhron...@redhat.com --- Thanks for the review. What Orion said makes sense. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Miro Hrončok mhron...@redhat.com --- New Package SCM Request === Package Name: python-cligj Short Description: Click params for GeoJSON CLI Upstream URL: https://github.com/mapbox/cligj Owners: churchyard Branches: f21 f22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added CC|or...@cora.nwra.com | Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1203700 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Blocks||1203761 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1203761 [Bug 1203761] Review Request: python-Fiona - Fiona reads and writes spatial data files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
