[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework

2015-04-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205793

Daniel Vrátil dvra...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2015-04-07 04:39:31



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework

2015-04-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205793



--- Comment #5 from Patrick Uiterwijk puiterw...@redhat.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework

2015-04-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205793

Patrick Uiterwijk puiterw...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework

2015-04-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205793

Daniel Vrátil dvra...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #4 from Daniel Vrátil dvra...@redhat.com ---
New Package SCM Request
===
Package Name: signon-kwallet-extension
Short KWallet integration for Sign-on framework
Upstream URL:
https://projects.kde.org/projects/kde/kdenetwork/signon-kwallet-extension
Owners: group::kde-sig
Branches: f22
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework

2015-04-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205793

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Rex Dieter rdie...@math.unl.edu ---
naming: ok

1.  license: NOT ok, src files appear to be GPLv2+

scriptlets: ok

macros: ok

%files/ownership: ok  (just fixed signon to properly own libdir/extensions)

builds/installs ok


The only item I found was the licensing, should be:
License: GPLv2+
please fix prior to building.


APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework

2015-04-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205793

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework

2015-03-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205793
Bug 1205793 depends on bug 1070406, which changed state.

Bug 1070406 Summary: Review Request: signon - Accounts framework for Linux and 
POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework

2015-03-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205793



--- Comment #2 from Daniel Vrátil dvra...@redhat.com ---
Spec URL: https://dvratil.fedorapeople.org/spec/signon-kwallet-extension.spec
SRPM URL:
https://dvratil.fedorapeople.org/spec/signon-kwallet-extension-15.03.95-2.fc21.src.rpm

* Tue Mar 31 2015 Daniel Vrátil dvra...@redhat.com - 15.03.95-2
- add upstream patch to drop lib soname

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework

2015-03-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205793

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu
 Blocks|1135103 (plasma5)   |1135564 (ktp-kf5)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1135103
[Bug 1135103] Plasma 5 Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1135564
[Bug 1135564] ktp-presence-applet: plasma5 support (RFE)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework

2015-03-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205793

Daniel Vrátil dvra...@redhat.com changed:

   What|Removed |Added

 Blocks||656997 (kde-reviews),
   ||1135103 (plasma5)
 Depends On||1070406 (signon-qt5)
  Alias||signon-kwallet-extension




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1070406
[Bug 1070406] Review Request: signon-qt5 - Accounts framework for Linux and
POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1135103
[Bug 1135103] Plasma 5 Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework

2015-03-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205793



--- Comment #1 from Kevin Kofler ke...@tigcc.ticalc.org ---
 # Remove the no-soname library, we don't need -devel for a plugin
 rm %{buildroot}/%{_libdir}/signon/extensions/libkeyring-kwallet.so

Uh, isn't the unversioned .so how the plugin is found?

You should really fix the CMakeLists.txt instead to not try to version the
plugin to begin with and install the actual plugin as the unversioned .so
instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review