[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528 Charalampos Stratakis changed: What|Removed |Added Status|MODIFIED|CLOSED CC||cstra...@redhat.com Resolution|--- |CURRENTRELEASE Last Closed||2016-09-27 10:46:14 --- Comment #8 from Charalampos Stratakis --- Since the package has been built for quite some time now, the review request bugzilla should be closed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528 --- Comment #7 from Upstream Release Monitoring --- social's scratch build of openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 for git://pkgs.fedoraproject.org/openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 and rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11426591 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528 Alan Pevec changed: What|Removed |Added Status|ASSIGNED|MODIFIED Fixed In Version||python-oslo-middleware-1.0. ||0-2.fc23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528 --- Comment #6 from Patrick Uiterwijk --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528 Patrick Uiterwijk changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528 Alan Pevec changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Alan Pevec --- New Package SCM Request === Package Name: python-oslo-middleware Short Description: OpenStack Oslo Middleware library Upstream URL: https://launchpad.net/oslo Owners: apevec Branches: f22 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
Haïkel Guémar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Haïkel Guémar ---
Since this package complies with Fedora packaging guidelines, I hereby approve
it
into Fedora Packages Collection. Please submit a SCM request.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)".
2 files have unknown license. Detailed output of licensecheck in
/home/haikel/1206528-python-oslo-middleware/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/python2.7/site-
packages/oslo(python-oslo-vmware, python-oslo-messaging, python-oslo-
i18n, python-oslo-sphinx, python-oslo-rootwrap, python-oslo-config,
python-oslo-concurrency)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
oslo-middleware-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supporte
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
--- Comment #3 from Alan Pevec ---
> * missing fallback macros for %license (required for EL7)
> %{!?_licensedir:%global license %%doc}
You mean required for EL6? %license seems to work out of the box on EL7
but I'll add it for possible EL6 rebuilds.
> * missing Requires: python-oslo-context (just approved)
Also stevedore in requirements.txt.
Spec URL: https://apevec.fedorapeople.org/python-oslo-middleware.spec
SRPM URL:
https://apevec.fedorapeople.org/python-oslo-middleware-1.0.0-2.fc23.src.rpm
Description: The OpenStack Oslo Middleware library.
Oslo middleware library includes components that can be injected into wsgi
pipelines to intercept request/response flows. The base class can be
enhanced with functionality like add/delete/modification of http headers
and support for limiting size/connection etc.
Fedora Account System Username: apevec
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
--- Comment #2 from Haïkel Guémar ---
few minor issues:
* missing fallback macros for %license (required for EL7)
%{!?_licensedir:%global license %%doc}
* missing Requires: python-oslo-context (just approved)
https://bugzilla.redhat.com/show_bug.cgi?id=1201325
=> I was able to confirm that it works with that package installed
Everything else is good, should be approved as soon as these points are fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528 Haïkel Guémar changed: What|Removed |Added Status|NEW |ASSIGNED CC||karlthe...@gmail.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528 --- Comment #1 from Alan Pevec --- Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=9345630 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
