[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-barbicanclient-3.0.3 ||-1.fc22 Resolution|--- |ERRATA Last Closed||2015-06-05 19:50:33 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-barbicanclient-3.0.3-1.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-barbicanclient-3.0.3-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-barbicanclient-3.0.3-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-barbicanclient-3.0.3-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454 Chandan Kumar chkumar...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Chandan Kumar chkumar...@gmail.com --- New Package SCM Request === Package Name: python-barbicanclient Short Description: Client Library for OpenStack Barbican Key Management API Upstream URL: https://pypi.python.org/pypi/python-barbicanclient Owners: chandankumar jruzicka Branches: f22 InitialCC: jruzicka -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | --- Comment #6 from Haïkel Guémar karlthe...@gmail.com --- I unset the cvs-flag, please add jruzicka in the Owners line or he will receive notifications without commit access. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454
Haïkel Guémar karlthe...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|karlthe...@gmail.com
Flags||fedora-review+
--- Comment #3 from Haïkel Guémar karlthe...@gmail.com ---
Please drop the line sphinx-build -b man source man
It's neither installed in the package, nor the generated man page useful (it
has almost no content)
Except that minor point, everything else, so I'll let you do the cleanup at
import time.
Therefore, I hereby approve this package into Fedora Packages Collection,
please
submit a SCM request.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0).
3 files have unknown license. Detailed output of licensecheck in
/home/haikel/1208454-python-barbicanclient/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
barbicanclient-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate
[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454 --- Comment #4 from Haïkel Guémar karlthe...@gmail.com --- btw, don't forget to add jruzicka as co-owner in your SCM request as he is the main maintainer of OpenStack clients. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454 Chandan Kumar chkumar...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Chandan Kumar chkumar...@gmail.com --- New Package SCM Request === Package Name: python-barbicanclient Short Description: Client Library for OpenStack Barbican Key Management API Upstream URL: https://pypi.python.org/pypi/python-barbicanclient Owners: chandankumar Branches: f22 InitialCC: jruzicka -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454
Haïkel Guémar karlthe...@gmail.com changed:
What|Removed |Added
CC||karlthe...@gmail.com
--- Comment #1 from Haïkel Guémar karlthe...@gmail.com ---
1. drop the pypi_name macro, it's the same as %{name}
2. python-argparse is not required, argparse is part of the standard library
since python 2.7
3. Alan set python-netifaces as a requirement of python-oslo-utils
4. clients are likely to be rebuilt on EL6, so I suggest having compatibility
macros
%if 0%{?rhel} 0%{?rhel} = 6
%{!?__python2:%global __python2 /usr/bin/python2}
%{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib()))}
%{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib(1)))}
%endif
%{!?_licensedir:%global license %%doc}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208454] Review Request: python-barbicanclient - Client Library for OpenStack Barbican Key Management API
https://bugzilla.redhat.com/show_bug.cgi?id=1208454 --- Comment #2 from Chandan Kumar chku...@redhat.com --- Hey Haikal, Thanks for the review. I have updated the spec file and srpm. Please have a look. Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
