[Bug 1210971] Review Request: libkface - A face recognition and detection library
https://bugzilla.redhat.com/show_bug.cgi?id=1210971 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). Added f22. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1210971] Review Request: libkface - A face recognition and detection library
https://bugzilla.redhat.com/show_bug.cgi?id=1210971 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1210971] Review Request: libkface - A face recognition and detection library
https://bugzilla.redhat.com/show_bug.cgi?id=1210971 --- Comment #7 from Rex Dieter rdie...@math.unl.edu --- thanks for f22 , my bad for copy-n-paste an old request here -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1210971] Review Request: libkface - A face recognition and detection library
https://bugzilla.redhat.com/show_bug.cgi?id=1210971 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2015-04-13 18:52:12 --- Comment #8 from Rex Dieter rdie...@math.unl.edu --- imported -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1210971] Review Request: libkface - A face recognition and detection library
https://bugzilla.redhat.com/show_bug.cgi?id=1210971
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #4 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=9464328
$ rpmlint -i -v *
libkface.src: I: checking
libkface.src: I: checking-url
https://projects.kde.org/projects/kde/kdegraphics/libs/libkface (timeout 10
seconds)
libkface.src: I: checking-url
http://download.kde.org/unstable/applications/15.03.97/src/libkface-15.03.97.tar.xz
(timeout 10 seconds)
libkface.x86_64: I: checking
libkface.x86_64: I: checking-url
https://projects.kde.org/projects/kde/kdegraphics/libs/libkface (timeout 10
seconds)
libkface-debuginfo.x86_64: I: checking
libkface-debuginfo.x86_64: I: checking-url
https://projects.kde.org/projects/kde/kdegraphics/libs/libkface (timeout 10
seconds)
libkface-devel.x86_64: I: checking
libkface-devel.x86_64: I: checking-url
https://projects.kde.org/projects/kde/kdegraphics/libs/libkface (timeout 10
seconds)
libkface-devel.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
libkface-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
libkface.spec: I: checking
libkface.spec: I: checking-url
http://download.kde.org/unstable/applications/15.03.97/src/libkface-15.03.97.tar.xz
(timeout 10 seconds)
4 packages and 1 specfiles checked; 0 errors, 2 warnings.
Nothing of interest so far.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %license.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
d28d04dbe3e9b96d4ce149d03da69b99c23ba9fb01b4b62c44e865d65f0aa7bd
libkface-15.03.97.tar.xz
d28d04dbe3e9b96d4ce149d03da69b99c23ba9fb01b4b62c44e865d65f0aa7bd
libkface-15.03.97.tar.xz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a
[Bug 1210971] Review Request: libkface - A face recognition and detection library
https://bugzilla.redhat.com/show_bug.cgi?id=1210971 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Rex Dieter rdie...@math.unl.edu --- New Package SCM Request === Package Name: libkface Short Description: A face recognition and detection library Upstream URL: https://projects.kde.org/projects/kde/kdegraphics/libs/libkface Owners: group::kde-sig Branches: f20 f21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1210971] Review Request: libkface - A face recognition and detection library
https://bugzilla.redhat.com/show_bug.cgi?id=1210971 --- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com --- (In reply to Mario Blättermann from comment #1) AUTHORS and TODO are missing from %doc. Sorry, AUTHORS is already present. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1210971] Review Request: libkface - A face recognition and detection library
https://bugzilla.redhat.com/show_bug.cgi?id=1210971 --- Comment #3 from Rex Dieter rdie...@math.unl.edu --- Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/libkface.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kf5/libkface-15.03.97-2.fc22.src.rpm %changelog * Sat Apr 11 2015 Rex Dieter rdie...@fedoraproject.org 15.03.97-2 - switch to publically-available 15.03.97 - fix missing %%description - -devel: %%license COPYING.LIB COPYING-CMAKE_SCRIPTS -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1210971] Review Request: libkface - A face recognition and detection library
https://bugzilla.redhat.com/show_bug.cgi?id=1210971 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com --- %description is still empty. AUTHORS and TODO are missing from %doc. The cmake scripts are BSD licensed, those license text should be added to the -devel package. The file libkface/libkface_export.h is LGPL licensed, that's why COPYING.LIB needs to go into -devel. rpmlint complains about a non-existent download URL. Indeed, the access is forbidden: $ wget http://download.kde.org/stable/applications/15.04.0/src/libkface-15.04.0.tar.xz --2015-04-11 21:05:15-- http://download.kde.org/stable/applications/15.04.0/src/libkface-15.04.0.tar.xz Auflösen des Hostnamens »download.kde.org (download.kde.org)« … 2001:67c:2178:7::71, 195.135.221.71 Verbindungsaufbau zu download.kde.org (download.kde.org)|2001:67c:2178:7::71|:80 … verbunden. HTTP-Anforderung gesendet, auf Antwort wird gewartet … 403 Forbidden 2015-04-11 21:05:15 FEHLER 403: Forbidden. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1210971] Review Request: libkface - A face recognition and detection library
https://bugzilla.redhat.com/show_bug.cgi?id=1210971 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||656997 (kde-reviews) Alias||libkface Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
