[Bug 1210990] Review Request: qt5-qtwebchannel - Qt5 WebChannel component

2015-08-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1210990

Rex Dieter  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2015-08-05 13:19:21



--- Comment #8 from Rex Dieter  ---
imported into rawhide awhile back.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1210990] Review Request: qt5-qtwebchannel - Qt5 WebChannel component

2015-04-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1210990

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1210990] Review Request: qt5-qtwebchannel - Qt5 WebChannel component

2015-04-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1210990



--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1210990] Review Request: qt5-qtwebchannel - Qt5 WebChannel component

2015-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1210990



--- Comment #6 from Rex Dieter  ---
New Package SCM Request
===
Package Name: qt5-qtwebchannel
Short Description: Qt5 WebChannel component
Upstream URL: http://qt.io
Owners: nocnokneo group::kde-sig
Branches: f20 f21 f22 el6 epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1210990] Review Request: qt5-qtwebchannel - Qt5 WebChannel component

2015-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1210990



--- Comment #5 from Rex Dieter  ---
Sorry, checking other reviews, looks like the correct syntax is group::kde-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1210990] Review Request: qt5-qtwebchannel - Qt5 WebChannel component

2015-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1210990

Taylor Braun-Jones  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #4 from Taylor Braun-Jones  ---
New Package SCM Request
===
Package Name: qt5-qtwebchannel
Short Description: Qt5 WebChannel component
Upstream URL: http://qt.io
Owners: nocnokneo group:kde-sig
Branches: f20 f21 f22 el6 epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1210990] Review Request: qt5-qtwebchannel - Qt5 WebChannel component

2015-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1210990



--- Comment #3 from Taylor Braun-Jones  ---
(In reply to Rex Dieter from comment #1)
> looks like the qt5-qtwebsocket build dependency is optional and only for
> some examples, but using it here is mostly harmless.  Probably worth adding
> a .spec comment about this, in case it helps bootstrapping new archs.

Fixed with comment explanation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1210990] Review Request: qt5-qtwebchannel - Qt5 WebChannel component

2015-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1210990



--- Comment #2 from Rex Dieter  ---
If you don't mind, please add group:kde-sig as comaintainer for this package
when submitting scm request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1210990] Review Request: qt5-qtwebchannel - Qt5 WebChannel component

2015-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1210990

Rex Dieter  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Rex Dieter  ---
$ rpmlint qt5-qtwebchannel qt5-qtwebchannel-devel
qt5-qtwebchannel.x86_64: W: incoherent-version-in-changelog 5.4.0-1
['5.4.1-1.fc22', '5.4.1-1']
qt5-qtwebchannel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libQt5WebChannel.so.5.4.1 /lib64/libQt5Network.so.5
qt5-qtwebchannel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libQt5WebChannel.so.5.4.1 /lib64/libpthread.so.0
qt5-qtwebchannel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libQt5WebChannel.so.5.4.1 /lib64/libm.so.6
qt5-qtwebchannel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libQt5WebChannel.so.5.4.1 /lib64/libgcc_s.so.1
qt5-qtwebchannel-devel.x86_64: W: only-non-binary-in-usr-lib
qt5-qtwebchannel-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 7 warnings.

mostly harmless

naming: ok, matches standard naming of other qt5- modules in distro

license: ok

sources: ok
$ md5sum *.xz
bb914134c164c6758a0074748cc678ff  qtwebchannel-opensource-src-5.4.1.tar.xz

builds/installs: ok

macros: ok

scriptlet: ok

looks like the qt5-qtwebsocket build dependency is optional and only for some
examples, but using it here is mostly harmless.  Probably worth adding a .spec
comment about this, in case it helps bootstrapping new archs.


Otherwise, thanks, looks good, APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1210990] Review Request: qt5-qtwebchannel - Qt5 WebChannel component

2015-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1210990

Rex Dieter  changed:

   What|Removed |Added

 Blocks||928937 (qt-reviews)
Summary|Review Request: Qt5 -   |Review Request:
   |WebChannel component|qt5-qtwebchannel - Qt5
   ||WebChannel component
  Alias||qt5-qtwebchannel




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review