[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Fedora Update System changed: What|Removed |Added Fixed In Version|golang-github-hashicorp-go- |golang-github-hashicorp-go- |msgpack-0-0.1.git71c2886.fc |msgpack-0-0.1.git71c2886.el |22 |6 --- Comment #10 from Fedora Update System --- golang-github-hashicorp-go-msgpack-0-0.1.git71c2886.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Fedora Update System changed: What|Removed |Added Fixed In Version|golang-github-hashicorp-go- |golang-github-hashicorp-go- |msgpack-0-0.1.git71c2886.fc |msgpack-0-0.1.git71c2886.fc |21 |22 --- Comment #9 from Fedora Update System --- golang-github-hashicorp-go-msgpack-0-0.1.git71c2886.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||golang-github-hashicorp-go- ||msgpack-0-0.1.git71c2886.fc ||21 Resolution|--- |ERRATA Last Closed||2015-06-29 20:04:41 --- Comment #8 from Fedora Update System --- golang-github-hashicorp-go-msgpack-0-0.1.git71c2886.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- golang-github-hashicorp-go-msgpack-0-0.1.git71c2886.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 --- Comment #6 from Fedora Update System --- golang-github-hashicorp-go-msgpack-0-0.1.git71c2886.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-hashicorp-go-msgpack-0-0.1.git71c2886.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 --- Comment #5 from Fedora Update System --- golang-github-hashicorp-go-msgpack-0-0.1.git71c2886.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-hashicorp-go-msgpack-0-0.1.git71c2886.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 --- Comment #4 from Fedora Update System --- golang-github-hashicorp-go-msgpack-0-0.1.git71c2886.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-github-hashicorp-go-msgpack-0-0.1.git71c2886.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Jan Chaloupka changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #2 from Jan Chaloupka --- New Package SCM Request === Package Name: golang-github-hashicorp-go-msgpack Short Description: Collection of Open-Source Go libraries and tools Upstream URL: https://github.com/hashicorp/go-msgpack Owners: jchaloup lsm5 Branches: f22 f21 f20 el6 InitialCC: golang-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031
Michael Scherer changed:
What|Removed |Added
CC||m...@zarb.org
Assignee|nob...@fedoraproject.org|m...@zarb.org
Flags||fedora-review+
--- Comment #1 from Michael Scherer ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- No need to copy the python file codec/msgpack_test.py, since this will
trigger a requires
on python.
- License should be in %license
- The rpm should be tagged as noarch, without conditionals.
Provided theses 3 issues are fixed, the package is approved.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in /home/misc/checkout/git/FedoraReview/1212031-golang-
github-hashicorp-go-msgpack/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Jan Chaloupka changed: What|Removed |Added Blocks||1212346 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1212346 [Bug 1212346] Review Request: golang-github-hashicorp-raft-mdb - LMDB backend for Raft -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Jan Chaloupka changed: What|Removed |Added Blocks||1208616 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1208616 [Bug 1208616] New Package Request: consul - Consul is a tool for service discovery and configuration. Consul is distributed, highly available, and extremely scalable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Jan Chaloupka changed: What|Removed |Added Blocks||1212318 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1212318 [Bug 1212318] Review Request: golang-github-hashicorp-serf- Service orchestration and management tool http://www.serfdom.io -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Jan Chaloupka changed: What|Removed |Added Blocks||1212105 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1212105 [Bug 1212105] Review Request: golang-github-hashicorp-raft-boltdb- Raft backend implementation using BoltDB -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Jan Chaloupka changed: What|Removed |Added Blocks||1212075 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1212075 [Bug 1212075] Review Request: golang-github-hashicorp-net-rpc-msgpackrpc- Library for creating Go RPC client/server -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Jan Chaloupka changed: What|Removed |Added Blocks||1212068 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1212068 [Bug 1212068] Review Request: golang-github-hashicorp-raft- Golang implementation of the Raft consensus protocol -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212031] Review Request: golang-github-hashicorp-go-msgpack- Collection of Open-Source Go libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=1212031 Jan Chaloupka changed: What|Removed |Added Blocks||1212065 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1212065 [Bug 1212065] Review Request: golang-github-hashicorp-memberlist- Golang package for gossip based membership and failure detection -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
