[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354
--- Comment #4 from Antonio Trande ---
(In reply to Antonio Trande from comment #3)
> (In reply to Igor Gnatenko from comment #2)
> >
> > > %if 0%{?rhel} && 0%{?rhel} <= 6
> > > %{!?__python2: %global __python2 /usr/bin/python2}
> > > %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from
> > > distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> > > %{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from
> > > distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
> > > %endif
> > are you planning to support el6?
>
> Yes.
I wish but impossible yet (missing BR packages).
Spec URL: https://sagitter.fedorapeople.org/assimulo/assimulo.spec
SRPM URL:
https://sagitter.fedorapeople.org/assimulo/assimulo-2.8-1.fc22.src.rpm
- Update to 2.8
- Only for EPEL7 and Fedora
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 Antonio Trande changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 Antonio Trande changed: What|Removed |Added Flags||needinfo?(i.gnatenko.brain@ ||gmail.com) --- Comment #5 from Antonio Trande --- @Igor Gnatenko This review is stalled. Please, confirm your interest on it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 Antonio Trande changed: What|Removed |Added Assignee|i.gnatenko.br...@gmail.com |nob...@fedoraproject.org Flags|fedora-review? | |needinfo?(i.gnatenko.brain@ | |gmail.com) | --- Comment #6 from Antonio Trande --- (In reply to Antonio Trande from comment #5) > @Igor Gnatenko > > This review is stalled. Please, confirm your interest on it. This review is newly unassigned. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 Antonio Trande changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 Ben Rosser changed: What|Removed |Added CC||rosser@gmail.com --- Comment #7 from Ben Rosser --- On current Rawhide, the unit tests fail (tried to build SRPM using mock): == ERROR: test_examples.Test_Examples.test_dasp3_basic -- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest self.test(*self.arg) File "/builddir/build/BUILD/Assimulo-2.8/assimulo/tests/test_examples.py", line 47, in test_dasp3_basic dasp3_basic.run_example(with_plots=False) File "/builddir/build/BUILDROOT/assimulo-2.8-1.fc24.x86_64/usr/lib64/python2.7/site-packages/assimulo/examples/dasp3_basic.py", line 91, in run_example t, y = exp_sim.simulate(10) #Simulate 10 seconds File "assimulo/ode.pyx", line 169, in assimulo.ode.ODE.simulate (assimulo/ode.c:5794) File "assimulo/ode.pyx", line 283, in assimulo.ode.ODE.simulate (assimulo/ode.c:5277) File "assimulo/explicit_ode.pyx", line 102, in assimulo.explicit_ode.Explicit_ODE._simulate (assimulo/explicit_ode.c:4385) File "assimulo/explicit_ode.pyx", line 188, in assimulo.explicit_ode.Explicit_ODE._simulate (assimulo/explicit_ode.c:3204) File "/builddir/build/BUILDROOT/assimulo-2.8-1.fc24.x86_64/usr/lib64/python2.7/site-packages/assimulo/solvers/dasp3.py", line 129, in integrate t,lflag=dasp3dp.dasp3(self.problem.rhs1,self.problem.rhs2,self._solout,t,tf,self.wsy,self.wsz,n,m,tol, NameError: global name 'dasp3dp' is not defined -- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 Antonio Trande changed: What|Removed |Added Whiteboard||NotReady --- Comment #8 from Antonio Trande --- Thanks. I will check this package as soon as i complete other reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 --- Comment #9 from Upstream Release Monitoring --- sagitter's scratch build of assimulo-2.8-2.fc22.src.rpm for f22 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11312948 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 Antonio Trande changed: What|Removed |Added Whiteboard|NotReady| --- Comment #10 from Antonio Trande --- This package is now ready for the review. Spec URL: https://sagitter.fedorapeople.org/assimulo/assimulo.spec SRPM URL: https://sagitter.fedorapeople.org/assimulo/assimulo-2.8-2.fc22.src.rpm - Fixed numpy's version detection - Fixed test error on AARCH64 - Set Fortran compiler flags -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 --- Comment #11 from Antonio Trande --- Spec URL: https://sagitter.fedorapeople.org/assimulo/assimulo.spec SRPM URL: https://sagitter.fedorapeople.org/assimulo/assimulo-2.8-3.fc23.src.rpm - Fixed flags for hardened builds -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 --- Comment #12 from Upstream Release Monitoring --- sagitter's scratch build of assimulo-2.8-3.fc23.src.rpm for f21 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11769378 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354
Richard Shaw changed:
What|Removed |Added
CC||hobbes1...@gmail.com
--- Comment #13 from Richard Shaw ---
I may have some time to take this review but have a question.
What's the purpose of defining pname? As soon as you set the name, you can use
%{name} instead.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 --- Comment #14 from Antonio Trande --- Hi Richard, originally, i was going to name this package 'python-assimulo', then i chose just assimulo. Spec URL: https://sagitter.fedorapeople.org/assimulo/assimulo.spec SRPM URL: https://sagitter.fedorapeople.org/assimulo/assimulo-2.8-4.fc23.src.rpm - Removed pname custom macro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 Mukundan Ragavan changed: What|Removed |Added Status|NEW |ASSIGNED CC||nonamed...@gmail.com Assignee|nob...@fedoraproject.org|nonamed...@gmail.com Flags||fedora-review? --- Comment #15 from Mukundan Ragavan --- I am taking this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 --- Comment #16 from Richard Shaw --- (In reply to Antonio Trande from comment #14) > Hi Richard, > > originally, i was going to name this package 'python-assimulo', then i chose > just assimulo. Ok, well it looks like you have a formal reviewer now. My only feedback is that I think you were right in the first place, this is more of a python library, not an end user application so I think it must be prefixed with python-... per the Python guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 --- Comment #17 from Mukundan Ragavan --- Antonio - sorry for the delay. I will post a review later today. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 --- Comment #18 from Upstream Release Monitoring --- nonamedotc's scratch build of assimulo-2.8-4.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11837188 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354
--- Comment #19 from Mukundan Ragavan ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
---> I am able to install the package manually on my VM ... will need to check
again.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* BSD (2 clause)", "*No
copyright* LGPL (v3)", "BSD (3 clause)", "BSD (2 clause)", "LGPL (v2.1
or later)", "GPL (v3)", "LGPL (v3)". 72 files have unknown license.
Detailed output of licensecheck in
/home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1215354-assimulo/licensecheck.txt
---> This seems to be ok. No issues noticed. License files are also provided by
the source1 tarball.
Please also contact the upstream and request them to include license full texts
in the source tree.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
---> License: LGPLv3+ and LGPLv2+ and BSD and GPLv3
All licenses included.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[?]: Package is named according to the Package Naming Guidelines.
---> Wouldn't the name be more appropriate as python-assimulo?
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 --- Comment #20 from Mukundan Ragavan --- This is the first patch that is applied for select architectures - --- assimulo/examples/mech_system_pendulum.orig.py2014-07-17 12:40:10.0 +0200 +++ assimulo/examples/mech_system_pendulum.py2015-04-25 19:23:54.272276500 +0200 @@ -63,7 +63,7 @@ print(final_residual, 'Norm: ', sl.norm(final_residual)) if with_test: -assert(sl.norm(final_residual) < 1.5e-2) +assert(sl.norm(final_residual) < 1.5e-1) if with_plots: dae_pend.plot(mask=[1,1]+(len(my_pend.y0)-2)*[0]) return my_pend, dae_pend I do not think I understand why this reduced tolerance is needed .. Can you please explain? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354
--- Comment #21 from Antonio Trande ---
(In reply to Mukundan Ragavan from comment #19)
> Package Review
> ==
>
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
>
>
> Issues:
> ===
> - Package installs properly.
> Note: Installation errors (see attachment)
> See: https://fedoraproject.org/wiki/Packaging:Guidelines
>
> ---> I am able to install the package manually on my VM ... will need to
> check again.
>
>
> = MUST items =
>
> C/C++:
> [x]: Package does not contain kernel modules.
> [x]: Package contains no static executables.
> [x]: Development (unversioned) .so files in -devel subpackage, if present.
> Note: Unversioned so-files in private %_libdir subdirectory (see
> attachment). Verify they are not in ld path.
> [x]: Header files in -devel subpackage, if present.
> [x]: Package does not contain any libtool archives (.la)
> [x]: Rpath absent or only used for internal libs.
>
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
> [x]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses
> found: "Unknown or generated", "*No copyright* BSD (2 clause)", "*No
> copyright* LGPL (v3)", "BSD (3 clause)", "BSD (2 clause)", "LGPL (v2.1
> or later)", "GPL (v3)", "LGPL (v3)". 72 files have unknown license.
> Detailed output of licensecheck in
>
> /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1215354-assimulo/licensecheck.
> txt
>
> ---> This seems to be ok. No issues noticed. License files are also provided
> by the source1 tarball.
>
> Please also contact the upstream and request them to include license full
> texts in the source tree.
>
> [x]: License file installed when any subpackage combination is installed.
> [x]: If the package is under multiple licenses, the licensing breakdown
> must be documented in the spec.
>
> ---> License: LGPLv3+ and LGPLv2+ and BSD and GPLv3
>
> All licenses included.
>
> [x]: %build honors applicable compiler flags or justifies otherwise.
> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [x]: Sources contain only permissible code or content.
> [-]: Package contains desktop file if it is a GUI application.
> [-]: Development files must be in a -devel package
> [x]: Package uses nothing in %doc for runtime.
> [x]: Package consistently uses macros (instead of hard-coded directory
> names).
> [?]: Package is named according to the Package Naming Guidelines.
>
> ---> Wouldn't the name be more appropriate as python-assimulo?
I will change it.
>
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [-]: If the package is a rename of another package, proper Obsoletes and
> Provides are present.
> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [-]: Package contains systemd file(s) if in need.
> [x]: Useful -debuginfo package or justification otherwise.
> [x]: Package is not known to require an ExcludeArch tag.
> [-]: Large documentation must go in a -doc subpackage. Large could be size
> (~1MB) or number of files.
> Note: Documentation size is 40960 bytes in 4 files.
> [x]: Package complies to the Packaging Guidelines
> [x]: Package successfully compiles and builds into binary rpms on at least
> one supported primary architecture.
> [x]: Rpmlint is run on all rpms the build produces.
> Note: There are rpmlint messages (see attachment).
> [x]: If (and only if) the source package includes the text of the
> license(s) in its own file, then that file, containing the text of the
> license(s) for the package is included in %license.
> [x]: Package requires other packages for directories it uses.
> [x]: Package must own all directories that it creates.
> [x]: Package does not own files or directories owned by other packages.
> [x]: All build dependencies are listed in BuildRequires, except for any
> that are listed in the exceptions section of Packaging Guidelines.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
> beginning of %install.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
> work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: Package does not use a name that already exists.
> [x]: Package is not relocatable.
> [x]:
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 --- Comment #22 from Antonio Trande --- (In reply to Mukundan Ragavan from comment #20) > This is the first patch that is applied for select architectures - > > --- assimulo/examples/mech_system_pendulum.orig.py2014-07-17 > 12:40:10.0 +0200 > +++ assimulo/examples/mech_system_pendulum.py 2015-04-25 19:23:54.272276500 > +0200 > @@ -63,7 +63,7 @@ > print(final_residual, 'Norm: ', sl.norm(final_residual)) > > if with_test: > -assert(sl.norm(final_residual) < 1.5e-2) > +assert(sl.norm(final_residual) < 1.5e-1) > if with_plots: > dae_pend.plot(mask=[1,1]+(len(my_pend.y0)-2)*[0]) > return my_pend, dae_pend > > > > I do not think I understand why this reduced tolerance is needed .. Can you > please explain? Because that test failed on PPC, like this one: https://trac.jmodelica.org/assimulo/ticket/239 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 --- Comment #23 from Mukundan Ragavan --- That sounds good. Please add the link to the upstream ticket in the spec file for reference. As for the name, if you have a specific reason for assimulo vs python-assimulo, I would be interested to know. As for mock installation errors, I don't know what's going on there. I am able to install it just fine on my system. koji error - that's does not seem related to this package, yes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 Antonio Trande changed: What|Removed |Added Blocks||505154 (FE-SCITECH) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=505154 [Bug 505154] Tracker: Review Requests for Science and Technology related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 --- Comment #1 from Antonio Trande --- Spec URL: https://sagitter.fedorapeople.org/assimulo/assimulo.spec SRPM URL: https://sagitter.fedorapeople.org/assimulo/assimulo-2.7b1-2.20150420rev751.fc21.src.rpm - Packaged license files - Fixed library permissions Zipped archive source code (revision trunk) downloaded by upstream produces this error: + /usr/bin/unzip -qq /home/sagitter/rpmbuild/SOURCES/trunk-751.zip warning: stripped absolute path spec from / mapname: conversion of failed warning: stripped absolute path spec from / mapname: conversion of failed I'm forced to unpack and re-compress manually before of packaging, so an 'Upstream MD5sum check error' comes out from fedora-review tool. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354 Igor Gnatenko changed: What|Removed |Added Status|NEW |ASSIGNED CC||i.gnatenko.br...@gmail.com Assignee|nob...@fedoraproject.org|i.gnatenko.br...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354
--- Comment #2 from Igor Gnatenko ---
> %setup -q -n trunk
use '%setup -q -c' instead. It will create special directory where you will
find trunk/
> %if 0%{?rhel} && 0%{?rhel} <= 6
> %{!?__python2: %global __python2 /usr/bin/python2}
> %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from
> distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> %{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from
> distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
> %endif
are you planning to support el6?
spectool -g ./assimulo.spec downloads broken zip. Please remove url and write
in comments how it supposed to be repacked. or fix url.
I will complete review tomorrow.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215354] Review Request: assimulo - Ordinary differential and differential algebraic equations solver
https://bugzilla.redhat.com/show_bug.cgi?id=1215354
--- Comment #3 from Antonio Trande ---
(In reply to Igor Gnatenko from comment #2)
> > %setup -q -n trunk
> use '%setup -q -c' instead. It will create special directory where you will
> find trunk/
Okay.
>
> > %if 0%{?rhel} && 0%{?rhel} <= 6
> > %{!?__python2: %global __python2 /usr/bin/python2}
> > %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from
> > distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> > %{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from
> > distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
> > %endif
> are you planning to support el6?
Yes.
>
> spectool -g ./assimulo.spec downloads broken zip. Please remove url and
> write in comments how it supposed to be repacked. or fix url.
>
> I will complete review tomorrow.
I wait for your complete review before to post new srpm/spec files.
Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
