[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Hans de Goede changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 --- Comment #8 from Hans de Goede --- Full review done: Good: - rpmlint checks return: angelscript-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 0 errors, 1 warnings. This warning can be ignored - package meets naming guidelines - package meets packaging guidelines - license (zlib) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Should fix: -Change the %doc for -devel from "%doc sdk/docs/*" to "%doc sdk/docs/manual/*" to avoid including the files under dk/docs/articles in both the main package and the -devel package No blockers: Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 --- Comment #7 from Igor Gnatenko --- (In reply to Hans de Goede from comment #6) > I'm going to review this one, assigning it to myself. I'm happy %) Let's do it! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Hans de Goede changed: What|Removed |Added Status|NEW |ASSIGNED CC||hdego...@redhat.com Assignee|nob...@fedoraproject.org|hdego...@redhat.com --- Comment #6 from Hans de Goede --- I'm going to review this one, assigning it to myself. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Bug 1215414 depends on bug 879931, which changed state. Bug 879931 Summary: Review Request: angelscript - AngelCode Scripting Library https://bugzilla.redhat.com/show_bug.cgi?id=879931 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Hans de Goede changed: What|Removed |Added Blocks||879928 (rigsofrods) CC||pa...@hubbitus.info --- Comment #5 from Hans de Goede --- *** Bug 879931 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=879928 [Bug 879928] Review Request: rigsofrods - Vehicle simulator based on soft-body physics -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 --- Comment #4 from Igor Gnatenko --- Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/angelscript.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/angelscript-2.30.0-2.fc23.src.rpm I've fixed all issues I think. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Jon Ciesla changed: What|Removed |Added CC||limburg...@gmail.com --- Comment #3 from Jon Ciesla --- I don't get that error either. I expected it at install time but I got nothing. Is it at compile time for another program, like stk or something? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Michael Schwendt (Fedora Packager Sponsors Group) changed: What|Removed |Added Depends On||879931 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=879931 [Bug 879931] Review Request: angelscript - AngelCode Scripting Library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 --- Comment #2 from Michael Schwendt (Fedora Packager Sponsors Group) --- When do you get that error? > Name: angelscript > %prep > %setup -q -n sdk This is not nice, since "-n sdk" implies "rm -rf sdk" in builddir root and may wipe something in a completely unexpected way. Typically, in such a case where %name is completely different from top source dir, you would use %setup -c and "cd sdk" in %prep, %build and %install: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 --- Comment #1 from Igor Gnatenko --- ldconfig: Can't link /lib64//usr/local/lib/libangelscript.so to libangelscript.so.2.30.0 Don't have idea how to fix this -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Igor Gnatenko changed: What|Removed |Added Blocks||1208136 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1208136 [Bug 1208136] supertuxkart-0.9 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
