[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728

Alan Pevec  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 CC||ape...@redhat.com
 Resolution|--- |EOL
Last Closed||2017-07-03 20:17:37



--- Comment #11 from Alan Pevec  ---
openstack-* were retired in Fedora and are now available from rdoproject.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System upda...@fedoraproject.org ---
openstack-gnocchi-1.0.0-1.fc22 has been pushed to the Fedora 22 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|RELEASE_PENDING |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728



--- Comment #8 from Fedora Update System upda...@fedoraproject.org ---
openstack-gnocchi-1.0.0-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/openstack-gnocchi-1.0.0-1.fc22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728



--- Comment #9 from Fedora Update System upda...@fedoraproject.org ---
openstack-gnocchi-1.0.0-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/openstack-gnocchi-1.0.0-1.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728

Haïkel Guémar karlthe...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(karlthered@gmail. |
   |com)|



--- Comment #4 from Haïkel Guémar karlthe...@gmail.com ---
Few minor points to fix before importing into dist-git:
* There's a typo in License tag, it's *ASL 2.0*
* sed -i '/%defattr(-,root,root,-)/d' *.spec
* License file is not included, since you're also an upstream developer, I
trust you
to ensure that it will be included in future releases.


Since this package complies with Fedora Packaging Guidelines, I hereby approve
it into
Fedora Packages Collection. Please submit a SCM request.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0).
 12 files have unknown license. Detailed output of licensecheck in
 /home/haikel/1215728-openstack-gnocchi/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/ceilometer
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Each %files section contains %defattr if rpm  4.4
 Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728

Pradeep Kilambi pkila...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #5 from Pradeep Kilambi pkila...@redhat.com ---
New Package SCM Request
===
Package Name:   openstack-gnocchi
Short Description:  Gnocchi is an API to store metrics and index resources
Upstream URL:  
https://pypi.python.org/packages/source/g/gnocchi/gnocchi-1.0.0.tar.gz
Owners: pkilambi
Branches:   f20 f21 f22 epel7
InitialCC:  pkilambi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728



--- Comment #6 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728

Pradeep Kilambi pkila...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|RELEASE_PENDING



--- Comment #7 from Pradeep Kilambi pkila...@redhat.com ---
packages built successfully. I don't see NEXTRELEASE option, so moving to
RELEASE_PENDING.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728

hgue...@redhat.com changed:

   What|Removed |Added

 CC||hgue...@redhat.com,
   ||pkila...@redhat.com
  Flags||needinfo?(pkilambi@redhat.c
   ||om)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728

Pradeep Kilambi pkila...@redhat.com changed:

   What|Removed |Added

  Flags|needinfo?(pkilambi@redhat.c |
   |om) |



--- Comment #3 from Pradeep Kilambi pkila...@redhat.com ---
Thanks Haikel. Fixed the points you highlighted above:

https://pkilambi.fedorapeople.org/openstack-gnocchi/openstack-gnocchi.spec

https://pkilambi.fedorapeople.org/openstack-gnocchi/openstack-gnocchi-1.0.0-1.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728

Pradeep Kilambi pkila...@redhat.com changed:

   What|Removed |Added

  Flags||needinfo?(karlthered@gmail.
   ||com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728

Haïkel Guémar karlthe...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|needinfo?(karlthered@gmail. |fedora-review?
   |com)|



--- Comment #2 from Haïkel Guémar karlthe...@gmail.com ---
Ok few points:
* drop both python2 macro definitions on top of the specs = unneededed.
* drop the following line in %install
rm -rf %{buildroot}
* Please check the following guidelines about non-numeric version
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215728] Review Request: openstack-gnocchi - HTTP API to store metrics and index resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215728

Pradeep Kilambi pkila...@redhat.com changed:

   What|Removed |Added

 CC||karlthe...@gmail.com
  Flags||needinfo?(karlthered@gmail.
   ||com)



--- Comment #1 from Pradeep Kilambi pkila...@redhat.com ---
Made some changes. Here is the new spec:

SPEC: 
https://pkilambi.fedorapeople.org/openstack-gnocchi/openstack-gnocchi.spec

SRPM:
https://pkilambi.fedorapeople.org/openstack-gnocchi/openstack-gnocchi-1.0.0c2-1.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review