[Bug 1218124] Review Request: kwalletmanager5 - Manage KDE passwords
https://bugzilla.redhat.com/show_bug.cgi?id=1218124 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2015-05-14 08:24:15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218124] Review Request: kwalletmanager5 - Manage KDE passwords
https://bugzilla.redhat.com/show_bug.cgi?id=1218124 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218124] Review Request: kwalletmanager5 - Manage KDE passwords
https://bugzilla.redhat.com/show_bug.cgi?id=1218124 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218124] Review Request: kwalletmanager5 - Manage KDE passwords
https://bugzilla.redhat.com/show_bug.cgi?id=1218124 Rajeesh rajeeshknamb...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|rajeeshknamb...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218124] Review Request: kwalletmanager5 - Manage KDE passwords
https://bugzilla.redhat.com/show_bug.cgi?id=1218124 Rajeesh rajeeshknamb...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Rajeesh rajeeshknamb...@gmail.com --- Okay, clear then. Thanks, APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218124] Review Request: kwalletmanager5 - Manage KDE passwords
https://bugzilla.redhat.com/show_bug.cgi?id=1218124
Rajeesh rajeeshknamb...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||rajeeshknamb...@gmail.com
--- Comment #1 from Rajeesh rajeeshknamb...@gmail.com ---
In general, looks good! There is one non-conformance: kwalletmanager5 should
obsolete kwalletmanager.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2), LGPL (v2 or later), GPL (v2 or later), Unknown or
generated. 2 files have unknown license. Detailed output of licensecheck
in /home/rajeesh/kwalletmanager5/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[!]: If the package is a rename of another package, proper Obsoletes and
Provides are present. kwalletmanager5 should obsolete kwalletmanager
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Rpmlint complains about the commented macros, but that should be okay
because of no official release yet
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]:
[Bug 1218124] Review Request: kwalletmanager5 - Manage KDE passwords
https://bugzilla.redhat.com/show_bug.cgi?id=1218124 Rajeesh rajeeshknamb...@gmail.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218124] Review Request: kwalletmanager5 - Manage KDE passwords
https://bugzilla.redhat.com/show_bug.cgi?id=1218124 --- Comment #2 from Jan Grulich jgrul...@redhat.com --- It cannot obsolete kwalletmanager, because we need both to be co-installable. Old kwalletmanager is still needed for KDE 4 applications, like KMail. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218124] Review Request: kwalletmanager5 - Manage KDE passwords
https://bugzilla.redhat.com/show_bug.cgi?id=1218124 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu Flags||fedora-cvs? --- Comment #4 from Rex Dieter rdie...@math.unl.edu --- New Package SCM Request === Package Name: kwalletmanager5 Short Description: Manage KDE passwords Upstream URL: https://projects.kde.org/projects/kde/kdeutils/kwalletmanager Owners: jgrulich group::kde-sig Branches: f22 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218124] Review Request: kwalletmanager5 - Manage KDE passwords
https://bugzilla.redhat.com/show_bug.cgi?id=1218124 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Blocks||1135103 (plasma5) Alias||kwalletmanager5 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1135103 [Bug 1135103] Plasma 5 Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
