[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 Fedora Update System changed: What|Removed |Added Fixed In Version|pagure-0.1.6-1.fc22 |pagure-0.1.6-1.el7 --- Comment #14 from Fedora Update System --- pagure-0.1.6-1.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||pagure-0.1.6-1.fc22 Resolution|--- |ERRATA Last Closed||2015-06-05 20:01:34 --- Comment #13 from Fedora Update System --- pagure-0.1.6-1.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- pagure-0.1.6-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 --- Comment #10 from Fedora Update System --- pagure-0.1.6-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/pagure-0.1.6-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 --- Comment #11 from Fedora Update System --- pagure-0.1.6-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/pagure-0.1.6-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127
Haïkel Guémar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #9 from Haïkel Guémar ---
+1 trivial things like that could be fixed at import time.
Since this package complies with Fedora Packaging guidelines, I hereby approve
it into
Fedora Packages Collection. Please submit a SCM request.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later)", "*No copyright* GPL (v2 or later)", "Unknown or
generated". 73 files have unknown license. Detailed output of
licensecheck in /home/haikel/1218127-pagure/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/httpd, /etc/httpd/conf.d
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pagure-
milters
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 --- Comment #8 from Pierre-YvesChibon --- I'll fix that before import or at the next revision, thanks ;-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 --- Comment #7 from Zbigniew Jędrzejewski-Szmek --- s/per say/per se/ Don't see anything else wrong ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 --- Comment #6 from Pierre-YvesChibon --- Thanks for the advice: Spec URL: http://pingou.fedorapeople.org/RPMs/pagure.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/pagure-0.1.2-2.fc21.src.rpm Changelog: * Sat May 09 2015 Pierre-Yves Chibon - 0.1.2-2 - Fix the Requires on the milter subpackage (adding: post, preun and postun) - Add systemd scriptlet to restart the service gracefully - Use versioned python macro (py2) - Ship the license in the milter subpackage as well - Use the %%license macro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 --- Comment #5 from Haïkel Guémar --- Small changes! * using python versionaed macros * Fixing systemd BR/R for pagure-milters subpackage to: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd And adding %post %postun %preun scriptlets too * License is not installed when you just install pagure-miltes, since I can understand you may install it on a different machine than pagure, then add it. * I suggest using %license macro ;) * cleaning out buildroot not required -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 --- Comment #4 from Pierre-YvesChibon --- Thanks Zbigniew Jędrzejewski-Szmek for finding it. Fixed and here is the new release: Update to 0.1.2: Spec URL: http://pingou.fedorapeople.org/RPMs/pagure.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/pagure-0.1.2-1.fc21.src.rpm Builds: epel7: http://koji.fedoraproject.org/koji/taskinfo?taskID=9680440 f22: http://koji.fedoraproject.org/koji/taskinfo?taskID=9680449 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 Haïkel Guémar changed: What|Removed |Added Status|NEW |ASSIGNED CC||karlthe...@gmail.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||zbys...@in.waw.pl --- Comment #3 from Zbigniew Jędrzejewski-Szmek --- Build fails with syntax error: $ python ./pagure-0.1.1/pagure/hooks/files/fedmsg_hook.py File "./pagure-0.1.1/pagure/hooks/files/fedmsg_hook.py", line 66 return SyntaxError: 'return' outside function -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 --- Comment #2 from Pierre-YvesChibon --- Update to 0.1.1: Spec URL: http://pingou.fedorapeople.org/RPMs/pagure.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/pagure-0.1.1-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218127] Review Request: pagure - A git-centered forge
https://bugzilla.redhat.com/show_bug.cgi?id=1218127 --- Comment #1 from Pierre-YvesChibon --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9650564 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
