[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #28 from Fedora Update System  ---
python-terminado-0.6-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #27 from Fedora Update System  ---
python-terminado-0.6-2.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-09 07:49:45



--- Comment #26 from Fedora Update System  ---
python-terminado-0.6-2.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #25 from Fedora Update System  ---
python-terminado-0.6-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f4b16616ba

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #24 from Fedora Update System  ---
python-terminado-0.6-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0235809c7f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #23 from Fedora Update System  ---
python-terminado-0.6-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4a054377c6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #22 from Fedora Update System  ---
python-terminado-0.6-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0235809c7f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #20 from Fedora Update System  ---
python-terminado-0.6-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4a054377c6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #21 from Fedora Update System  ---
python-terminado-0.6-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f4b16616ba

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #19 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-terminado

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

Tim Orling  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #18 from Tim Orling  ---
In Comment 17, I believe you meant "Do NOT build for python2 on EPEL", which is
what it says in the ChangeLog (python2-tornado package is too old on EPEL).

[x] Latest version is packaged
[x] nosetests -v (tests run verbosely)

Builds and all tests pass on F26 Rawhide and EPEL7 (Bonus, thank you!).

All review comments have been properly addressed. I am not including the result
of fedora-review since it is not significantly different than the first review
(except for the above two resolved issues).

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #17 from Orion Poplawski  ---
* Thu Feb 23 2017 Orion Poplawski  - 0.6-2
- Run tests verbosely
- Do build for python2 on EPEL

Spec URL: http://www.cora.nwra.com/~orion/fedora/python-terminado.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python-terminado-0.6-2.fc26.src.rpm

EPEL7 needs
https://bodhi.fedoraproject.org/updates/python-ptyprocess-0.5.1-6.el7 which has
a buildroot override.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #16 from Zbigniew Jędrzejewski-Szmek  ---
nosetests → nosetests -v

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1327979




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1327979
[Bug 1327979] Review Request: python-jupyter-notebook - A web-based
notebook environment for interactive computing
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #15 from Tim Orling  ---
Confirmed that William is busy, so I will continue with the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

Tim Orling  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #14 from Tim Orling  ---
Just FYI
mock build on CentOS7 fails:
DEBUG util.py:435:  Error: No Package found for python2-nose
DEBUG util.py:435:  Error: No Package found for python2-ptyprocess
DEBUG util.py:435:  Error: No Package found for python2-tornado >= 4.0.0
DEBUG util.py:435:  Error: No Package found for python34-ptyprocess

Koji EPEL7 build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17248219
same result, of course :)

Koji builds for F24, F25, rawhide all ok.
  F24: https://koji.fedoraproject.org/koji/taskinfo?taskID=17248224
  F25: https://koji.fedoraproject.org/koji/taskinfo?taskID=17248221
  rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=17248273

Had an issue with fedora-review on F24:
error: line 29: Package does not exist: %description -n python2-terminado

having proxy issues on my F25 box, so more later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

Tim Orling  changed:

   What|Removed |Added

 CC||ticot...@gmail.com
   Assignee|nob...@fedoraproject.org|ticot...@gmail.com



--- Comment #13 from Tim Orling  ---
Given that William Moreno changed the assignee to nobody, I will take this
review. I sent him email and am happy to give it back to him if desired.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #12 from Orion Poplawski  ---
* Mon Feb 22 2016 Orion Poplawski  - 0.6-1
- Update to 0.6
- Modernize spec

Spec URL: http://www.cora.nwra.com/~orion/fedora/python-terminado.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python-terminado-0.6-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #11 from Upstream Release Monitoring 
 ---
orion's scratch build of python-terminado-0.6-1.fc24.src.rpm for f24-candidate
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13102226

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #10 from Upstream Release Monitoring 
 ---
orion's scratch build of python-terminado-0.6-1.fc24.src.rpm for f24-candidate
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13101706

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

kevin.ab...@rutgers.edu changed:

   What|Removed |Added

 CC||kevin.ab...@rutgers.edu



--- Comment #9 from kevin.ab...@rutgers.edu ---
I'm unable to run the ipython notebook in fedora 23.  The terminal states that
the module terminado is unavailable. 

 I assume that this package is a requirement for the notebook.:
python-terminado
python3-terminado


  Is this correct?


Could someone advise regarding how to use the ipython notebook in fedora 23?

If this missing package is the problem can someone summarize what needs to be
done?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

William Moreno  changed:

   What|Removed |Added

 CC|williamjmore...@gmail.com   |
   Assignee|williamjmore...@gmail.com   |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

William Moreno williamjmore...@gmail.com changed:

   What|Removed |Added

 CC||or...@cora.nwra.com
  Flags||needinfo?(or...@cora.nwra.c
   ||om)



--- Comment #7 from William Moreno williamjmore...@gmail.com ---
Hi, do want to continue with this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

Orion Poplawski or...@cora.nwra.com changed:

   What|Removed |Added

  Flags|needinfo?(or...@cora.nwra.c |
   |om) |



--- Comment #8 from Orion Poplawski or...@cora.nwra.com ---
Yes, but I've been on vacation.  Will address issues soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #6 from William Moreno williamjmore...@gmail.com ---
Hi

1- There are some new cool macros for packaging python: %py2_build %py3_build
%py2_install %py3_install than you can use.

2- The python-tornado versión needed it is only in F23 on, there is a
python-tornado package in RHEL7 but I am not sure about the versión, the
python-tornado version need if is not available in epel6.

3- There is python-sphinx documentation directory in
https://github.com/takluyver/terminado/tree/master/doc than you build with
python-sphinx and include in a -doc subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #4 from Orion Poplawski or...@cora.nwra.com ---
Spec URL: http://www.cora.nwra.com/~orion/fedora/python-terminado.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python-terminado-0.5-3.fc21.src.rpm

* Mon Jul 27 2015 Orion Poplawski or...@cora.nwra.com - 0.5-3
- Add python2-terminado provides

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

William Moreno williamjmore...@gmail.com changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

William Moreno williamjmore...@gmail.com changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com



--- Comment #3 from William Moreno williamjmore...@gmail.com ---
(In reply to John Trowbridge from comment #1)


Will you take this review or I can take it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #5 from John Trowbridge jtrow...@redhat.com ---
(In reply to William Moreno from comment #3)
 (In reply to John Trowbridge from comment #1)
 
 
 Will you take this review or I can take it?

Go for it. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #2 from Orion Poplawski or...@cora.nwra.com ---
Sorry, this got lost while on vacation.

Spec URL: http://www.cora.nwra.com/~orion/fedora/python-terminado.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python-terminado-0.5-2.fc21.src.rpm

http://koji.fedoraproject.org/koji/taskinfo?taskID=10331229

* Fri Jul 10 2015 Orion Poplawski or...@cora.nwra.com - 0.5-2
- Build python2/3 from same tree
- BR/R tornado 4.0.0
- Fix changelog version number

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

John Trowbridge jtrow...@redhat.com changed:

   What|Removed |Added

 CC||jtrow...@redhat.com



--- Comment #1 from John Trowbridge jtrow...@redhat.com ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= Issues =
- version in last changelog entry is not latest

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
 Note: version in last changelog entry is not latest
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
 files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should