[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-async-some-1.0.2-1.f |nodejs-async-some-1.0.2-1.f |c21 |c22 --- Comment #10 from Fedora Update System --- nodejs-async-some-1.0.2-1.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nodejs-async-some-1.0.2-1.f ||c21 Resolution|--- |ERRATA Last Closed||2015-07-10 15:02:25 --- Comment #9 from Fedora Update System --- nodejs-async-some-1.0.2-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- nodejs-async-some-1.0.2-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 --- Comment #7 from Fedora Update System --- nodejs-async-some-1.0.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-async-some-1.0.2-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 --- Comment #6 from Fedora Update System --- nodejs-async-some-1.0.2-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/nodejs-async-some-1.0.2-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 Zuzana Svetlikova changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Zuzana Svetlikova --- Thank you. New Package SCM Request === Package Name: nodejs-async-some Short Description: Short-circuited, asynchronous version of Array.prototype.some Upstream URL: https://github.com/othiym23/async-some Owners: zvetlik Branches: f21 f22 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 Tom Hughes changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Tom Hughes --- That looks good now. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 --- Comment #2 from Zuzana Svetlikova --- Fixed. Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-async-some/nodejs-async-some.spec SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-async-some/nodejs-async-some-1.0.2-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231
Tom Hughes changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|t...@compton.nu
Flags||fedora-review?
--- Comment #1 from Tom Hughes ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues
==
[!]: Changelog in prescribed format.
- Email address is missing
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[!]: Latest version is packaged.
- Upstream has 1.0.2 now
[!]: Spec file according to URL is the same as in SRPM.
[!]: Rpmlint is run on all installed packages.
nodejs-async-some.noarch: W: spelling-error Summary(en_US) protototype ->
prototype, typewrote
nodejs-async-some.noarch: W: summary-not-capitalized C short-circuited,
asynchronous version of Array.protototype.some
nodejs-async-some.noarch: W: spelling-error %description -l en_US protototype
-> prototype, typewrote
nodejs-async-some.src: W: spelling-error Summary(en_US) protototype ->
prototype, typewrote
nodejs-async-some.src: W: summary-not-capitalized C short-circuited,
asynchronous version of Array.protototype.some
nodejs-async-some.src: W: spelling-error %description -l en_US protototype ->
prototype, typewrote
nodejs-async-some.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab:
line 15)
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 4 files have unknown license. Detailed
output of licensecheck in /home/tom/1221231-nodejs-async-
some/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor,
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 Bug 1221231 depends on bug 1221183, which changed state. Bug 1221183 Summary: Review request: nodejs-dezalgo - Contain async insanity so that the dark pony lord doesn't eat souls https://bugzilla.redhat.com/show_bug.cgi?id=1221183 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 Tom Hughes changed: What|Removed |Added CC||t...@compton.nu Depends On||1221183 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1221183 [Bug 1221183] Review request: nodejs-dezalgo - Contain async insanity so that the dark pony lord doesn't eat souls -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221231] Review Request: nodejs-async-some - short-circuited, asynchronous version of Array.protototype.some
https://bugzilla.redhat.com/show_bug.cgi?id=1221231 Zuzana Svetlikova changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
